public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Cc: trini@konsulko.com, sjg@chromium.org, cchavva@marvell.com,
	awilliams@marvell.com
Subject: [PATCH v3 0/8] Add support for cyclic function execution infrastruture
Date: Fri,  5 Aug 2022 16:26:02 +0200	[thread overview]
Message-ID: <20220805142610.375427-1-sr@denx.de> (raw)

This patchset adds the basic infrastructure to periodically execute
code, e.g. all 100ms. Examples for such functions might be LED blinking
etc. The functions that are hooked into this cyclic list should be
small timewise as otherwise the execution of the other code that relies
on a high frequent polling (e.g. UART rx char ready check) might be
delayed too much. This patch also adds the Kconfig option
CONFIG_CYCLIC_MAX_CPU_TIME_US, which configures the max allowed time
for such a cyclic function. If it's execution time exceeds this time,
this cyclic function will get removed from the cyclic list.

How is this cyclic functionality executed?
This patchset integrates the main function responsible for calling all
registered cyclic functions cyclic_run() into the common WATCHDOG_RESET
macro. This guarantees that cyclic_run() is executed very often, which
is necessary for the cyclic functions to get scheduled and executed at
their configured periods.

This cyclic infrastructure will be used by a board specific function on
the NIC23 MIPS Octeon board, which needs to check periodically, if a
PCIe FLR has occurred.

Ideas how to continue:
One idea is to rename WATCHDOG_RESET to something like SCHEDULE and
move the watchdog_reset call into this cyclic infrastructure as well.
Or to perhaps move the shell UART RX ready polling to a cyclic
function.

It's also possible to extend the "cyclic" command, to support the
creation of periodically executed shell commands (for testing etc).

Here the Azure build, without any issues:
https://dev.azure.com/sr0718/u-boot/_build/results?buildId=225&view=results

v2->v3:
- Added documentation

Thanks,
Stefan

Aaron Williams (1):
  mips: octeon_nic23: Add PCIe FLR fixup via cyclic infrastructure

Stefan Roese (7):
  time: Import time_after64() and friends from Linux
  cyclic: Add basic support for cyclic function execution infrastruture
  cyclic: Integrate cyclic infrastructure into WATCHDOG_RESET
  cyclic: Integrate cyclic functionality at bootup in board_r/f
  cyclic: Add 'cyclic list' command
  sandbox: Add cyclic demo function
  cyclic: Add documentation

 MAINTAINERS                        |   7 +
 board/Marvell/octeon_nic23/board.c | 197 +++++++++++++++++++++++++++++
 board/sandbox/sandbox.c            |  15 +++
 cmd/Kconfig                        |   7 +
 cmd/Makefile                       |   1 +
 cmd/cyclic.c                       |  40 ++++++
 common/Kconfig                     |  20 +++
 common/Makefile                    |   1 +
 common/board_f.c                   |   2 +
 common/board_r.c                   |   2 +
 common/cyclic.c                    | 112 ++++++++++++++++
 configs/octeon_nic23_defconfig     |   3 +
 configs/sandbox_defconfig          |   3 +
 doc/develop/cyclic.rst             |  50 ++++++++
 doc/develop/index.rst              |   1 +
 doc/usage/cmd/cyclic.rst           |  45 +++++++
 doc/usage/index.rst                |   1 +
 fs/cramfs/uncompress.c             |   2 +-
 include/cyclic.h                   |  97 ++++++++++++++
 include/time.h                     |  19 +++
 include/watchdog.h                 |  23 +++-
 21 files changed, 644 insertions(+), 4 deletions(-)
 create mode 100644 cmd/cyclic.c
 create mode 100644 common/cyclic.c
 create mode 100644 doc/develop/cyclic.rst
 create mode 100644 doc/usage/cmd/cyclic.rst
 create mode 100644 include/cyclic.h

-- 
2.37.1


             reply	other threads:[~2022-08-05 14:27 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05 14:26 Stefan Roese [this message]
2022-08-05 14:26 ` [PATCH v3 1/8] time: Import time_after64() and friends from Linux Stefan Roese
2022-08-05 16:48   ` Simon Glass
2022-08-05 14:26 ` [PATCH v3 2/8] cyclic: Add basic support for cyclic function execution infrastruture Stefan Roese
2022-08-05 16:48   ` Simon Glass
2022-08-15 13:49     ` Stefan Roese
2022-08-05 14:26 ` [PATCH v3 3/8] cyclic: Integrate cyclic infrastructure into WATCHDOG_RESET Stefan Roese
2022-08-05 16:48   ` Simon Glass
2022-08-15 16:16     ` Stefan Roese
2022-08-15 17:37       ` Simon Glass
2022-08-16 10:10         ` Stefan Roese
2022-08-05 14:26 ` [PATCH v3 4/8] cyclic: Integrate cyclic functionality at bootup in board_r/f Stefan Roese
2022-08-05 16:48   ` Simon Glass
2022-08-05 14:26 ` [PATCH v3 5/8] cyclic: Add 'cyclic list' command Stefan Roese
2022-08-05 16:48   ` Simon Glass
2022-08-15 16:24     ` Stefan Roese
2022-08-05 14:26 ` [PATCH v3 6/8] sandbox: Add cyclic demo function Stefan Roese
2022-08-05 16:48   ` Simon Glass
2022-08-16  8:38     ` Stefan Roese
2022-08-05 14:26 ` [PATCH v3 7/8] mips: octeon_nic23: Add PCIe FLR fixup via cyclic infrastructure Stefan Roese
2022-08-05 14:26 ` [PATCH v3 8/8] cyclic: Add documentation Stefan Roese
2022-08-05 16:48   ` Simon Glass
2022-08-15 16:18     ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220805142610.375427-1-sr@denx.de \
    --to=sr@denx.de \
    --cc=awilliams@marvell.com \
    --cc=cchavva@marvell.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox