public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Simon Glass <sjg@chromium.org>
Cc: Janne Grunau <j@jannau.net>, Lukasz Majewski <lukma@denx.de>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/1] usb: storage: stop probe on "Invalid device"
Date: Mon, 8 Aug 2022 11:18:10 +0900	[thread overview]
Message-ID: <20220808021810.GE44816@laputa> (raw)
In-Reply-To: <CAPnjgZ2sHgaOeFqrMo7VwtUUouFPs257Lc5s9d0T16YFkLDgNQ@mail.gmail.com>

Hi Simon,

On Sun, Aug 07, 2022 at 09:47:56AM -0600, Simon Glass wrote:
> Hi Marek,
> 
> On Thu, 21 Jul 2022 at 11:29, Janne Grunau <j@jannau.net> wrote:
> >
> > Fixes a crash during probing of sd card readers without medium present.
> >
> > Link: https://github.com/AsahiLinux/linux/issues/44
> > Signed-off-by: Janne Grunau <j@jannau.net>
> > ---
> >  common/usb_storage.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>

I made this comment on another bug report:
https://lists.denx.de/pipermail/u-boot/2022-July/489717.html

I think we should continue to scan the *bus* even if detecting/activating
a specific device fails.

Moreover, we would better do full recovery from blk_create_device(f)()
as it has some side-effects, including an increased "devnum".

-Takahiro Akashi

> Shall I pick this one up?
> 
> Regards,
> Simon

  reply	other threads:[~2022-08-08  2:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21 17:29 [PATCH 1/1] usb: storage: stop probe on "Invalid device" Janne Grunau
2022-08-07 15:47 ` Simon Glass
2022-08-08  2:18   ` AKASHI Takahiro [this message]
2022-08-08  8:45     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220808021810.GE44816@laputa \
    --to=takahiro.akashi@linaro.org \
    --cc=j@jannau.net \
    --cc=lukma@denx.de \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox