From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A09BC19F2A for ; Mon, 8 Aug 2022 02:18:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E49FE8497D; Mon, 8 Aug 2022 04:18:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="zE1jqopX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 410E58497D; Mon, 8 Aug 2022 04:18:20 +0200 (CEST) Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CDECD83F88 for ; Mon, 8 Aug 2022 04:18:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x102f.google.com with SMTP id t22-20020a17090a449600b001f617f2bf3eso4189824pjg.0 for ; Sun, 07 Aug 2022 19:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc; bh=XUM2i5CE3zcJjQFGhHuohKUoL76UkwkFSfdppa7u1xA=; b=zE1jqopXKouzRj7hlIsuRv8srWuzHNrqFAx6zPnSHSo7KMRkqb//5apJ9UEe84cOhR EcQXX9pbVuc+2BNb7stAD8ww5L280YbcVXd9tZTWVTx4xF9XMXJMSBkirbfGnpFFPNpQ tRSmAJu94MTdNjycVL8XDVaNdMKzlWzE8qrxpZRfL2/gMg2+yGAqOMXRDopChDHkc0oJ d5ASzAiO4ScUhflR9y5DYsZkMsU2pVsOVu0FIEvBfm+SE3p/9XhQsYr2xw2w0R6Yk9bM BuVOGjH1Vc61raIRf0AgjGmuFXa+iWeB0kvif7uuxijbOpnIcfzuQcgoO8qECjCYxDFD 7qPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=XUM2i5CE3zcJjQFGhHuohKUoL76UkwkFSfdppa7u1xA=; b=rR15O8Y2yhO6mQbEzJrduy0eLgqEe24B7ztcEvtbqJeH52XclVViEtp7/sZGTgrV/0 btTlVvnPzvqviBinvB9BCJilxxtN3j1Bvec8JL87Z+fWYnaSIDo25dn0ZGAhM1P0+Six daYh+kWtresXjeG+UPwLup3QQYae4+DfH2jXL3eyPFOpULA5PhmhbJFZDyb0HskzJa4X v54VXjuZap24jpzwQZz+rDbjhmH1CnVJhDI0hvAREPL1RwT0g98jwlstqTSlfTj/zjd8 YRIaM4bM5uHW27vEhOd2DkXmny+EIOydKW0jKCxv3kv3sKnYe3oEayL0R5pSDXwPbybw M1Cg== X-Gm-Message-State: ACgBeo3Mcit/ihGtD4hR/2BtGAD3/Z32SGo4FDEk6fNhLgOxv+cELFZE 5Aj64YDLKiHwgLAqXxnbtArT1A== X-Google-Smtp-Source: AA6agR4HtKEukoGoHQzYnDuGMVoYGHq57q7JRKU7W/JfejrniW7PlCqwUVl/Exbr+z+beHN6JdeHTA== X-Received: by 2002:a17:902:7e89:b0:170:94d6:be73 with SMTP id z9-20020a1709027e8900b0017094d6be73mr7032769pla.52.1659925095064; Sun, 07 Aug 2022 19:18:15 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:28f4:939:e88:270f]) by smtp.gmail.com with ESMTPSA id bd15-20020a656e0f000000b0041d2966a0cdsm3734695pgb.23.2022.08.07.19.18.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Aug 2022 19:18:14 -0700 (PDT) Date: Mon, 8 Aug 2022 11:18:10 +0900 From: AKASHI Takahiro To: Simon Glass Cc: Janne Grunau , Lukasz Majewski , U-Boot Mailing List Subject: Re: [PATCH 1/1] usb: storage: stop probe on "Invalid device" Message-ID: <20220808021810.GE44816@laputa> Mail-Followup-To: AKASHI Takahiro , Simon Glass , Janne Grunau , Lukasz Majewski , U-Boot Mailing List References: <20220721172935.13864-1-j@jannau.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On Sun, Aug 07, 2022 at 09:47:56AM -0600, Simon Glass wrote: > Hi Marek, > > On Thu, 21 Jul 2022 at 11:29, Janne Grunau wrote: > > > > Fixes a crash during probing of sd card readers without medium present. > > > > Link: https://github.com/AsahiLinux/linux/issues/44 > > Signed-off-by: Janne Grunau > > --- > > common/usb_storage.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > Reviewed-by: Simon Glass I made this comment on another bug report: https://lists.denx.de/pipermail/u-boot/2022-July/489717.html I think we should continue to scan the *bus* even if detecting/activating a specific device fails. Moreover, we would better do full recovery from blk_create_device(f)() as it has some side-effects, including an increased "devnum". -Takahiro Akashi > Shall I pick this one up? > > Regards, > Simon