From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20B63C00140 for ; Mon, 8 Aug 2022 07:52:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0CE2A8499D; Mon, 8 Aug 2022 09:52:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="kqVlTgJM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D1BB2849B8; Mon, 8 Aug 2022 09:52:00 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1991583E4C for ; Mon, 8 Aug 2022 09:51:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 937D860E08; Mon, 8 Aug 2022 07:51:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E585C433D6; Mon, 8 Aug 2022 07:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659945116; bh=pGSjUvV5N1bQba2U7OjJ+iH1SrPf78jKPy9p61z4wiY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kqVlTgJMdStIzJUIq8LtA1RFdGAgHOfUc6lkc3nKJpck+lq6n4eZBQQiOsE2Q88ba NVdQ8pE4TLyA07uAKaLJwEZ5FS3N1GwF0NdGPsuKoIUvwRRWeQj/eN4pzj18hBZkzq oZ+XqPVfwdOElwskG63wsCWcGloYVnZpI4jfHCd00VsvXAX4fme/GMPTa5Ag2TJqa8 mKwjWBeT3g7rj7WaqaZpifHrfdoYd8HBGO80srAK6lpQBN7ZDcRyBfVCHOmzvzE4hq vo86G+Q2uI68s5Au2FwnOSjaH5cVUOkLL7yeMnnBuM7645OGvMuTNn0XQYBzvextiJ jYG1HaNJ/r7OA== Date: Mon, 8 Aug 2022 09:51:49 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Tom Rini Cc: Pali =?UTF-8?B?Um9ow6Fy?= , u-boot@lists.denx.de Subject: Re: Broken commit de47ff536363289f92f85ed1e4901724d238432d Message-ID: <20220808095149.2e0ed3ff@thinkpad> In-Reply-To: <20220805222019.GE1146598@bill-the-cat> References: <20220803161318.GS1146598@bill-the-cat> <20220805142124.6swsha6aj62f33e3@pali> <20220805144731.GV1146598@bill-the-cat> <20220805145935.xumynhjbih3nekjq@pali> <20220805150340.GX1146598@bill-the-cat> <20220805151259.hdftfa3utfiq4i3w@pali> <20220805154400.GA1146598@bill-the-cat> <20220805155135.r5dctspg2oohzdev@pali> <20220805155453.GC1146598@bill-the-cat> <20220805201701.7t37kxn64qaiye3n@pali> <20220805222019.GE1146598@bill-the-cat> X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Fri, 5 Aug 2022 18:20:19 -0400 Tom Rini wrote: > On Fri, Aug 05, 2022 at 10:17:01PM +0200, Pali Roh=C3=A1r wrote: > > On Friday 05 August 2022 11:54:53 Tom Rini wrote: =20 > > > On Fri, Aug 05, 2022 at 05:51:35PM +0200, Pali Roh=C3=A1r wrote: =20 > > > > On Friday 05 August 2022 11:44:00 Tom Rini wrote: =20 > > > > > On Fri, Aug 05, 2022 at 05:12:59PM +0200, Pali Roh=C3=A1r wrote: = =20 > > > > > > On Friday 05 August 2022 11:03:40 Tom Rini wrote: =20 > > > > > > > On Fri, Aug 05, 2022 at 04:59:35PM +0200, Pali Roh=C3=A1r wro= te: =20 > > > > > > > > On Friday 05 August 2022 10:47:31 Tom Rini wrote: =20 > > > > > > > > > On Fri, Aug 05, 2022 at 04:21:24PM +0200, Pali Roh=C3=A1r= wrote: =20 > > > > > > > > > > On Wednesday 03 August 2022 12:13:18 Tom Rini wrote: =20 > > > > > > > > > > > On Wed, Aug 03, 2022 at 06:00:13PM +0200, Pali Roh=C3= =A1r wrote: =20 > > > > > > > > > > > > On Tuesday 02 August 2022 06:58:26 Tom Rini wrote: = =20 > > > > > > > > > > > > > On Tue, Aug 02, 2022 at 11:13:38AM +0200, Pali Ro= h=C3=A1r wrote: > > > > > > > > > > > > > =20 > > > > > > > > > > > > > > Hello Tom! > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > Your commit de47ff536363289f92f85ed1e4901724d23= 8432d ("Convert > > > > > > > > > > > > > > CONFIG_SYS_MPC85XX_NO_RESETVEC to Kconfig") see= ms to be broken. =20 > > > > > > > > > > > > >=20 > > > > > > > > > > > > > I thought I had managed to mirror the TPL/SPL/ful= l usage that was there > > > > > > > > > > > > > prior, but apparently some got missed. =20 > > > > > > > > > > > >=20 > > > > > > > > > > > > Yea, conversion to Kconfig seems that was incorrect= . =20 > > > > > > > > > > >=20 > > > > > > > > > > > As the config files were just unclear, but you seem t= o understand what > > > > > > > > > > > it's supposed to be, a patch to clean it up would be = most appreciated, > > > > > > > > > > > thanks. > > > > > > > > > > >=20 > > > > > > > > > > > --=20 > > > > > > > > > > > Tom =20 > > > > > > > > > >=20 > > > > > > > > > > Broken is also commit d433c74eecdce1e4952ef4e8c712a9289= c0dfcc2. Seems > > > > > > > > > > that all kconfig migration changes done after that comm= it are broken. > > > > > > > > > >=20 > > > > > > > > > > I really do not have energy to investigate what and how= was broken due > > > > > > > > > > to incorrect kconfig migration. > > > > > > > > > >=20 > > > > > > > > > >=20 > > > > > > > > > > I did simple test. Applied following change: > > > > > > > > > >=20 > > > > > > > > > > diff --git a/include/configs/p1_p2_rdb_pc.h b/include/c= onfigs/p1_p2_rdb_pc.h > > > > > > > > > > index a6523753d5ca..489f24df0ab1 100644 > > > > > > > > > > --- a/include/configs/p1_p2_rdb_pc.h > > > > > > > > > > +++ b/include/configs/p1_p2_rdb_pc.h > > > > > > > > > > @@ -624,3 +624,7 @@ __stringify(__PCIE_RST_CMD)"\0" > > > > > > > > > > "bootm $norbootaddr - $norfdtaddr" > > > > > > > > > > =20 > > > > > > > > > > #endif /* __CONFIG_H */ > > > > > > > > > > + > > > > > > > > > > +#ifdef CONFIG_SDCARD > > > > > > > > > > +#error > > > > > > > > > > +#endif > > > > > > > > > >=20 > > > > > > > > > > And then called: > > > > > > > > > >=20 > > > > > > > > > > make CROSS_COMPILE=3Dpowerpc-linux-gnuspe- P2020RDB-PC_= defconfig u-boot.bin > > > > > > > > > >=20 > > > > > > > > > > And it failed, even when this defconfig file is not SD = card builds. =20 > > > > > > > > >=20 > > > > > > > > > Where is PBL in that case even then? =20 > > > > > > > >=20 > > > > > > > > P2020 (and older) are pre-PBL boards, they do not support N= XP PBL > > > > > > > > header. =20 > > > > > > >=20 > > > > > > > Ah, OK, then it should just be removing TARGET_P2020RDB from = the choice > > > > > > > on "Freescale PBL load location". > > > > > > >=20 > > > > > > > --=20 > > > > > > > Tom =20 > > > > > >=20 > > > > > > I just do not understand. > > > > > >=20 > > > > > > P10** and P20** do not support NXP PBL. They support only pre-P= BL and > > > > > > for SD card pre-PBL support I added option FSL_PREPBL_ESDHC_BOO= T_SECTOR. > > > > > >=20 > > > > > > But CONFIG_SDCARD is automatically set when SYS_EXTRA_OPTIONS c= ontains > > > > > > "SDCARD" string and CONFIG_SDCARD is used then also in P10** an= d P20** > > > > > > SD-card version of SPL to load proper U-Boot. =20 > > > > >=20 > > > > > So CONFIG_SDCARD was over-loaded? That's very frustrating. That's= what > > > > > needs to be corrected then. =20 > > > >=20 > > > > But it was correct, no? CONFIG_SDCARD ensures that U-Boot is compil= ed in > > > > mode in which can be booted from SD card. Or what do you have in mi= nd as > > > > purpose of this symbol? > > > >=20 > > > > The issue is that your Kconfig migration changes enabled CONFIG_SDC= ARD > > > > also when building (parallel) NOR version of U-Boot. =20 > > >=20 > > > To me, the biggest issue is that "CONFIG_SDCARD" exists. It's very mu= ch > > > non-descriptive and that for some platforms it means "we have NXP PBL" > > > and others means "we're booting from SDCARD". The former should be > > > renamed to be descriptive, and the latter should re-use CONFIG_SD_CARD > > > which is still a bad name, but what everyone else uses, so makes > > > renaming it later to something less bad easier. =20 > >=20 > > So I hope that you will do something with it. I already spent lot of > > time to fix and improve powerpc support, but the result is that my > > patches are on the list, mostly ignored; but changes which are breaking > > powerpc support are happily merging. In this state I'm loosing any > > motivation to continue development as it is needed to do again to find > > out what new is broken. =20 >=20 > I'm not planning to try and further fiddle with those symbols. A > simple revert is not possible as CONFIG_SYS_EXTRA_OPTIONS is gone. I > assume that Marek will be picking up your PowerPC patches at this point, > so any further work you're doing in that area shouldn't be delayed. > I'll put re-examining this on my TODO list, but it's below finishing my > CONFIG_SYS_* audit, and then renaming stuff to CFG_SYS. >=20 > You should fix whatever platforms you have access to and ignore the > rest, I feel likely to be removing most of them shortly at this point. >=20 I shall try to fix this on our platform by "reverting" these to different names, so that there are no new CONFIG_ macros. Marek