From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28888C00140 for ; Mon, 8 Aug 2022 19:09:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2E7CD845F8; Mon, 8 Aug 2022 21:08:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="cjYUdIR9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 87E9A845FA; Mon, 8 Aug 2022 21:08:28 +0200 (CEST) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 473ED845F7 for ; Mon, 8 Aug 2022 21:08:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id j17so2422898qtp.12 for ; Mon, 08 Aug 2022 12:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=a+/j24qPnGgd5hEV1r/fscfGgBw+VCau+PYh4YIgas4=; b=cjYUdIR9qJKzqHhIxUz574Rb2J0ESRuFSPnJ2siPyZCaGl3LkgWkyhYuJI22jf2ztM 2tXlXnq6tICKVxqC65hishrRQqSIE42IKqrxQu+iuEKEWcRR3Nwyw9c+8LY1nYqAoCKm GAetYk3uiP765UR1Js3lS3M/vEDmUcAOx/zXc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=a+/j24qPnGgd5hEV1r/fscfGgBw+VCau+PYh4YIgas4=; b=xUuHCU2ngVSSbWLrRRnrClx/A2etRaQ4BA0ursjJ06GpGvCUWNTrGuH8skx0OCn94O +MMcYfKzfxSSJ3X7+pBDoAg5i9xCzP1HN/ZgWtLDS72+gf2MF4eogWw/Mb3Yngtxu07o xz1bagoG86dTCNB+Cuvt0mcleo2YEsBvfHksKq4uG/B03Bw6jQu8pdcFVhxokmwFVQlM Z83PtivKchbzf/kqocc6Vo2cfpf2hdMKX/btyQMPOO/eOl81JP6IefxIrieg7kalyzpa JdNQKlBH1erx0DW2UBE5k/KN/KmoWg+NPrs9TVB/me6g6bPrcE2haAjHcimM4Z/GFVji DufQ== X-Gm-Message-State: ACgBeo324UlqjIEEVeOgpFEQ8wRqAt9KQL9/E3FF20MoULRJwKwekMNe yZKv+ZcSYtSd7ISvsgNSq/cAPOo4BQ8qqnHv X-Google-Smtp-Source: AA6agR6KIAUeYZAEQqBbsKsQOSGNcdmiymDFL1NilK2xc9De0OgVkbqgBBj2sxyfSlK4kqBQKHTpcA== X-Received: by 2002:a05:622a:c:b0:342:ea37:3882 with SMTP id x12-20020a05622a000c00b00342ea373882mr10660314qtw.632.1659985705916; Mon, 08 Aug 2022 12:08:25 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id e9-20020ac845c9000000b0031ee3449f34sm8365383qto.86.2022.08.08.12.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Aug 2022 12:08:25 -0700 (PDT) Date: Mon, 8 Aug 2022 15:08:23 -0400 From: Tom Rini To: Heinrich Schuchardt Cc: Joe Hershberger , Ramon Fried , Marek =?iso-8859-1?Q?Beh=FAn?= , T Karthik Reddy , Vladimir Oltean , Ariel D'Alessandro , Michal Simek , Nate Drude , u-boot@lists.denx.de Subject: Re: [PATCH 1/1] net: phy: possible NULL dereference in fixed_phy_create() Message-ID: <20220808190823.GO1146598@bill-the-cat> References: <20220711174013.116975-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZpGO63gtUb5k8p8Q" Content-Disposition: inline In-Reply-To: <20220711174013.116975-1-heinrich.schuchardt@canonical.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --ZpGO63gtUb5k8p8Q Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 11, 2022 at 07:40:13PM +0200, Heinrich Schuchardt wrote: > We check if phydev is NULL. Only but if it is non-NULL we set one > component of phydev. But even if it is NULL we set another. We should not > dereference NULL in either case. >=20 > Fixes: e24b58f5ed4f ("net: phy: don't require PHY interface mode during P= HY creation") > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Marek Beh=FAn Applied to u-boot/master, thanks! --=20 Tom --ZpGO63gtUb5k8p8Q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLxXycACgkQFHw5/5Y0 tyw/mgv/Zp5KgOlsRzHU63hyvYgtXuTFPnFIH1BKTT1zeR4v1hWzCLgUtutZg5Mp Vi5zUoNZEYbRXvn+TtzOfseB4thUSlKQrKMbQxbsLoHE3L6TR91w0YKoraynWB4w wx+kbzK/1dlkI3ntxV8P7uQTC84OevcDUrYaKq3u9AP9f/z+dICRZBY77EHa8yTk XNz6l+4NVc8htN9AoCl8N73egy9w1x/DBkRctzbMFYLz2FbJdVES180hQUI1p6pr OmcL4Gb/bY5QDoBCODl6XW6PvBhhA1kL3kS091ZSogpDEj6Jmyl2NxVwTv062kuO zxR3TeaEn4czkq2m4ZSVztQsvJ54pDE8NjnUrLNxpSPzzkj3dRk6ZI+TXZk4l4Zv 5s2PezcaWoWLCeZ+JSXgltugY7O2QGqF/q4qhubHgsBFDFi0JErxdZvazUxKmZ1d 3YxFjgqqvJMKsu/VCdaLwH+lVC4Y+8GKnFKl66ahkb2nrVaRbOZR3dC8BzSRjTG8 7p6aQ5xt =mi+d -----END PGP SIGNATURE----- --ZpGO63gtUb5k8p8Q--