From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7159C19F2D for ; Tue, 9 Aug 2022 07:57:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0570C84539; Tue, 9 Aug 2022 09:57:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="ep6flV89"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B55E284539; Tue, 9 Aug 2022 09:57:16 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3E00184980 for ; Tue, 9 Aug 2022 09:57:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D33F5612B5; Tue, 9 Aug 2022 07:57:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92E8EC433C1; Tue, 9 Aug 2022 07:57:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660031829; bh=gY6JZ1zP3JmdUq/X829JkmJNmjspHRqUR9a7aBVrV2M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ep6flV899zE8qM6Kdp9xUUSgHF+UShouqmuPtlOh+P6+KwuEXM9rOAIqRlULWKUy4 gybGB85opNioP1yvuHE51raIMkb6YiXz8fj5YTYsFaotG2AiG+1o+MMo2ccWX7cYh6 XyFIIubgYnqalFGlSnBJeOatL53Mb9YM28OVaJnbJHnjJusXbRXO657lpwM0iSkal2 xwWYzsxqyej4bxh9Eh5ypFPsXzy7myRXk0QJI+aayAMXvaeJ6pKvS8jpVcxWAYQwmT 4sY9bE7Dug5j9aWbBrILEWbQO0n4e1pvMFDRrkSRJ8tkIjK9LLszx5FVYykbuBGRoi ZwcZNx8zQzoUA== Date: Tue, 9 Aug 2022 09:56:48 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Pali =?UTF-8?B?Um9ow6Fy?= , Stefan Roese Cc: =?UTF-8?B?UGF3ZcWC?= Anikiel , Adrian Fiergolski , Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH] misc: atsha204a: Don't check for error when waking up the device Message-ID: <20220809095648.29b726b5@thinkpad> In-Reply-To: <20220804110344.24268-1-pali@kernel.org> References: <20220804110344.24268-1-pali@kernel.org> X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Thu, 4 Aug 2022 13:03:44 +0200 Pali Roh=C3=A1r wrote: > The device ignores any levels or transitions on the SCL pin when the devi= ce > is idle, asleep or during waking up. >=20 > Linux kernel driver for atsha204a (atmel-sha204a.ko) also ignores return > value from i2c wakeup send command, see: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/d= rivers/crypto/atmel-i2c.c?h=3Dv5.19#n174 >=20 > And also userspace Turris libatsha204 library ignores return value from > wakeup send command, see: > https://gitlab.nic.cz/turris/libatsha204/-/blob/v29.2/src/libatsha204/lay= er_ni2c.c#L75-76 >=20 > U-Boot driver should do same thing. >=20 > Fixes waking up ATSHA204 on Turris 1.x boards. >=20 > Signed-off-by: Pali Roh=C3=A1r Reviewed-by: Marek Beh=C3=BAn Stefan, will you apply this via marvell?