public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Marek Behún" <kabel@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: Stefan Roese <sr@denx.de>, u-boot@lists.denx.de
Subject: Re: [PATCH] arm: mvebu: Define env_sf_get_env_addr() for all Armada boards in SPL
Date: Tue, 9 Aug 2022 11:20:12 +0200	[thread overview]
Message-ID: <20220809112012.5edd7f65@thinkpad> (raw)
In-Reply-To: <20220808171343.10176-1-pali@kernel.org>

On Mon,  8 Aug 2022 19:13:43 +0200
Pali Rohár <pali@kernel.org> wrote:

> SPI0 CS0 Flash is mapped to address range 0xD4000000 - 0xD7FFFFFF by BootROM.
> Proper U-Boot removes this direct mapping. So it is available only in SPL.
> This applies for all 32-bit Armada BootROMs. SPL mvebu code is used only on
> 32-bit Armada SoCs. So move env_sf_get_env_addr() function from Turris
> Omnia board to common SPL mvebu code and add proper checks for SPI0 CS0.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>

Do we know that this will work for all flash memories used on those
other boards? Some boards may have non-compliant SPI-NORs soldered on.

But if BootROM on those boards also uses this mapping to read flash, it
should be okay...

  reply	other threads:[~2022-08-09  9:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 17:13 [PATCH] arm: mvebu: Define env_sf_get_env_addr() for all Armada boards in SPL Pali Rohár
2022-08-09  9:20 ` Marek Behún [this message]
2022-08-09  9:27   ` Pali Rohár
2022-08-09 12:45     ` Marek Behún
2022-08-09 13:12       ` Stefan Roese
2022-08-23 14:57 ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220809112012.5edd7f65@thinkpad \
    --to=kabel@kernel.org \
    --cc=pali@kernel.org \
    --cc=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox