From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5B3FC19F2D for ; Tue, 9 Aug 2022 09:20:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 67AEA84594; Tue, 9 Aug 2022 11:20:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="tEcvuBXW"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D939684314; Tue, 9 Aug 2022 11:20:37 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 77420845F1 for ; Tue, 9 Aug 2022 11:20:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6A00660EEF; Tue, 9 Aug 2022 09:20:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21462C433D6; Tue, 9 Aug 2022 09:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660036829; bh=8DHxrEuXE9PQOkANg89qFQw6VX34300oFiKlcdETpYc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tEcvuBXW6N+Y+FXsBDDXDF7spxwjNUqX4y1WHUuFn8H4Te2Cfh6CQKKrcLg3OPadC 7f/Y2gq/hJArmeIbjc3se7KdsymDXqHo/40O5kfGSqh++CkQaEADuq4c7JopHhFbz2 1PzvVLi2OiuoRFqeOurUpAu/Ejtm4u58zruvuWI08XqGcASnF6hYt55xFeun0AeqQi FS5iA8vdZXl22uR8xZCrxOC5Oi8e/DrK6ha63jzkshxnA22/xf/TOr3oxCAZHa4VZX 27GD+EM+8FZRrfhJYjw/RdUD4dCb2b+0MCpOLMVD7WHzKN7Tw5YfGE9ubJ/87g01Ya ggu2SSYr+NiqQ== Date: Tue, 9 Aug 2022 11:20:12 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Stefan Roese , u-boot@lists.denx.de Subject: Re: [PATCH] arm: mvebu: Define env_sf_get_env_addr() for all Armada boards in SPL Message-ID: <20220809112012.5edd7f65@thinkpad> In-Reply-To: <20220808171343.10176-1-pali@kernel.org> References: <20220808171343.10176-1-pali@kernel.org> X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Mon, 8 Aug 2022 19:13:43 +0200 Pali Roh=C3=A1r wrote: > SPI0 CS0 Flash is mapped to address range 0xD4000000 - 0xD7FFFFFF by Boot= ROM. > Proper U-Boot removes this direct mapping. So it is available only in SPL. > This applies for all 32-bit Armada BootROMs. SPL mvebu code is used only = on > 32-bit Armada SoCs. So move env_sf_get_env_addr() function from Turris > Omnia board to common SPL mvebu code and add proper checks for SPI0 CS0. >=20 > Signed-off-by: Pali Roh=C3=A1r Do we know that this will work for all flash memories used on those other boards? Some boards may have non-compliant SPI-NORs soldered on. But if BootROM on those boards also uses this mapping to read flash, it should be okay...