From: Lee Jones <lee@kernel.org>
To: u-boot@lists.denx.de, sjg@chromium.org, philipp.tomsich@vrull.eu,
kever.yang@rock-chips.com
Cc: Lee Jones <lee@kernel.org>, Xavier Drudis Ferran <xdrudis@tinet.cat>
Subject: [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling
Date: Thu, 11 Aug 2022 08:58:46 +0100 [thread overview]
Message-ID: <20220811075848.1791050-2-lee@kernel.org> (raw)
In-Reply-To: <20220811075848.1791050-1-lee@kernel.org>
Functions pointed to by this op pointer can return non-zero values
indicating an error. Ensure any error value is propagated back up the
call-chain.
Signed-off-by: Lee Jones <lee@kernel.org>
Tested-by: Xavier Drudis Ferran <xdrudis@tinet.cat>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
---
drivers/ram/rockchip/sdram_rk3399.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
index c0a06dcaed..0af0fa9e7b 100644
--- a/drivers/ram/rockchip/sdram_rk3399.c
+++ b/drivers/ram/rockchip/sdram_rk3399.c
@@ -3005,7 +3005,9 @@ static int sdram_init(struct dram_info *dram,
params->base.stride = calculate_stride(params);
dram_all_config(dram, params);
- dram->ops->set_rate_index(dram, params);
+ ret = dram->ops->set_rate_index(dram, params);
+ if (ret)
+ return ret;
debug("Finish SDRAM initialization...\n");
return 0;
--
2.37.1.559.g78731f0fdb-goog
next prev parent reply other threads:[~2022-08-11 11:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 7:58 [PATCH 0/3] rockchip: Fix RAM training on RK3399 based platforms (Rock Pi 4) Lee Jones
2022-08-11 7:58 ` Lee Jones [this message]
2022-08-11 7:58 ` [PATCH 2/3] ram: rk3399: Fix faulty frequency change reports Lee Jones
2022-08-11 7:58 ` [PATCH 3/3] ram: rk3399: Conduct memory training at 400MHz Lee Jones
2022-08-11 14:38 ` Michal Suchánek
-- strict thread matches above, loose matches on Subject: below --
2022-06-21 10:07 [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling Lee Jones
2022-06-27 8:39 ` Lee Jones
2022-07-01 12:05 ` Kever Yang
2022-07-04 9:23 ` Lee Jones
2022-07-04 10:49 ` Kever Yang
2022-07-04 10:58 ` Lee Jones
2022-07-01 12:04 ` Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811075848.1791050-2-lee@kernel.org \
--to=lee@kernel.org \
--cc=kever.yang@rock-chips.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xdrudis@tinet.cat \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox