public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de
Subject: [PATCH v2 5/6] serial: Call flush() before changing baudrate
Date: Thu, 11 Aug 2022 14:39:24 +0200	[thread overview]
Message-ID: <20220811123925.23981-6-pali@kernel.org> (raw)
In-Reply-To: <20220811123925.23981-1-pali@kernel.org>

Changing baudrate is sensitive operation. To ensure that U-Boot messages
printed before changing baudrate are not lost, call new U-Boot console
flush() function.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
 cmd/load.c                     | 5 +++++
 drivers/serial/serial-uclass.c | 1 +
 drivers/serial/serial.c        | 1 +
 3 files changed, 7 insertions(+)

diff --git a/cmd/load.c b/cmd/load.c
index e44ae0d56b75..5c4f34781d45 100644
--- a/cmd/load.c
+++ b/cmd/load.c
@@ -83,6 +83,7 @@ static int do_load_serial(struct cmd_tbl *cmdtp, int flag, int argc,
 		printf("## Switch baudrate to %d bps and press ENTER ...\n",
 			load_baudrate);
 		udelay(50000);
+		flush();
 		gd->baudrate = load_baudrate;
 		serial_setbrg();
 		udelay(50000);
@@ -126,6 +127,7 @@ static int do_load_serial(struct cmd_tbl *cmdtp, int flag, int argc,
 		printf("## Switch baudrate to %d bps and press ESC ...\n",
 			current_baudrate);
 		udelay(50000);
+		flush();
 		gd->baudrate = current_baudrate;
 		serial_setbrg();
 		udelay(50000);
@@ -317,6 +319,7 @@ int do_save_serial(struct cmd_tbl *cmdtp, int flag, int argc,
 		printf("## Switch baudrate to %d bps and press ESC ...\n",
 			(int)current_baudrate);
 		udelay(50000);
+		flush();
 		gd->baudrate = current_baudrate;
 		serial_setbrg();
 		udelay(50000);
@@ -471,6 +474,7 @@ static int do_load_serial_bin(struct cmd_tbl *cmdtp, int flag, int argc,
 		printf("## Switch baudrate to %d bps and press ENTER ...\n",
 			load_baudrate);
 		udelay(50000);
+		flush();
 		gd->baudrate = load_baudrate;
 		serial_setbrg();
 		udelay(50000);
@@ -533,6 +537,7 @@ static int do_load_serial_bin(struct cmd_tbl *cmdtp, int flag, int argc,
 		printf("## Switch baudrate to %d bps and press ESC ...\n",
 			current_baudrate);
 		udelay(50000);
+		flush();
 		gd->baudrate = current_baudrate;
 		serial_setbrg();
 		udelay(50000);
diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c
index 4e32270d4660..0f6860d9100e 100644
--- a/drivers/serial/serial-uclass.c
+++ b/drivers/serial/serial-uclass.c
@@ -527,6 +527,7 @@ static int on_baudrate(const char *name, const char *value, enum env_op op,
 			printf("## Switch baudrate to %d bps and press ENTER ...\n",
 			       baudrate);
 			udelay(50000);
+			flush();
 		}
 
 		gd->baudrate = baudrate;
diff --git a/drivers/serial/serial.c b/drivers/serial/serial.c
index 6cdbb89841c1..4b525b644928 100644
--- a/drivers/serial/serial.c
+++ b/drivers/serial/serial.c
@@ -81,6 +81,7 @@ static int on_baudrate(const char *name, const char *value, enum env_op op,
 			printf("## Switch baudrate to %d"
 				" bps and press ENTER ...\n", baudrate);
 			udelay(50000);
+			flush();
 		}
 
 		gd->baudrate = baudrate;
-- 
2.20.1


  parent reply	other threads:[~2022-08-11 12:40 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11 12:39 [PATCH v2 0/6] console: Implement flush() function Pali Rohár
2022-08-11 12:39 ` [PATCH v2 1/6] sandbox: Add function os_flush() Pali Rohár
2022-08-11 14:47   ` Simon Glass
2022-08-11 12:39 ` [PATCH v2 2/6] console: Implement flush() function Pali Rohár
2022-08-11 14:47   ` Simon Glass
2022-08-11 14:49     ` Pali Rohár
2022-08-12  0:08       ` Simon Glass
2022-08-12  9:01         ` Pali Rohár
2022-08-12 15:11           ` Simon Glass
2022-08-12 15:17             ` Pali Rohár
2022-08-13  2:21               ` Simon Glass
2022-08-25 14:20                 ` Pali Rohár
2022-08-25 15:08                   ` Simon Glass
2022-08-31  9:13                     ` Pali Rohár
2022-08-31 13:46                       ` Simon Glass
2022-08-31 13:55                         ` Tom Rini
2022-08-11 12:39 ` [PATCH v2 3/6] serial: Implement flush callback Pali Rohár
2022-08-11 14:47   ` Simon Glass
2022-08-11 12:39 ` [PATCH v2 4/6] serial: Implement serial_flush() function for console flush() fallback Pali Rohár
2022-08-11 14:47   ` Simon Glass
2022-08-11 12:39 ` Pali Rohár [this message]
2022-08-11 14:47   ` [PATCH v2 5/6] serial: Call flush() before changing baudrate Simon Glass
2022-08-11 14:51     ` Pali Rohár
2022-08-12  0:08       ` Simon Glass
2022-08-12  9:00         ` Pali Rohár
2022-08-11 12:39 ` [PATCH v2 6/6] boot: Call flush() before booting Pali Rohár
2022-08-11 14:47   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220811123925.23981-6-pali@kernel.org \
    --to=pali@kernel.org \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox