From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91B0DC19F2A for ; Thu, 11 Aug 2022 12:40:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AF906848B9; Thu, 11 Aug 2022 14:40:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="a9TonSJo"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7BF858492F; Thu, 11 Aug 2022 14:39:55 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A37688491D for ; Thu, 11 Aug 2022 14:39:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 32D1FB81F2E; Thu, 11 Aug 2022 12:39:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE9E7C43470; Thu, 11 Aug 2022 12:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660221590; bh=mMroyZe6sdFErnhLoS6lA4s4WCCWF/6Y/AFFQpeit3Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a9TonSJoVqnDRsZ33IiTu79JNx75SCD4tsgemou55gbAXjf0sq3x1NKAM9Xee11hv 56Lvo/OXQJfk/zjCLbbL4M3ZiLC7gkf0Qfkws6FkxeB8YTMuC5dJn0/V3VKHJPOxhD Z1c6TImCLKNkRatevNoMsRer/C25yswGrSFb1K4eIcupHzPbcJYEfQFGiwjdMH/JbZ Tuuvd1OMoUsFj6ZYj/KE1Mj9F+NkjfH4FPskrW4lEnaQPaAgSVLzDemKvcC6n+CD9T pF9pFFFdDmu25J0kQY9cjTTvKwaLOE6kZbzBlY799w2yisYqXoB3x3VPlnhLDtU1zY z3f8JFRRQbHpw== Received: by pali.im (Postfix) id 4A97A277F; Thu, 11 Aug 2022 14:39:49 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Simon Glass Cc: u-boot@lists.denx.de Subject: [PATCH v2 5/6] serial: Call flush() before changing baudrate Date: Thu, 11 Aug 2022 14:39:24 +0200 Message-Id: <20220811123925.23981-6-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220811123925.23981-1-pali@kernel.org> References: <20220811123925.23981-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Changing baudrate is sensitive operation. To ensure that U-Boot messages printed before changing baudrate are not lost, call new U-Boot console flush() function. Signed-off-by: Pali Rohár --- cmd/load.c | 5 +++++ drivers/serial/serial-uclass.c | 1 + drivers/serial/serial.c | 1 + 3 files changed, 7 insertions(+) diff --git a/cmd/load.c b/cmd/load.c index e44ae0d56b75..5c4f34781d45 100644 --- a/cmd/load.c +++ b/cmd/load.c @@ -83,6 +83,7 @@ static int do_load_serial(struct cmd_tbl *cmdtp, int flag, int argc, printf("## Switch baudrate to %d bps and press ENTER ...\n", load_baudrate); udelay(50000); + flush(); gd->baudrate = load_baudrate; serial_setbrg(); udelay(50000); @@ -126,6 +127,7 @@ static int do_load_serial(struct cmd_tbl *cmdtp, int flag, int argc, printf("## Switch baudrate to %d bps and press ESC ...\n", current_baudrate); udelay(50000); + flush(); gd->baudrate = current_baudrate; serial_setbrg(); udelay(50000); @@ -317,6 +319,7 @@ int do_save_serial(struct cmd_tbl *cmdtp, int flag, int argc, printf("## Switch baudrate to %d bps and press ESC ...\n", (int)current_baudrate); udelay(50000); + flush(); gd->baudrate = current_baudrate; serial_setbrg(); udelay(50000); @@ -471,6 +474,7 @@ static int do_load_serial_bin(struct cmd_tbl *cmdtp, int flag, int argc, printf("## Switch baudrate to %d bps and press ENTER ...\n", load_baudrate); udelay(50000); + flush(); gd->baudrate = load_baudrate; serial_setbrg(); udelay(50000); @@ -533,6 +537,7 @@ static int do_load_serial_bin(struct cmd_tbl *cmdtp, int flag, int argc, printf("## Switch baudrate to %d bps and press ESC ...\n", current_baudrate); udelay(50000); + flush(); gd->baudrate = current_baudrate; serial_setbrg(); udelay(50000); diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c index 4e32270d4660..0f6860d9100e 100644 --- a/drivers/serial/serial-uclass.c +++ b/drivers/serial/serial-uclass.c @@ -527,6 +527,7 @@ static int on_baudrate(const char *name, const char *value, enum env_op op, printf("## Switch baudrate to %d bps and press ENTER ...\n", baudrate); udelay(50000); + flush(); } gd->baudrate = baudrate; diff --git a/drivers/serial/serial.c b/drivers/serial/serial.c index 6cdbb89841c1..4b525b644928 100644 --- a/drivers/serial/serial.c +++ b/drivers/serial/serial.c @@ -81,6 +81,7 @@ static int on_baudrate(const char *name, const char *value, enum env_op op, printf("## Switch baudrate to %d" " bps and press ENTER ...\n", baudrate); udelay(50000); + flush(); } gd->baudrate = baudrate; -- 2.20.1