From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B5A4C19F2A for ; Thu, 11 Aug 2022 20:28:43 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 13FB284A95; Thu, 11 Aug 2022 22:28:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="kaXydHrl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 741C984A5C; Thu, 11 Aug 2022 22:27:51 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7A71584A69 for ; Thu, 11 Aug 2022 22:27:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5317A6131D for ; Thu, 11 Aug 2022 20:27:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F03FC433D6 for ; Thu, 11 Aug 2022 20:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660249664; bh=IBibWuYr9IGYq/2GPyz4mD7xEz/nwV4W9S7DhWCGXHw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=kaXydHrlZjEejiop7mSyzAMsu8x7iiDqT8Q4DJH78suN9KkyzEb5qX+Vf0k3VR2z+ CPsOJZdU/Rq1MbdJw/Z8/1C3nGTAjap8ZJPGvUB3saCNSHwXToLjZjtVHoyaC/jJcT z3DdfqlNzLdu0rxNciSz+fibsnU9VmVLgn34N7jBKzd82SP+nj9SdYUdwqcif4qv0g hLuNAKhnCoIv1rZEU8bhe3+UavUAfEUIvEHaBjoZ9dRndn0ozSOVH7pyd63E4gINlq zoh6F4ujacioMANEa50xoI0fZQ3vvY52OfvaovoqkQWKgLD/pcLx83hr0H/P5o4eiY U4RjzZ0UE+Ghg== Received: by pali.im (Postfix) id D3CB52765; Thu, 11 Aug 2022 22:27:41 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: u-boot@lists.denx.de Subject: [PATCH 3/5] Nokia RX-51: Simplify copy kernel code Date: Thu, 11 Aug 2022 22:27:23 +0200 Message-Id: <20220811202725.24752-3-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220811202725.24752-1-pali@kernel.org> References: <20220811202725.24752-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Expression (r + (r0 - r1)) produce same result as (r - (r1 - r0)). So it does not matter which one is called. Always call the first option and remove second one. Signed-off-by: Pali Rohár --- board/nokia/rx51/lowlevel_init.S | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/board/nokia/rx51/lowlevel_init.S b/board/nokia/rx51/lowlevel_init.S index dd3c830cc2e2..4f76e80b20f1 100644 --- a/board/nokia/rx51/lowlevel_init.S +++ b/board/nokia/rx51/lowlevel_init.S @@ -55,16 +55,13 @@ save_boot_params: copy_kernel_start: adr r0, relocaddr /* r0 - address of section relocaddr */ ldr r1, relocaddr /* r1 - address of relocaddr after relocation */ - cmp r0, r1 /* r4 - calculated offset */ - subhi r4, r0, r1 - sublo r4, r1, r0 + sub r4, r0, r1 /* r0 - start of kernel before */ ldr r0, startaddr - addhi r0, r0, r4 - sublo r0, r0, r4 + add r0, r0, r4 ldr r1, kernoffs add r0, r0, r1 -- 2.20.1