From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FA47ECAAD4 for ; Fri, 26 Aug 2022 14:54:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F3B2A848E7; Fri, 26 Aug 2022 16:54:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="hAoXsgsx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 78801848E7; Fri, 26 Aug 2022 16:54:05 +0200 (CEST) Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E94C784363 for ; Fri, 26 Aug 2022 16:54:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2f.google.com with SMTP id m17so1233098qvv.7 for ; Fri, 26 Aug 2022 07:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=U8+6wjeNIVDdLjczgZ4AwCPbYghJWg1Q9TGEewzEdog=; b=hAoXsgsxb0ih3sVnLp9RFPwx8JMCK5cxVNTZRjDuqCvfmmlHNGXQFRgU8qfuWNrCjO axctoxYZP/6eMXHSsBN0TTLCKwLAWqpgd+CuFjnc4pOorS4mvJlMBpmpvNsHkY75kHUB RXBElx5a83OZcE0kluSnznUlkemGFq5Bd6qB4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=U8+6wjeNIVDdLjczgZ4AwCPbYghJWg1Q9TGEewzEdog=; b=AculrypDZmDCm67OGUpH8jE/ZtGhL4CeImfwiGikdgAQzCDLkE+FrapYgo2HyrNerl +wqRrV0wR59uciyIqldxRBzIa/LnowjdoPoEvbYXFU7isvOpzbDLZgDQXAR4MDTT8iEy DGWOjz1nr3oc8SlhmOIblIUw+vtE0Yil7XWoBhKdnrH6krPA99QJNe/I6pypdW8ftbs4 t0i5M0j8NwYKwRMjrpEoRxzyl+2DHZWY+sEmVbgK2NfaKgRXstwp5ut9Aq9XT31Nun1G Akco4RavrJ3xKPe/2utpj21Ze522geqo+iShHmcCywIbvmzbUpivu2xBRlHWOndiUR9i qpTQ== X-Gm-Message-State: ACgBeo1BL+DPXGHuRP79WiGMhAYSWdTMYKb92dgd4TxUzIILoSFGwRkY iFj7ISj5y6/T1Wikc2VZ46ejig== X-Google-Smtp-Source: AA6agR4/mRXBmcDBeQv6RibEySDbrTrIp9kvkysJGum9S/1grgXUK0nbPKJYTSJjhOdeT1QuabcxJQ== X-Received: by 2002:a05:6214:230c:b0:497:2fff:91e1 with SMTP id gc12-20020a056214230c00b004972fff91e1mr5808039qvb.30.1661525640659; Fri, 26 Aug 2022 07:54:00 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id u14-20020a05620a430e00b006bb0e5ca4bbsm1879412qko.85.2022.08.26.07.53.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Aug 2022 07:53:59 -0700 (PDT) Date: Fri, 26 Aug 2022 10:53:58 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Marek =?iso-8859-1?Q?Beh=FAn?= , u-boot@lists.denx.de Subject: Re: Broken commit de47ff536363289f92f85ed1e4901724d238432d Message-ID: <20220826145358.GG7942@bill-the-cat> References: <20220805150340.GX1146598@bill-the-cat> <20220805151259.hdftfa3utfiq4i3w@pali> <20220805154400.GA1146598@bill-the-cat> <20220805155135.r5dctspg2oohzdev@pali> <20220805155453.GC1146598@bill-the-cat> <20220805201701.7t37kxn64qaiye3n@pali> <20220805222019.GE1146598@bill-the-cat> <20220808095149.2e0ed3ff@thinkpad> <20220808133722.GM1146598@bill-the-cat> <20220817092908.diwaapf636fxpmuq@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="T7mxYSe680VjQnyC" Content-Disposition: inline In-Reply-To: <20220817092908.diwaapf636fxpmuq@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --T7mxYSe680VjQnyC Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 17, 2022 at 11:29:08AM +0200, Pali Roh=E1r wrote: > On Monday 08 August 2022 09:37:22 Tom Rini wrote: > > On Mon, Aug 08, 2022 at 09:51:49AM +0200, Marek Beh=FAn wrote: > > > On Fri, 5 Aug 2022 18:20:19 -0400 > > > Tom Rini wrote: > > >=20 > > > > On Fri, Aug 05, 2022 at 10:17:01PM +0200, Pali Roh=E1r wrote: > > > > > On Friday 05 August 2022 11:54:53 Tom Rini wrote: =20 > > > > > > On Fri, Aug 05, 2022 at 05:51:35PM +0200, Pali Roh=E1r wrote: = =20 > > > > > > > On Friday 05 August 2022 11:44:00 Tom Rini wrote: =20 > > > > > > > > On Fri, Aug 05, 2022 at 05:12:59PM +0200, Pali Roh=E1r wrot= e: =20 > > > > > > > > > On Friday 05 August 2022 11:03:40 Tom Rini wrote: =20 > > > > > > > > > > On Fri, Aug 05, 2022 at 04:59:35PM +0200, Pali Roh=E1r = wrote: =20 > > > > > > > > > > > On Friday 05 August 2022 10:47:31 Tom Rini wrote: =20 > > > > > > > > > > > > On Fri, Aug 05, 2022 at 04:21:24PM +0200, Pali Roh= =E1r wrote: =20 > > > > > > > > > > > > > On Wednesday 03 August 2022 12:13:18 Tom Rini wro= te: =20 > > > > > > > > > > > > > > On Wed, Aug 03, 2022 at 06:00:13PM +0200, Pali = Roh=E1r wrote: =20 > > > > > > > > > > > > > > > On Tuesday 02 August 2022 06:58:26 Tom Rini w= rote: =20 > > > > > > > > > > > > > > > > On Tue, Aug 02, 2022 at 11:13:38AM +0200, P= ali Roh=E1r wrote: > > > > > > > > > > > > > > > > =20 > > > > > > > > > > > > > > > > > Hello Tom! > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > > Your commit de47ff536363289f92f85ed1e4901= 724d238432d ("Convert > > > > > > > > > > > > > > > > > CONFIG_SYS_MPC85XX_NO_RESETVEC to Kconfig= ") seems to be broken. =20 > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > I thought I had managed to mirror the TPL/S= PL/full usage that was there > > > > > > > > > > > > > > > > prior, but apparently some got missed. =20 > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > Yea, conversion to Kconfig seems that was inc= orrect. =20 > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > As the config files were just unclear, but you = seem to understand what > > > > > > > > > > > > > > it's supposed to be, a patch to clean it up wou= ld be most appreciated, > > > > > > > > > > > > > > thanks. > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > --=20 > > > > > > > > > > > > > > Tom =20 > > > > > > > > > > > > >=20 > > > > > > > > > > > > > Broken is also commit d433c74eecdce1e4952ef4e8c71= 2a9289c0dfcc2. Seems > > > > > > > > > > > > > that all kconfig migration changes done after tha= t commit are broken. > > > > > > > > > > > > >=20 > > > > > > > > > > > > > I really do not have energy to investigate what a= nd how was broken due > > > > > > > > > > > > > to incorrect kconfig migration. > > > > > > > > > > > > >=20 > > > > > > > > > > > > >=20 > > > > > > > > > > > > > I did simple test. Applied following change: > > > > > > > > > > > > >=20 > > > > > > > > > > > > > diff --git a/include/configs/p1_p2_rdb_pc.h b/inc= lude/configs/p1_p2_rdb_pc.h > > > > > > > > > > > > > index a6523753d5ca..489f24df0ab1 100644 > > > > > > > > > > > > > --- a/include/configs/p1_p2_rdb_pc.h > > > > > > > > > > > > > +++ b/include/configs/p1_p2_rdb_pc.h > > > > > > > > > > > > > @@ -624,3 +624,7 @@ __stringify(__PCIE_RST_CMD)"\= 0" > > > > > > > > > > > > > "bootm $norbootaddr - $norfdtaddr" > > > > > > > > > > > > > =20 > > > > > > > > > > > > > #endif /* __CONFIG_H */ > > > > > > > > > > > > > + > > > > > > > > > > > > > +#ifdef CONFIG_SDCARD > > > > > > > > > > > > > +#error > > > > > > > > > > > > > +#endif > > > > > > > > > > > > >=20 > > > > > > > > > > > > > And then called: > > > > > > > > > > > > >=20 > > > > > > > > > > > > > make CROSS_COMPILE=3Dpowerpc-linux-gnuspe- P2020R= DB-PC_defconfig u-boot.bin > > > > > > > > > > > > >=20 > > > > > > > > > > > > > And it failed, even when this defconfig file is n= ot SD card builds. =20 > > > > > > > > > > > >=20 > > > > > > > > > > > > Where is PBL in that case even then? =20 > > > > > > > > > > >=20 > > > > > > > > > > > P2020 (and older) are pre-PBL boards, they do not sup= port NXP PBL > > > > > > > > > > > header. =20 > > > > > > > > > >=20 > > > > > > > > > > Ah, OK, then it should just be removing TARGET_P2020RDB= from the choice > > > > > > > > > > on "Freescale PBL load location". > > > > > > > > > >=20 > > > > > > > > > > --=20 > > > > > > > > > > Tom =20 > > > > > > > > >=20 > > > > > > > > > I just do not understand. > > > > > > > > >=20 > > > > > > > > > P10** and P20** do not support NXP PBL. They support only= pre-PBL and > > > > > > > > > for SD card pre-PBL support I added option FSL_PREPBL_ESD= HC_BOOT_SECTOR. > > > > > > > > >=20 > > > > > > > > > But CONFIG_SDCARD is automatically set when SYS_EXTRA_OPT= IONS contains > > > > > > > > > "SDCARD" string and CONFIG_SDCARD is used then also in P1= 0** and P20** > > > > > > > > > SD-card version of SPL to load proper U-Boot. =20 > > > > > > > >=20 > > > > > > > > So CONFIG_SDCARD was over-loaded? That's very frustrating. = That's what > > > > > > > > needs to be corrected then. =20 > > > > > > >=20 > > > > > > > But it was correct, no? CONFIG_SDCARD ensures that U-Boot is = compiled in > > > > > > > mode in which can be booted from SD card. Or what do you have= in mind as > > > > > > > purpose of this symbol? > > > > > > >=20 > > > > > > > The issue is that your Kconfig migration changes enabled CONF= IG_SDCARD > > > > > > > also when building (parallel) NOR version of U-Boot. =20 > > > > > >=20 > > > > > > To me, the biggest issue is that "CONFIG_SDCARD" exists. It's v= ery much > > > > > > non-descriptive and that for some platforms it means "we have N= XP PBL" > > > > > > and others means "we're booting from SDCARD". The former should= be > > > > > > renamed to be descriptive, and the latter should re-use CONFIG_= SD_CARD > > > > > > which is still a bad name, but what everyone else uses, so makes > > > > > > renaming it later to something less bad easier. =20 > > > > >=20 > > > > > So I hope that you will do something with it. I already spent lot= of > > > > > time to fix and improve powerpc support, but the result is that my > > > > > patches are on the list, mostly ignored; but changes which are br= eaking > > > > > powerpc support are happily merging. In this state I'm loosing any > > > > > motivation to continue development as it is needed to do again to= find > > > > > out what new is broken. =20 > > > >=20 > > > > I'm not planning to try and further fiddle with those symbols. A > > > > simple revert is not possible as CONFIG_SYS_EXTRA_OPTIONS is gone. I > > > > assume that Marek will be picking up your PowerPC patches at this p= oint, > > > > so any further work you're doing in that area shouldn't be delayed. > > > > I'll put re-examining this on my TODO list, but it's below finishin= g my > > > > CONFIG_SYS_* audit, and then renaming stuff to CFG_SYS. > > > >=20 > > > > You should fix whatever platforms you have access to and ignore the > > > > rest, I feel likely to be removing most of them shortly at this poi= nt. > > > >=20 > > >=20 > > > I shall try to fix this on our platform by "reverting" these to > > > different names, so that there are no new CONFIG_ macros. > >=20 > > OK, thanks. I'll "fix" the corenet_ds platforms with a removal patch > > soon, since they've been orphaned for a long while. >=20 > Any progress on fixing this issue? Currently all this stuff is not > working in u-boot master due to broken kconfig migration. And any > continuation in kconfig migration just makes it worse and harder to fix > later. I've removed the corenet_ds platforms now. --=20 Tom --T7mxYSe680VjQnyC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmMI3oMACgkQFHw5/5Y0 tyzdVAv/SJ/a9lJW+z2JHYnqPZjGssA8Klo4owvSj6yKyLgwjH+F0dwlFvyq/bxH /bJwQX7AR/FnUC9CiFaY1cVnT8ONXyOYYJBqjNivp3nGfnTRwEVpvKccwWSrYhuh 4yJNpZO9bmNaJA1uh340V7leH6XBhFclLgIobIAPdKRC3OuWWCobLJ7bJbD3kfNn V4aiWq1iAIeo7Ejcl80GSmqJIm49Iv1HqAj2chxbTmJLSpZ4kav8wkGCrIrEDqKp 93TdovDlvNb5bgfM8qRaeOQW1ChcEGP/1TGATVGJxlGbsdPYzAqssTc7VayNeB2+ kqMfKDFgkkN2b9uLNQ2U6kQ50JHR54V4mfbaKruaSj7Y4aaB4XoVOO4qZjwhmJgD UP8yG83SVt85doefYvHylO68ntkxqxZVj1jhcE8BxiaaoVR7UM2a3EWSyhcMGDur 4lVzI13y/1jRemCyKQMls82EQIvtnatXuHp8grxOcYAO/eoG4RQNp3dA1aVNAdWS mMgNZ8kV =Hul6 -----END PGP SIGNATURE----- --T7mxYSe680VjQnyC--