From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E5A9ECAAA3 for ; Fri, 26 Aug 2022 21:11:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E2457841F5; Fri, 26 Aug 2022 23:11:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="BvQ4oI3w"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EF991841F9; Fri, 26 Aug 2022 23:11:40 +0200 (CEST) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2F63E841CD for ; Fri, 26 Aug 2022 23:11:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2c.google.com with SMTP id l5so1982859qvs.13 for ; Fri, 26 Aug 2022 14:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=TRXYUJ+NT9/N8ozz21U50mxh84gCKs+QfS1Gh3Hb2CU=; b=BvQ4oI3wzdl3NlOB+qHFi0w9+DVH5rwHAJ5U/5XyhPfsmwJObVlLRGQVyB1jfjpFfq +bs9FD1lJYrCXh/edBtI7x5aCFt9slicTXGyFojnPeaar7nNMRqx3ah1LWyyhQG4BaPa FG/PnKdl9+yKiC7Xizw0M9A/7Nkc1J1mnvIYk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=TRXYUJ+NT9/N8ozz21U50mxh84gCKs+QfS1Gh3Hb2CU=; b=GDe4P77fpyg8wsZg4wM8U0JpyKCEM3DK5Mb2kiHLJnEdmlGtBRD1H1Iuej/G/X2IUE qHISkYjlvZesjuHACYeAeij951Z+Xw/ZXNh81DrVRCkJpsMJjOXEgLSsVNgen/GaoWlE BrxJNQ/1Tdl+Tnhax2BiRCDnsmXEmySJuwfc8t9fVje0K3FDivrxvXwhCXnUYKGOeTXJ OqRieq4vAspX71Oa1qOx2rwPuUKkPt1HKLuQRuX5KFKQLfg5VT2Y4Xl3w9CoP+QjGyl6 iFK9/7XzUtT4VY+t3mKe4DdunODjlrB52FooMw68f8zaFTDkYmWzejF8LUkPXcgbjrPz PXyQ== X-Gm-Message-State: ACgBeo3dzzDg+PRiPhzAh0byIHZEFL7awshd/4bzpu1bQvC5YPLQ829y o6w8d/0JEvVYnvOcyKmOT9sodQ== X-Google-Smtp-Source: AA6agR7w+0YJblY/csxRId97sYDy0oapMtFLK7/wkcG7iLMdt3EAyJlGl7JPhfytbPlSeRNqROSyKA== X-Received: by 2002:a0c:9c48:0:b0:473:5e9e:741 with SMTP id w8-20020a0c9c48000000b004735e9e0741mr1250920qve.63.1661548296732; Fri, 26 Aug 2022 14:11:36 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id l29-20020ac84cdd000000b0031ecddf2278sm496859qtv.37.2022.08.26.14.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Aug 2022 14:11:35 -0700 (PDT) Date: Fri, 26 Aug 2022 17:11:33 -0400 From: Tom Rini To: Daniel Golle Cc: u-boot@lists.denx.de, Simon Glass , Alexandru Gagniuc , Chia-Wei Wang , Sean Anderson , Heinrich Schuchardt , Joel Stanley Subject: Re: [PATCH] image-fit: don't set compression if it can't be read Message-ID: <20220826211133.GD7942@bill-the-cat> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="F4Dl6XKrV7PH8SJF" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --F4Dl6XKrV7PH8SJF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 15, 2022 at 12:38:27PM +0200, Daniel Golle wrote: > fit_image_get_comp() should not set value -1 in case it can't read > the compression node. Instead, leave the value untouched in that case > as it can be absent and a default value previously defined by the > caller of fit_image_get_comp() should be used. >=20 > As a result the warning message > WARNING: 'compression' nodes for ramdisks are deprecated, please fix your= .its file! > no longer shows if the compression node is actually absent. >=20 > Signed-off-by: Daniel Golle > Reviewed-by: Simon Glass This causes most platforms to fail to build with an error such as: https://source.denx.de/u-boot/u-boot/-/jobs/486959#L140 --=20 Tom --F4Dl6XKrV7PH8SJF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmMJNv4ACgkQFHw5/5Y0 tyzuWAv+NZLwFtQIGPYRRJrKcQLhU9yo7Sajfp+0flf2ApArSrMna6lep5JwWxb0 2uFc34Mk1ZmMPvdaQuO770JUr6pc/76cevjOPUF3x/xDRwmkIKT5Kf/zi219DyhJ I/d0jnqoHscwpiPKtZzT5z1uG+NEBN9NIqrU725U4V8Vhjb+5MrZ7hkCCO03yt6X EmkIsy094MR8m8gHqynrbtLsW6fpJMEeF6sNHrqOihHKWzltPl65INs/ovPGPBhh b2jvIwj9kX2Oz8PxHz4POV2oCyvMAhQfcShoEoC9OYWx5XwSFIlwqbJBee5bGjNK 049ijSEmmGHRPa9DoEoUQL7puT4aV4VDsAcr1fbL0jjV0nZD4t1iemdW/o17Bfoq 9wx6OhbTIwPBYZQ0FqzihWhSEnnNmkitEgdyua4sc64txNkBizTJwTH4yUaRMBEA lBiTxkOqPB0GmKRX3tscQTT1ileNGCRfTyvVXWHy+b6A7SRwV0xWywYNnsHsrEhp BW+nFGBr =l+RT -----END PGP SIGNATURE----- --F4Dl6XKrV7PH8SJF--