public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Cc: trini@konsulko.com, sjg@chromium.org, rasmus.villemoes@prevas.dk
Subject: [PATCH v1 2/6] cyclic: Introduce schedule() function
Date: Fri,  2 Sep 2022 14:10:45 +0200	[thread overview]
Message-ID: <20220902121049.1282136-3-sr@denx.de> (raw)
In-Reply-To: <20220902121049.1282136-1-sr@denx.de>

This patch introduces a schedule() function, which shall be used instead
of the old WATCHDOG_RESET. Follow-up patches will make sure, that this
new function is used.

Signed-off-by: Stefan Roese <sr@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
v1:
- Add Simon's SoB tag
- Add more comments in the header to fully document the prototypes

 common/cyclic.c  | 11 +++++++++++
 include/cyclic.h | 12 ++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/common/cyclic.c b/common/cyclic.c
index f0bfd18c9242..0b07ede8d35e 100644
--- a/common/cyclic.c
+++ b/common/cyclic.c
@@ -18,6 +18,8 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
+void hw_watchdog_reset(void);
+
 struct list_head *cyclic_get_list()
 {
 	return &gd->cyclic->cyclic_list;
@@ -96,6 +98,15 @@ void cyclic_run(void)
 	gd->cyclic->cyclic_running = false;
 }
 
+void schedule(void)
+{
+	/* The HW watchdog is not integrated into the cyclic IF (yet) */
+	if (IS_ENABLED(CONFIG_HW_WATCHDOG))
+		hw_watchdog_reset();
+
+	cyclic_run();
+}
+
 int cyclic_uninit(void)
 {
 	struct cyclic_info *cyclic, *tmp;
diff --git a/include/cyclic.h b/include/cyclic.h
index 23902234cc87..760163643345 100644
--- a/include/cyclic.h
+++ b/include/cyclic.h
@@ -106,6 +106,14 @@ struct list_head *cyclic_get_list(void);
  * needs to be executed, then call into these registered functions.
  */
 void cyclic_run(void);
+
+/**
+ * schedule() - Schedule all potentially waiting tasks
+ *
+ * Basically a wrapper for cyclic_run(), pontentially enhanced by some
+ * other parts, that need to get handled periodically.
+ */
+void schedule(void);
 #else
 static inline struct cyclic_info *cyclic_register(cyclic_func_t func,
 						  uint64_t delay_us,
@@ -124,6 +132,10 @@ static inline void cyclic_run(void)
 {
 }
 
+static inline void schedule(void)
+{
+}
+
 static inline int cyclic_init(void)
 {
 	return 0;
-- 
2.37.3


  parent reply	other threads:[~2022-09-02 12:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-02 12:10 [PATCH v1 0/6] Migrate watchdog reset to cyclic infrastructure Stefan Roese
2022-09-02 12:10 ` [PATCH v1 1/6] watchdog: Integrate watchdog triggering into the cyclic framework Stefan Roese
2022-09-02 19:59   ` Simon Glass
2022-09-02 12:10 ` Stefan Roese [this message]
2022-09-02 12:10 ` [PATCH v1 3/6] cyclic: Use schedule() instead of WATCHDOG_RESET() Stefan Roese
2022-09-02 12:10 ` [PATCH v1 4/6] watchdog: Get rid of ASSEMBLY hacks Stefan Roese
2022-09-02 12:10 ` [PATCH v1 5/6] watchdog: Remove WATCHDOG_RESET macro Stefan Roese
2022-09-02 12:10 ` [PATCH v1 6/6] watchdog: Further cleanup Stefan Roese
2022-09-16  7:21 ` [PATCH v1 0/6] Migrate watchdog reset to cyclic infrastructure Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220902121049.1282136-3-sr@denx.de \
    --to=sr@denx.de \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox