From: Tom Rini <trini@konsulko.com>
To: Sergei Antonov <saproj@gmail.com>
Cc: u-boot@lists.denx.de, Samuel Holland <samuel@sholland.org>,
Ye Li <ye.li@nxp.com>, Simon Glass <sjg@chromium.org>,
Andre Przywara <andre.przywara@arm.com>,
Marek Vasut <marex@denx.de>,
Sean Anderson <sean.anderson@seco.com>
Subject: Re: [PATCH v2] arm: ARMv4 assembly compatibility
Date: Fri, 2 Sep 2022 21:55:12 -0400 [thread overview]
Message-ID: <20220903015512.GP7942@bill-the-cat> (raw)
In-Reply-To: <20220821133420.418232-1-saproj@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
On Sun, Aug 21, 2022 at 04:34:20PM +0300, Sergei Antonov wrote:
> There is currently a problem that U-Boot can not work on ARMv4
> because assembly imlementations of memcpy() and some other functions
> use "bx lr" instruction that is not available on ARMv4 ("mov pc, lr"
> should be used instead).
>
> A working preprocessor-based solution to this problem is found in
> arch/arm/lib/relocate.S. Move it to the "ret" macro in
> arch/arm/include/asm/assembler.h and change all "bx lr" code
> to "ret lr" in functions that may run on ARMv4. Linux source code
> deals with this problem in the same manner.
>
> v1 -> v2:
> Comment update. Pointed out by Andre Przywara.
>
> Signed-off-by: Sergei Antonov <saproj@gmail.com>
> CC: Samuel Holland <samuel@sholland.org>
> CC: Ye Li <ye.li@nxp.com>
> CC: Simon Glass <sjg@chromium.org>
> CC: Andre Przywara <andre.przywara@arm.com>
> CC: Marek Vasut <marex@denx.de>
> CC: Sean Anderson <sean.anderson@seco.com>
> CC: Tom Rini <trini@konsulko.com>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-09-03 1:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 13:34 [PATCH v2] arm: ARMv4 assembly compatibility Sergei Antonov
2022-09-03 1:55 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220903015512.GP7942@bill-the-cat \
--to=trini@konsulko.com \
--cc=andre.przywara@arm.com \
--cc=marex@denx.de \
--cc=samuel@sholland.org \
--cc=saproj@gmail.com \
--cc=sean.anderson@seco.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox