From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78AEAECAAA1 for ; Sat, 3 Sep 2022 01:55:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5F74884A40; Sat, 3 Sep 2022 03:55:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="rAZ0DiJy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F05DC84A0E; Sat, 3 Sep 2022 03:55:21 +0200 (CEST) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8B83284863 for ; Sat, 3 Sep 2022 03:55:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x734.google.com with SMTP id m5so3068008qkk.1 for ; Fri, 02 Sep 2022 18:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=xmm7n36SKfoyXHHQ9VRfbV7UAGn6Ay95Wq94bgcRXs0=; b=rAZ0DiJyJhwXwIYnx+cVtaMKv2g3l8byHub9C64FmrPLVH/2VCKJPPFcMryMqDJHOM 9l6DSWTM9XbOLzzDz68XHBoTz9sWvPbS5dlYZXqw94NITL/2KXqdNTzF2c31yoqhOlXE tAMrg/n4CTP/mPY0MwtO/PYp8CyrO2o67MzDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=xmm7n36SKfoyXHHQ9VRfbV7UAGn6Ay95Wq94bgcRXs0=; b=lKxYXd/M5fadtgi4/bUEmf+TQKXgVsbcH3WfRbol2TnyO6b57JupcU8jPZSef+4wgL V7qMSJN24X9o9xBT/x9wrmBJw1mKrl5fClhaNVK0r2ILF6zO0xc9FtHiaoJLeLFmOTJ7 ItSPxcg9UkQWcATba51P7FN1n06g3OFBVZHCAhnYQUlghfkimiuB1kKsxK5vwbP8bWtF u0kc7i6ZOGox5PPvlF3sWLjkbcpwHSnRLS8oEyGK0UGQkpoEPjy3Kfg1iUtuS7ygSy7z 7XRD+iyD4epertJnC6+el/fCO1stmEi15xav+so0ghNjrCn0YvN01I8i+OE2omJt9jHC 2Ifg== X-Gm-Message-State: ACgBeo3y4lACiqS/25BWkrgSJtLZOxCtTu7TMxGxwyfPCvYHTzPFfC38 IrSUCCY2467Bhox3iKO2A737YROmfW+Zlw== X-Google-Smtp-Source: AA6agR4oRTo9YGoe04V5woawTwoCZSdH5dsPF3WNFz+U24SWS47z0trChFhQWSpPoATpVvopYdr94w== X-Received: by 2002:a05:620a:2a12:b0:6bb:b3af:780e with SMTP id o18-20020a05620a2a1200b006bbb3af780emr25314551qkp.460.1662170115398; Fri, 02 Sep 2022 18:55:15 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id w17-20020a05620a445100b006b8fb2a1145sm2780391qkp.124.2022.09.02.18.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Sep 2022 18:55:14 -0700 (PDT) Date: Fri, 2 Sep 2022 21:55:12 -0400 From: Tom Rini To: Sergei Antonov Cc: u-boot@lists.denx.de, Samuel Holland , Ye Li , Simon Glass , Andre Przywara , Marek Vasut , Sean Anderson Subject: Re: [PATCH v2] arm: ARMv4 assembly compatibility Message-ID: <20220903015512.GP7942@bill-the-cat> References: <20220821133420.418232-1-saproj@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bE5y7bXmg3Z2om3p" Content-Disposition: inline In-Reply-To: <20220821133420.418232-1-saproj@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --bE5y7bXmg3Z2om3p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 21, 2022 at 04:34:20PM +0300, Sergei Antonov wrote: > There is currently a problem that U-Boot can not work on ARMv4 > because assembly imlementations of memcpy() and some other functions > use "bx lr" instruction that is not available on ARMv4 ("mov pc, lr" > should be used instead). >=20 > A working preprocessor-based solution to this problem is found in > arch/arm/lib/relocate.S. Move it to the "ret" macro in > arch/arm/include/asm/assembler.h and change all "bx lr" code > to "ret lr" in functions that may run on ARMv4. Linux source code > deals with this problem in the same manner. >=20 > v1 -> v2: > Comment update. Pointed out by Andre Przywara. >=20 > Signed-off-by: Sergei Antonov > CC: Samuel Holland > CC: Ye Li > CC: Simon Glass > CC: Andre Przywara > CC: Marek Vasut > CC: Sean Anderson > CC: Tom Rini Applied to u-boot/next, thanks! --=20 Tom --bE5y7bXmg3Z2om3p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmMStAAACgkQFHw5/5Y0 tyy3vgwAoWdXkuJJpeXb1oUZisO48xMv1QEQkA9khLEw45Sgymfrn3pLdPgUjCeF 5N/JQQ6uHny1D0eoFMRvTaJZOWZG+lRdsP9rt5Bu9uHox36z7w//Xq6HBlGk6vAb KYYvuGdKWbL9wjGg97Otj6WhELcwb0SgIWCSTd2lrHg65wBx60PakESwJz3VAABq RIyWqR8hr2IsPIVXtiSMbmszHvf8VVlmu4R2oPK0Y3H66AnsMaAyOenQhnpaNf55 3DZUmUTqMz8NirfxKcpwzqvQLAI4IezczjX8Qc+BvFhExJwy6NeBcoQNTfUTo0KD 7NQUbXMiXIVWpEu9OsV2RIcmtS//c7UZVZiU2ScmqWRZQnhNXkjmsysBcPiaTbOb BbSC8h52DQVvzBQYs6+KFkvTxrOVDBKbE3pcsK18wtcxZnPCqO4XS6hDVzgsPG1B tderjPrEawE5z7DcMVFpIsBEj8uf/ADOk3A8fwgEwGRqaq6KQXEDGUhQPnS8NOW8 s609AB9o =ahrU -----END PGP SIGNATURE----- --bE5y7bXmg3Z2om3p--