* [PATCH] tools: termios_linux.h: Fix compilation on non-glibc systems
@ 2022-09-08 14:59 Pali Rohár
0 siblings, 0 replies; only message in thread
From: Pali Rohár @ 2022-09-08 14:59 UTC (permalink / raw)
To: Stefan Roese; +Cc: Marek Behún, Michal Vasilek
TCGETS2 is defined in header file asm/ioctls.h provided by linux kernel.
On glib systems it is automatically included by some other glibc include
header file and therefore TCGETS2 is present in termios_linux.h when
linux kernel provides it.
On non-glibc systems (e.g. musl) asm/ioctls.h is not automatically included
which results in the strange error that BOTHER is supported, TCGETS2 not
defined and struct termios does not provide c_ispeed member.
tools/kwboot.c: In function 'kwboot_tty_change_baudrate':
tools/kwboot.c:662:6: error: 'struct termios' has no member named 'c_ospeed'
662 | tio.c_ospeed = tio.c_ispeed = baudrate;
| ^
Fix this issue by explicitly including asm/ioctls.h file which provides
TCGETS2 macro (if supported on selected architecture) to not depending on
glibc auto-include behavior and because termios_linux.h requires it.
With this change it is possible compile kwboot with musl libc.
Reported-by: Michal Vasilek <michal.vasilek@nic.cz>
Signed-off-by: Pali Rohár <pali@kernel.org>
---
Stefan, could you include this patch into -rc queue so kwboot can be
compiled also with musl libc?
---
tools/termios_linux.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/termios_linux.h b/tools/termios_linux.h
index 45f5c1233c01..0806a91180a0 100644
--- a/tools/termios_linux.h
+++ b/tools/termios_linux.h
@@ -29,6 +29,7 @@
#include <errno.h>
#include <sys/ioctl.h>
#include <sys/types.h>
+#include <asm/ioctls.h>
#include <asm/termbits.h>
#if defined(BOTHER) && defined(TCGETS2)
--
2.20.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-09-08 18:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-08 14:59 [PATCH] tools: termios_linux.h: Fix compilation on non-glibc systems Pali Rohár
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox