public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: u-boot@lists.denx.de
Subject: [PATCH] display_options: print_size: Fix order overflow
Date: Sun, 11 Sep 2022 11:37:07 +0200	[thread overview]
Message-ID: <20220911093707.9434-1-pali@kernel.org> (raw)

Function print_size() round size to the nearst value with one decimal
fraction number. But in special cases also unit order may overflow.

For example value 1073689396 is printed as "1024 MiB" and value 1073741824
as "1 GiB".

Fix this issue by detecting order overflow and increasing unit order.
With this change also value 1073689396 is printed as "1 GiB".

Signed-off-by: Pali Rohár <pali@kernel.org>
---
 lib/display_options.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lib/display_options.c b/lib/display_options.c
index 360b01bcf5ff..c281c1d2c10d 100644
--- a/lib/display_options.c
+++ b/lib/display_options.c
@@ -126,6 +126,12 @@ void print_size(uint64_t size, const char *s)
 		if (m >= 10) {
 			m -= 10;
 			n += 1;
+
+			if (n == 1024 && i > 0) {
+				n = 1;
+				m = 0;
+				c = names[i - 1];
+			}
 		}
 	}
 
-- 
2.20.1


             reply	other threads:[~2022-09-11  9:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-11  9:37 Pali Rohár [this message]
2022-09-12 13:34 ` [PATCH] display_options: print_size: Fix order overflow Simon Glass
2022-09-12 18:56   ` Pali Rohár
2022-09-12 19:02 ` [PATCH v2] " Pali Rohár
2022-09-14 17:10   ` Simon Glass
2022-09-23 22:48   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220911093707.9434-1-pali@kernel.org \
    --to=pali@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox