From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D610EC6FA82 for ; Tue, 13 Sep 2022 09:29:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 540E784601; Tue, 13 Sep 2022 11:29:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YT1D5yaW"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 74CAE84A34; Tue, 13 Sep 2022 11:29:33 +0200 (CEST) Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E6D5884601 for ; Tue, 13 Sep 2022 11:29:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=puhitaku@gmail.com Received: by mail-pj1-x102b.google.com with SMTP id i15-20020a17090a4b8f00b0020073b4ac27so10758654pjh.3 for ; Tue, 13 Sep 2022 02:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date; bh=pxkrJ+8G4j2idp0ZPbjC7HapHq+bZdy6gxzE1dJEeCM=; b=YT1D5yaWY/slfEhm7DXiRKZx6jFfnsiWZ6+hku7Er0bu3LpaWGjRu75gWyEmu3VS9R 0mLwGUC0YzKix3v6HgEJ3oophF94nTYNH8WrOwYwMX6EHNKcXf540TkoT5Luz+hRV9wC /LMql3W5sL6gNGL4smcDvr2BLk6z+3lz8xsr37y2wxx1bx5YO7l9WhMI4qq4h80uLee9 /wi0VjoWhmVLjv7lZQJeKrPIdtuk5atJvHiQHN6zWxaCSRdsG5Qf40cf54nwHysx3dBw h3fYhiq6xIqh3kJUFodpWIoEnsNI6SkCLt1QTBG9ub8hQF7rGeqUIST8g4ps8+gf/nuI zbBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=pxkrJ+8G4j2idp0ZPbjC7HapHq+bZdy6gxzE1dJEeCM=; b=eCfVDp1LPw8I4MhFzbzyc7vDX2D5ewi1yXQ4WLQVd0tpMEMml+wzQ7X7eDUvQIyhU6 C2x50xMXos3gnfANl9MWIajgqRqL0ySh9VYoQZfrKX5ueWaHqrDOVMpDsj3+yiSI8RtN wk0rR6UyQpuzuBD03Eka4DXlZ0fkhNN10D7x+40176yHpAO8B5ZaVWL/W5l35zbJjg45 a7n3x7RUVa4eBEXZOBVUIuhuRRvtQHwOvaiSrQQtP0JB612Of61dI9fkdz/fyTWPowLa CJnQRbZxI13u1VNn3vF1g0Hn5uWYaKu+vyLbcS7IYdFcamOFa/rGFIExSmr9nJk+d3YM 3TTA== X-Gm-Message-State: ACgBeo1XHMolvHiXJdT9HFZ0yerckeAr0gXz3/MzpzNsUjyFUtF1rl1y k8p4bVaIXg9ifVEl1atOpEdIWkpyaV0= X-Google-Smtp-Source: AA6agR7G85TBmFPzXkcZK2YyYB8Ab/OZIyNGZLqWgTiB7/BfC2uAAAji6Oxy1lwhMql6VA0Q29D3Gw== X-Received: by 2002:a17:903:110e:b0:171:3114:7112 with SMTP id n14-20020a170903110e00b0017131147112mr31779877plh.114.1663061356915; Tue, 13 Sep 2022 02:29:16 -0700 (PDT) Received: from caret (p83d5ae91.tokynt01.ap.so-net.ne.jp. [131.213.174.145]) by smtp.gmail.com with ESMTPSA id iw11-20020a170903044b00b0016f196209c9sm7758209plb.123.2022.09.13.02.29.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Sep 2022 02:29:16 -0700 (PDT) Date: Tue, 13 Sep 2022 18:29:13 +0900 From: Takumi Sueda To: u-boot@lists.denx.de Cc: agust@denx.de, sjg@chromium.org Subject: Re: [PATCH v2 1/1] video: simplefb: Add rotation support Message-ID: <20220913092913.GA13746@caret> References: <20220913092110.13606-1-puhitaku@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220913092110.13606-1-puhitaku@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, Sep 13, 2022 at 06:21:10PM +0900, Takumi Sueda wrote: > Signed-off-by: Takumi Sueda > --- > drivers/video/simplefb.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c > index 2b0d8835e3..235ec761f7 100644 > --- a/drivers/video/simplefb.c > +++ b/drivers/video/simplefb.c > @@ -43,7 +43,11 @@ static int simple_video_probe(struct udevice *dev) > > uc_priv->xsize = fdtdec_get_uint(blob, node, "width", 0); > uc_priv->ysize = fdtdec_get_uint(blob, node, "height", 0); > - uc_priv->rot = 0; > + uc_priv->rot = fdtdec_get_uint(blob, node, "rot", 0); > + if (uc_priv->rot > 3) { > + log_debug("%s: invalid rot\n", __func__); > + return log_msg_ret("rot", -EINVAL); > + } > > format = fdt_getprop(blob, node, "format", NULL); > debug("%s: %dx%d@%s\n", __func__, uc_priv->xsize, uc_priv->ysize, format); > -- > 2.20.1 > Uh oh, I forgot to add the description. I'll send the v3. Sorry for sending an incomplete patch. Takumi