From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6128C54EE9 for ; Tue, 13 Sep 2022 16:11:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 68FFB84A9C; Tue, 13 Sep 2022 18:11:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="uTcYgjjX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D096284ADF; Tue, 13 Sep 2022 18:11:44 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BEE6B84A9C for ; Tue, 13 Sep 2022 18:11:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 765ECB80EFD; Tue, 13 Sep 2022 16:11:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62DA6C433C1; Tue, 13 Sep 2022 16:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663085501; bh=Q9z+HPQJR1DjCOkkTfZQVMk6XCVr0esvYQuIcCVdl6Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uTcYgjjXsQY8twHWbTkHJO0BvKFzYtf1I3cPQgCPgGC0UDRGf+piyyiSN+hC78BlB Ovj/Rx5ebuz9HR/osT/93peAm0UFpNTffaVGfCAW3O0FjdCTedW8SgZ1UrNYTbKrSb a180E0xjmyoYkP/ieZCZ3PlJ6ea93AtaXscSwdotlSogvMS5BKi34zOvsPsQU1l8Ws AVGcumZMQhw97haImBXs0xNHQm8kYXkIRIg1/clP+d18Sh/dAqOJ1gHs/rEuf0Daiq Fsc8Qal3QenIowbyZejpEsKe6sfuZtNsaghCHFaPnjRAl6JabO4lM2XtvF41BZCDsN JtUEhoJO3AbeA== Date: Tue, 13 Sep 2022 18:11:37 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Stefan Roese Cc: pali@kernel.org, U-Boot Mailing List Subject: Re: [PATCH u-boot-marvell] arm: mvebu: turris_omnia: Fix setting switch CONFIG pins on new board design Message-ID: <20220913181137.54c55e1f@dellmb> In-Reply-To: <20220913161028.3785-1-kabel@kernel.org> References: <20220913161028.3785-1-kabel@kernel.org> X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, 13 Sep 2022 18:10:28 +0200 Marek Beh=C3=BAn wrote: > It seems that waiting only 10 ms after releasing LAN switch from reset > is not enough for the strapping pins to latch the requested values. > P6_MODE[0] is latched to 0 instead of 1. >=20 > Increasing the delay to 50 ms fixes this issue. >=20 > Signed-off-by: Marek Beh=C3=BAn > --- > board/CZ.NIC/turris_omnia/turris_omnia.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turr= is_omnia/turris_omnia.c > index a7f96e5b77..19c5043fcb 100644 > --- a/board/CZ.NIC/turris_omnia/turris_omnia.c > +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c > @@ -654,7 +654,7 @@ static void initialize_switch(void) > ctrl[1] =3D EXT_CTL_nRES_LAN; > err =3D omnia_mcu_write(CMD_EXT_CONTROL, ctrl, sizeof(ctrl)); > =20 > - mdelay(10); > + mdelay(50); > =20 > /* Change RGMII pins back to RGMII mode */ > =20 I forgot to add Fixes: 1da53ae26afc ("arm: mvebu: turris_omnia: Add support for design with= SW reset signals")