Re: [PATCH u-boot-marvell] arm: mvebu: turris_omnia: Fix setting switch CONFIG pins on new board design

Stefan Roese
2022-09-18T10:49:20Z

On 13.09.22 18:10, Marek Behún wrote:
> It seems that waiting only 10 ms after releasing LAN switch from reset
> is not enough for the strapping pins to latch the requested values.
> P6_MODE[0] is latched to 0 instead of 1.
>
> Increasing the delay to 50 ms fixes this issue.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>

Applied to u-boot-marvell/master

Thanks,
Stefan

> ---
> board/CZ.NIC/turris_omnia/turris_omnia.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
> index a7f96e5b77..19c5043fcb 100644
> --- a/board/CZ.NIC/turris_omnia/turris_omnia.c
> +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
> @@ -654,7 +654,7 @@ static void initialize_switch(void)
> ctrl[1] = EXT_CTL_nRES_LAN;
> err = omnia_mcu_write(CMD_EXT_CONTROL, ctrl, sizeof(ctrl));
>
> - mdelay(10);
> + mdelay(50);
>
> /* Change RGMII pins back to RGMII mode */
>

Viele Grüße,
Stefan Roese

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de