* [PATCH] arm: mvebu: turris_omnia: Add CONFIG_BOARD_SIZE_LIMIT
@ 2022-09-14 13:06 Pali Rohár
2022-09-16 16:02 ` Marek Behún
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Pali Rohár @ 2022-09-14 13:06 UTC (permalink / raw)
To: Stefan Roese, Marek Behún; +Cc: u-boot
Maximal size of u-boot kwb image binary is $CONFIG_ENV_OFFSET which is
0xF0000 = 983040 bytes. So add missing CONFIG_BOARD_SIZE_LIMIT definition
to ensure that u-boot binary does not overflow to the u-boot env storage.
Signed-off-by: Pali Rohár <pali@kernel.org>
---
configs/turris_omnia_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
index ba635feb44b2..6698f2313550 100644
--- a/configs/turris_omnia_defconfig
+++ b/configs/turris_omnia_defconfig
@@ -28,6 +28,8 @@ CONFIG_SYS_MEMTEST_END=0x00ffffff
CONFIG_DISTRO_DEFAULTS=y
CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xff0000
+CONFIG_HAS_BOARD_SIZE_LIMIT=y
+CONFIG_BOARD_SIZE_LIMIT=983040
CONFIG_FIT=y
CONFIG_FIT_VERBOSE=y
CONFIG_OF_BOARD_SETUP=y
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: mvebu: turris_omnia: Add CONFIG_BOARD_SIZE_LIMIT
2022-09-14 13:06 [PATCH] arm: mvebu: turris_omnia: Add CONFIG_BOARD_SIZE_LIMIT Pali Rohár
@ 2022-09-16 16:02 ` Marek Behún
2022-09-19 7:02 ` Stefan Roese
2022-09-20 6:56 ` Stefan Roese
2 siblings, 0 replies; 4+ messages in thread
From: Marek Behún @ 2022-09-16 16:02 UTC (permalink / raw)
To: Pali Rohár; +Cc: Stefan Roese, u-boot
On Wed, 14 Sep 2022 15:06:46 +0200
Pali Rohár <pali@kernel.org> wrote:
> Maximal size of u-boot kwb image binary is $CONFIG_ENV_OFFSET which is
> 0xF0000 = 983040 bytes. So add missing CONFIG_BOARD_SIZE_LIMIT definition
> to ensure that u-boot binary does not overflow to the u-boot env storage.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> configs/turris_omnia_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
> index ba635feb44b2..6698f2313550 100644
> --- a/configs/turris_omnia_defconfig
> +++ b/configs/turris_omnia_defconfig
> @@ -28,6 +28,8 @@ CONFIG_SYS_MEMTEST_END=0x00ffffff
> CONFIG_DISTRO_DEFAULTS=y
> CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xff0000
> +CONFIG_HAS_BOARD_SIZE_LIMIT=y
> +CONFIG_BOARD_SIZE_LIMIT=983040
> CONFIG_FIT=y
> CONFIG_FIT_VERBOSE=y
> CONFIG_OF_BOARD_SETUP=y
Reviewed-by: Marek Behún <kabel@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: mvebu: turris_omnia: Add CONFIG_BOARD_SIZE_LIMIT
2022-09-14 13:06 [PATCH] arm: mvebu: turris_omnia: Add CONFIG_BOARD_SIZE_LIMIT Pali Rohár
2022-09-16 16:02 ` Marek Behún
@ 2022-09-19 7:02 ` Stefan Roese
2022-09-20 6:56 ` Stefan Roese
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2022-09-19 7:02 UTC (permalink / raw)
To: Pali Rohár, Marek Behún; +Cc: u-boot
On 14.09.22 15:06, Pali Rohár wrote:
> Maximal size of u-boot kwb image binary is $CONFIG_ENV_OFFSET which is
> 0xF0000 = 983040 bytes. So add missing CONFIG_BOARD_SIZE_LIMIT definition
> to ensure that u-boot binary does not overflow to the u-boot env storage.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> configs/turris_omnia_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
> index ba635feb44b2..6698f2313550 100644
> --- a/configs/turris_omnia_defconfig
> +++ b/configs/turris_omnia_defconfig
> @@ -28,6 +28,8 @@ CONFIG_SYS_MEMTEST_END=0x00ffffff
> CONFIG_DISTRO_DEFAULTS=y
> CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xff0000
> +CONFIG_HAS_BOARD_SIZE_LIMIT=y
> +CONFIG_BOARD_SIZE_LIMIT=983040
> CONFIG_FIT=y
> CONFIG_FIT_VERBOSE=y
> CONFIG_OF_BOARD_SETUP=y
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: mvebu: turris_omnia: Add CONFIG_BOARD_SIZE_LIMIT
2022-09-14 13:06 [PATCH] arm: mvebu: turris_omnia: Add CONFIG_BOARD_SIZE_LIMIT Pali Rohár
2022-09-16 16:02 ` Marek Behún
2022-09-19 7:02 ` Stefan Roese
@ 2022-09-20 6:56 ` Stefan Roese
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2022-09-20 6:56 UTC (permalink / raw)
To: Pali Rohár, Marek Behún; +Cc: u-boot
On 14.09.22 15:06, Pali Rohár wrote:
> Maximal size of u-boot kwb image binary is $CONFIG_ENV_OFFSET which is
> 0xF0000 = 983040 bytes. So add missing CONFIG_BOARD_SIZE_LIMIT definition
> to ensure that u-boot binary does not overflow to the u-boot env storage.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Applied to u-boot-marvell/next
Thanks,
Stefan
> ---
> configs/turris_omnia_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
> index ba635feb44b2..6698f2313550 100644
> --- a/configs/turris_omnia_defconfig
> +++ b/configs/turris_omnia_defconfig
> @@ -28,6 +28,8 @@ CONFIG_SYS_MEMTEST_END=0x00ffffff
> CONFIG_DISTRO_DEFAULTS=y
> CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xff0000
> +CONFIG_HAS_BOARD_SIZE_LIMIT=y
> +CONFIG_BOARD_SIZE_LIMIT=983040
> CONFIG_FIT=y
> CONFIG_FIT_VERBOSE=y
> CONFIG_OF_BOARD_SETUP=y
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-20 6:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-14 13:06 [PATCH] arm: mvebu: turris_omnia: Add CONFIG_BOARD_SIZE_LIMIT Pali Rohár
2022-09-16 16:02 ` Marek Behún
2022-09-19 7:02 ` Stefan Roese
2022-09-20 6:56 ` Stefan Roese
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox