Re: [PATCH] tools: kwbimage: Verify maximal kwbimage header size

Stefan Roese
2022-09-19T07:05:45Z

On 18.09.22 18:39, Pali Rohár wrote:
> BootROM loads kwbimage header to L2-SRAM and BootROM reserve only 192 kB for it.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
> tools/kwbimage.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/kwbimage.c b/tools/kwbimage.c
> index 94b768539222..6abb9f2d5c01 100644
> --- a/tools/kwbimage.c
> +++ b/tools/kwbimage.c
> @@ -1969,6 +1969,9 @@ static int kwbimage_verify_header(unsigned char *ptr, int image_size,
> uint32_t size;
> uint8_t csum;
>
> + if (header_size > 192*1024)
> + return -FDT_ERR_BADSTRUCTURE;
> +
> if (header_size > image_size)
> return -FDT_ERR_BADSTRUCTURE;
>

Viele Grüße,
Stefan Roese

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de