public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Marek Behún" <kabel@kernel.org>
To: "Tom Rini" <trini@konsulko.com>, "Pali Rohár" <pali@kernel.org>
Cc: "U-Boot Mailing List" <u-boot@lists.denx.de>,
	"Marek Behún" <kabel@kernel.org>
Subject: [PATCH] powerpc: mpc85xx: Fix incorrect application of patch
Date: Mon, 19 Sep 2022 11:32:08 +0200	[thread overview]
Message-ID: <20220919093208.13558-1-kabel@kernel.org> (raw)
In-Reply-To: <20220919075341.bdb6523ciy3eqtqw@pali>

I messed up application of patch 5a428e751044 ("mmc: fsl_esdhc_spl: Add
support for builds without CONFIG_SYS_MMC_U_BOOT_OFFS"). I took it from
a work-in-progress branch where I changed usage of
  CONFIG_SDCARD to CONFIG_SD_BOOT
and refactored
  SYS_MPC85XX_NO_RESETVEC
mess.

But these changes aren't in master yet. Fix the wrong usage of these
macros.

Fixes: 5a428e751044 ("mmc: fsl_esdhc_spl: Add support for builds without CONFIG_SYS_MMC_U_BOOT_OFFS")
Signed-off-by: Marek Behún <kabel@kernel.org>
---
Tom, should I send another PR with this fix or do you want to apply
it yourself?

BTW sorry about this. It wasn't caught by CI and I wanted to send at
least the fixes to master ASAP. I now looked again together with Pali
at the rest of the patches and they are fine.
---
 arch/powerpc/cpu/mpc85xx/u-boot-spl.lds | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/cpu/mpc85xx/u-boot-spl.lds b/arch/powerpc/cpu/mpc85xx/u-boot-spl.lds
index a36aa1793d..f28826c5d1 100644
--- a/arch/powerpc/cpu/mpc85xx/u-boot-spl.lds
+++ b/arch/powerpc/cpu/mpc85xx/u-boot-spl.lds
@@ -63,8 +63,8 @@ SECTIONS
 	__init_end = .;
 	_end = .;
 
-#ifndef KEEP_RESET_VECTOR
-#if defined(CONFIG_SD_BOOT) && !defined(CONFIG_SYS_MMC_U_BOOT_OFFS)
+#if CONFIG_IS_ENABLED(SYS_MPC85XX_NO_RESETVEC)
+#if defined(CONFIG_SDCARD) && !defined(CONFIG_SYS_MMC_U_BOOT_OFFS)
 	mmc_u_boot_offs = .;
 #endif
 #endif
@@ -101,7 +101,7 @@ SECTIONS
 	.resetvec IMAGE_TEXT_BASE + RESET_VECTOR_OFFSET : {
 		KEEP(*(.resetvec))
 	} = 0xffff
-#if defined(CONFIG_SD_BOOT) && !defined(CONFIG_SYS_MMC_U_BOOT_OFFS)
+#if defined(CONFIG_SDCARD) && !defined(CONFIG_SYS_MMC_U_BOOT_OFFS)
 	mmc_u_boot_offs = .;
 #endif
 #endif
-- 
2.35.1


  reply	other threads:[~2022-09-19  9:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-18 13:38 [GIT PULL] mpc85xx changes for v2022.10-rc5 Marek Behún
2022-09-18 19:12 ` Tom Rini
2022-09-19  7:53 ` Pali Rohár
2022-09-19  9:32   ` Marek Behún [this message]
2022-09-19  9:33     ` [PATCH] powerpc: mpc85xx: Fix incorrect application of patch Pali Rohár
2022-09-19 12:31     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220919093208.13558-1-kabel@kernel.org \
    --to=kabel@kernel.org \
    --cc=pali@kernel.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox