public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Janne Grunau <j@jannau.net>
To: Lukasz Majewski <lukma@denx.de>, u-boot@lists.denx.de
Cc: AKASHI Takahiro <takahiro.akashi@linaro.org>,
	Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH v2 1/1] usb: storage: continue probe on "Invalid device"
Date: Mon, 26 Sep 2022 07:07:09 +0200	[thread overview]
Message-ID: <20220926050709.GI4024@jannau.net> (raw)
In-Reply-To: <20220810195422.4334-1-j@jannau.net>

On 2022-08-10 21:54:22 +0200, Janne Grunau wrote:
> Fixes a crash during probing of sd card readers without medium present.
> 
> Link: https://github.com/AsahiLinux/linux/issues/44
> Link: https://lists.denx.de/pipermail/u-boot/2022-July/489717.html
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
> Changes since v1:
>  - changed unconditiona return to "continue" as proposed by AKASHI Takahiro
> 
>  common/usb_storage.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/common/usb_storage.c b/common/usb_storage.c
> index eaa31374ef73..f9204552a683 100644
> --- a/common/usb_storage.c
> +++ b/common/usb_storage.c
> @@ -239,6 +239,7 @@ static int usb_stor_probe_device(struct usb_device *udev)
>  			ret = device_unbind(dev);
>  			if (ret)
>  				return ret;
> +			continue;
>  		}
>  
>  		ret = blk_probe_or_unbind(dev);

ping. Is there anything holding up merging this fix?

Thanks,
Janne

  parent reply	other threads:[~2022-09-26  5:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-10 19:54 [PATCH v2 1/1] usb: storage: continue probe on "Invalid device" Janne Grunau
2022-08-10 21:33 ` Simon Glass
2022-09-26  5:07 ` Janne Grunau [this message]
2022-09-28 10:20   ` Simon Glass
2022-11-03 21:36     ` Janne Grunau
2022-11-03 22:23       ` Marek Vasut
2022-11-03 22:38         ` Marek Vasut
2022-11-04  7:35         ` Janne Grunau
2022-11-04 11:29           ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220926050709.GI4024@jannau.net \
    --to=j@jannau.net \
    --cc=lukma@denx.de \
    --cc=sjg@chromium.org \
    --cc=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox