From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D688AC433FE for ; Thu, 29 Sep 2022 15:05:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2EDA084967; Thu, 29 Sep 2022 17:05:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Wbq+qQXh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3BAA9849AA; Thu, 29 Sep 2022 17:05:47 +0200 (CEST) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 64EC984964 for ; Thu, 29 Sep 2022 17:05:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf31.google.com with SMTP id de14so955096qvb.5 for ; Thu, 29 Sep 2022 08:05:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=2LikXEOTBLfKHRG2NMC+C1Yk3MHrEb2vKpSUNWoa5Fg=; b=Wbq+qQXhCboELv0Lb4bVLxo79CJ+p6pGLjhUeyUTdvST7IXp+gKS3ASZRG9GCefTm8 Hk7E5J4RvFtxKxN/qkcz+cTj+dBOb22E4HocDkQYMxvdkjayLDBx5+JT3oPa6VUIEimk JAQAEoXKC4d4+e6n+kuDPgSOmCexNXudF4Qa8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=2LikXEOTBLfKHRG2NMC+C1Yk3MHrEb2vKpSUNWoa5Fg=; b=DFXRW+AkKTO4DbnITEVG5edFsyZ95KVl+nuWAch0u8pxcViDuLEAXceZ5hT08sxiDh qFJmJkfX4Kueo4uBuTzDy4ROa6Jk/E37Gne+w/DP3mtTzHcFobvVJckGxUpFIkJCkKSg Xkon2v4oqWav7R71+AmLFLyCsSxN2dpung2oQaJUk0nsCjxWdSccYWnwt55sx90OG0Py 9IVVPJJ2a0tMFpCywJUFmuWiwRp9uHBaG3lX775ndk8m6YZ9Qi+zXjTm55c20OHh7HnP Y6tCLq04YETeF7xfsVF/oThHpmxsM8NJS4nVRDOfIsb5HN7zDBCMCC2mQTjxNlb8pKr2 WO8A== X-Gm-Message-State: ACrzQf3jmVvk9xpUPJ+fmlpqjlUW8UHmgj0tmFeaWL5c2gfOD+tibAFr +WQsUUZUN0usiq83HoBwWskbKw== X-Google-Smtp-Source: AMsMyM5eN4Y9cA0k3ooh7q8UlhxEr2LiGEDNr+fzVgwNb9UWc27gaoeHqvQHNCmMqZuO/kpxb4pKxw== X-Received: by 2002:a05:6214:f6b:b0:4af:9f31:49c8 with SMTP id iy11-20020a0562140f6b00b004af9f3149c8mr2890467qvb.84.1664463943089; Thu, 29 Sep 2022 08:05:43 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-0186-ea3a-a82b-3964.res6.spectrum.com. [2603:6081:7b00:6400:186:ea3a:a82b:3964]) by smtp.gmail.com with ESMTPSA id d11-20020a05620a240b00b006be8713f742sm6551826qkn.38.2022.09.29.08.05.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 08:05:42 -0700 (PDT) Date: Thu, 29 Sep 2022 11:05:40 -0400 From: Tom Rini To: Simon Glass Cc: Heinrich Schuchardt , AKASHI Takahiro , Huang Jianan , Joel Stanley , Rick Chen , U-Boot Mailing List Subject: Re: [PATCH 09/45] CI: Install pyelftools for builds Message-ID: <20220929150540.GC3044094@bill-the-cat> References: <20220925150248.2524421-1-sjg@chromium.org> <20220925150248.2524421-10-sjg@chromium.org> <53180fd5-5cc6-7e6f-e86f-914ebf8732f8@gmx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PZMMlDKQNsLDNvB8" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --PZMMlDKQNsLDNvB8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 28, 2022 at 04:20:41AM -0600, Simon Glass wrote: > Hi Heinrich, >=20 > On Mon, 26 Sept 2022 at 00:35, Heinrich Schuchardt w= rote: > > > > On 9/25/22 17:02, Simon Glass wrote: > > > Binman needs this module to build sandbox_vpl so install it in the > > > before_script and in the world build. The existing pip install is too > > > late for the buildman invocation. > > > > > > Add it to the docker file for the future. > > > > > > Signed-off-by: Simon Glass > > > --- > > > > > > .gitlab-ci.yml | 2 ++ > > > tools/docker/Dockerfile | 1 + > > > 2 files changed, 3 insertions(+) > > > > > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > > > index 8e94bf8d4e8..47e36edcc4a 100644 > > > --- a/.gitlab-ci.yml > > > +++ b/.gitlab-ci.yml > > > @@ -34,6 +34,7 @@ stages: > > > # If we've been asked to use clang only do one configuration. > > > - export UBOOT_TRAVIS_BUILD_DIR=3D/tmp/${TEST_PY_BD} > > > - echo BUILD_ENV ${BUILD_ENV} > > > + - pip install pyelftools > > > > Why do we need pip install here? Is pyelftools used outside the Docker > > image to which you add pyelftools below? >=20 > We don't need it if Tom wants to regen the docker image, but I'm not > sure how often he does that. So this change actually makes CI work, in > either case. I would re-generate the CI image as part of the series, and we should really do this separate and drop the pip install pyelftools we already have, too. --=20 Tom --PZMMlDKQNsLDNvB8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmM1tEEACgkQFHw5/5Y0 tyykowv/YaavO1aCfdkpvOsWyeN/hw0CGiInZ0thHFJHn9+F51aPY6xAPLFtlxbc +rzC05jSgZxQIqzPkXvx1SrJzdBKDP8xKBuXYGYUkcrM79uBMREHU/3yRZWWqU8u HYkz7ZHx90hZ85VY3zXIXFStVkYxb/bR5YquDcK/lbrjlhbsktv/OgtqwyHUpmlX G5MSUO1eVLz++D8U/TBExUlrr/x1b9xXoCyjnb84jyFHeHBqUApWYKZBPVYuRo0h b38Qg1u4T6svG925a2nz9rbP1AcGObRPPfnH9G8j/YUE6i6WbgyswHAo31z/vIum 4lGmHDBPIPrqjcncMZ7unk5ZNVmFSAt7H4nYvmlKxobXeu3hP1cqXFDhT7/uxwLg 9UoH/SetqAC5PEcnjPLIcebEnQ0WbCtEtiz/WD96NgaT8C+yvHHt60+04JEfykq6 QZiopv/ORyRkFqg/Yabuize2RLxM2PM6gj8BJBCDHQqTIVaK9s5kRcEvqlMIbtuw 8SQ0any2 =SGDb -----END PGP SIGNATURE----- --PZMMlDKQNsLDNvB8--