public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Roger Quadros <rogerq@kernel.org>
Cc: Simon Glass <sjg@chromium.org>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [u-boot][PATCH 1/3] scripts: Makefile.spl: Enable memory drivers to be built for SPL
Date: Thu, 29 Sep 2022 13:51:21 -0400	[thread overview]
Message-ID: <20220929175121.GF3044094@bill-the-cat> (raw)
In-Reply-To: <33934f40-f11a-9384-e6fe-968a5a48f0bb@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

On Thu, Sep 29, 2022 at 10:02:54AM +0300, Roger Quadros wrote:
> Hi Simon,
> 
> On 28/09/2022 19:27, Simon Glass wrote:
> > Hi Roger,
> > 
> > On Wed, 28 Sept 2022 at 06:12, Roger Quadros <rogerq@kernel.org> wrote:
> >>
> >> We will need ti-gpmc driver for SPL. Allow memory drivers
> >> do be built for SPL.
> >>
> >> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> >> ---
> >>  scripts/Makefile.spl | 1 +
> >>  1 file changed, 1 insertion(+)
> > 
> > Please can you use the existing drivers/ram directory?
> 
> The ti-gpmc driver is not actually a RAM only controller. Although it can support SRAM.
> It is a more general purpose controller that can support different peripherals.
> It is similar to the drivers already existing in the divers/memory directory.
> 
> I was just trying to keep the file layout similar to that in the Linux kernel.
> 
> Do you still see a problem with it?

Yes, this makes sense because it's not a ram controller driver.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2022-09-29 17:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 12:11 [u-boot][PATCH 0/3] Introduce TI GPMC memory controller driver Roger Quadros
2022-09-28 12:11 ` [u-boot][PATCH 1/3] scripts: Makefile.spl: Enable memory drivers to be built for SPL Roger Quadros
2022-09-28 16:27   ` Simon Glass
2022-09-29  7:02     ` Roger Quadros
2022-09-29 17:51       ` Tom Rini [this message]
2022-09-29 18:06       ` Simon Glass
2022-09-30 12:47         ` Roger Quadros
2022-09-30 13:28           ` Simon Glass
2022-09-30 14:00             ` Tom Rini
2022-09-30 20:17               ` Roger Quadros
2022-09-30 23:48                 ` Simon Glass
2022-10-01  8:37                   ` Roger Quadros
2022-10-03  1:10                     ` Simon Glass
2022-09-28 12:11 ` [u-boot][PATCH 2/3] dt/bindings: memory: Add bindings for TI GPMC driver Roger Quadros
2022-09-28 12:11 ` [u-boot][PATCH 3/3] memory: Add " Roger Quadros
2022-09-29 17:51 ` [u-boot][PATCH 0/3] Introduce TI GPMC memory controller driver Tom Rini
2022-09-30 12:42   ` Roger Quadros
2022-09-30 12:44     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220929175121.GF3044094@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=rogerq@kernel.org \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox