From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6992BC433F5 for ; Tue, 4 Oct 2022 01:06:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6BF04847F4; Tue, 4 Oct 2022 03:06:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Oz0x0auG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 862B584581; Tue, 4 Oct 2022 03:06:36 +0200 (CEST) Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1ABDC847F4 for ; Tue, 4 Oct 2022 03:06:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pg1-x529.google.com with SMTP id c7so11219498pgt.11 for ; Mon, 03 Oct 2022 18:06:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=mBNN42kZzY6h9wBuSa5XTuDGZ4HZ6qNO4ymOgzpzHPE=; b=Oz0x0auG37IX8zKD8E79gQDUd4HU9ZuwHT3tKBNPkyRi/pKXGag7/PD4O/XX7THrOu UGd0RozfwPYzOyZL3A+ZBWFJOL5SfFdDTkQSQRedn27z1hdNUqGZegEt8vrX7ITm+I9o 7Xy3sa2OKe/uYU5d/+iNUlalCXRrp/3G8rxoAzVIlPXtX8YZ0eP7H7+s63PaqqfbcQ+O DJGwmjk7LO16puEUDW9kgG7SxGzxYyGdREJcPrNag4L9u6CkzSeaZHaNJw34QT1VIEVZ pq8vb2EcmJB8Dla1Dcw2Bkbk7afJwCr84Et8LYAEC+YpRXH4qyXWvY0Bb4GG6YmVsMEG q9hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mBNN42kZzY6h9wBuSa5XTuDGZ4HZ6qNO4ymOgzpzHPE=; b=4f6y2lRSEAEj5mytiR36mAOWWFw+0tERcJI5fiWAIIg0rB+RbfFXptSW+s79PiIrwC ECAYcww/vrCUrDaMQDGTa3cbAlEZNGl05ea99Due6LqexY0Lw6v7fyNofJ2LSqojO76d DIh1Ci5fdpWsxaa6MRhl/yiXXGZL1O8PODQJ0f+xWNaqfzKyp1NzlGDZYNW/MZWCvVq7 nRlmwwu1Q0orAblUdZHs6NqThEWU8AdQMoMuYf86swHZkxttgNLZJKmf/cuGX9nruiN1 niuHf5aLh0iVgEqpKDN72AG6x0gGa0UByDbe4ormuZOIgQsvaLh07SM4DEvHF8qmgXjH +rUg== X-Gm-Message-State: ACrzQf2vjHaeBzodoxP+3RK31mNb2q6bNyqeY+y71sOhumS/Nip9DebS zCDc6EqeB2F/rFGEqq6rUfz+YA== X-Google-Smtp-Source: AMsMyM50LbX1jvJyMCcsJJjWwyzr+XbvqCVMImKubXwJFZQHfh51jNmaVnNjcNYTTIjBz3r80rvgfA== X-Received: by 2002:a05:6a00:2185:b0:520:7276:6570 with SMTP id h5-20020a056a00218500b0052072766570mr25270027pfi.84.1664845587303; Mon, 03 Oct 2022 18:06:27 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:5205:befa:c3e8:6c20]) by smtp.gmail.com with ESMTPSA id a82-20020a621a55000000b005618a3561cfsm2033341pfa.48.2022.10.03.18.06.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 18:06:26 -0700 (PDT) Date: Tue, 4 Oct 2022 10:06:22 +0900 From: AKASHI Takahiro To: Ilias Apalodimas Cc: Jassi Brar , u-boot@lists.denx.de, xypron.glpk@gmx.de, sjg@chromium.org, trini@konsulko.com, etienne.carriere@linaro.org, monstr@monstr.eu, Jassi Brar Subject: Re: [PATCHv2 4/5] fwu: DeveloperBox: add support for FWU Message-ID: <20221004010622.GA35036@laputa> Mail-Followup-To: AKASHI Takahiro , Ilias Apalodimas , Jassi Brar , u-boot@lists.denx.de, xypron.glpk@gmx.de, sjg@chromium.org, trini@konsulko.com, etienne.carriere@linaro.org, monstr@monstr.eu, Jassi Brar References: <20221002235046.344149-1-jassisinghbrar@gmail.com> <20221002235214.344423-1-jassisinghbrar@gmail.com> <20221003110426.GB61078@laputa> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Mon, Oct 03, 2022 at 04:51:32PM +0300, Ilias Apalodimas wrote: > Hi Jassi, > > On Mon, 3 Oct 2022 at 16:40, Jassi Brar wrote: > > > > On Mon, Oct 3, 2022 at 6:04 AM AKASHI Takahiro > > wrote: > > > > > > diff --git a/board/socionext/developerbox/developerbox.c b/board/socionext/developerbox/developerbox.c > > > > index f5a5fe0121..a0db26eaf3 100644 > > > > --- a/board/socionext/developerbox/developerbox.c > > > > +++ b/board/socionext/developerbox/developerbox.c > > > > @@ -20,6 +20,13 @@ > > > > > > > > #if CONFIG_IS_ENABLED(EFI_HAVE_CAPSULE_SUPPORT) > > > > struct efi_fw_image fw_images[] = { > > > > +#if defined(CONFIG_FWU_MULTI_BANK_UPDATE) > > > > + { > > > > + .image_type_id = DEVELOPERBOX_FIP_IMAGE_GUID, > > > > + .fw_name = u"DEVELOPERBOX-FIP", > > > > + .image_index = 1, > > > > + }, > > > > +#else > > > > > > From curiosity, why do you want to use different capsule formats > > > for multi-bank update and normal case? > > > > > normal/legacy layout has one image for each component - uboot, tfa and > > optee, whereas the new layout contains everything in one fip image. Yes, that is exactly what I understand here. > > So I thought it would be better to make the image_index consistent by > > making the fip's as 1. > > FWIW this does make a lot of sense. Since the SCP firmware is not > included in the capsule and that SCP firmware is needed to transition > from old -> new layout, I think we are better off having those in > different GUIDs. On top of that those GUIDs can be used in LVFS if we > ever decide to upload firmwares there. > > Not having discrete GUIDs means there's a chance to brick the board on > old -> new update, unless the SCP is explicitly updated. SCP? I don't care. My question is why you use a single capsule (FIP) in A/B update while you use three separate capsule files in normal case. -Takahiro Akashi > Cheers > /Ilias > > > > cheers.