From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36E00C433FE for ; Tue, 4 Oct 2022 02:44:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3AB6884B20; Tue, 4 Oct 2022 04:44:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="zQjTPEpW"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 65E4E84BB9; Tue, 4 Oct 2022 04:44:22 +0200 (CEST) Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 71CE78495E for ; Tue, 4 Oct 2022 04:44:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x62c.google.com with SMTP id 10so7834338pli.0 for ; Mon, 03 Oct 2022 19:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=pgQd8r/kXFTr0qRo/P4TstzJM0DKhLCNimULaT73vow=; b=zQjTPEpWrXqSZ2pFfmaY9IesfrAYs6kSiSCwXC+DVhJPtolmjyQBLRJOIGZKnnNLBq pgxwY1d+h7Yqq3e6T4KroZcZxN0NgsBZZZFRY8ooETtfJ7/FHl9VxdgpRD21j0p8cq3d 4Hqyrh7rWTJzuK8axPU/Svt+Tfob92t/oxgfalbEQPJJy5Q/6kkUYQ1DcKLkcIo54kZC gEwg1DBxlPEBn6QzDes7rlpg9ENZLXH6XZzjWyHw7Nb0ErS2IeLpacj1v1g1+GYszv5M FT5oVM2kfDNXxUnxmNQrnLT7MXPiuoVbvvac6h/XU31GIJTdhnz753uYIKrua9qZ8Omb F0GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pgQd8r/kXFTr0qRo/P4TstzJM0DKhLCNimULaT73vow=; b=qj/X312zJk+pYgjDR3vKpnpqvMzuUDaWnel3deFSG5aOLH84X+GS5uRgaDjgBUQjM4 oNZI8vYcVfIMY3OPFeY4NXc5BHqt4jv81Vxry7tf3x115nSUZ/ln2JspUrShd+KaiELX mz58+SCYES9pTJ5ZXnlmjsc2SSycH+pmn3eVQHVQxhD3Xa8ehs7BlFXXZOzViJqNJDfi DmWLfmV8TvXAACXFzPAY+OuP1H459D8asNVBjDSnTnAEXofjscSANfCJ3BD3+xr33Cu/ +6Kgg5i8u4bDV7WzwIPD15QMnvizrMCnzAb/9ADH4K3KHU311LjV3YzVqZ3nsWYE7BMm ICeg== X-Gm-Message-State: ACrzQf327g5xkqq0ZkumvPLHt/l8U/Pk40expGn3PxKVrm/CAzvyu1hc sO/aaF8tM4FY/Mtv9gKRAB2ZeQ== X-Google-Smtp-Source: AMsMyM6uuASwyCagFMojIMgg0p1tB3wOSPVnZD6solNVZ9pP+skdm6gTtfQF78UXoiDNfobRE6gsIQ== X-Received: by 2002:a17:90a:c916:b0:20a:a145:85bd with SMTP id v22-20020a17090ac91600b0020aa14585bdmr8028535pjt.88.1664851457526; Mon, 03 Oct 2022 19:44:17 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:5205:befa:c3e8:6c20]) by smtp.gmail.com with ESMTPSA id x12-20020a1709027c0c00b0017f205d91d9sm3402289pll.118.2022.10.03.19.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 19:44:16 -0700 (PDT) Date: Tue, 4 Oct 2022 11:44:12 +0900 From: AKASHI Takahiro To: Jassi Brar Cc: Ilias Apalodimas , u-boot@lists.denx.de, xypron.glpk@gmx.de, sjg@chromium.org, trini@konsulko.com, etienne.carriere@linaro.org, monstr@monstr.eu, Jassi Brar Subject: Re: [PATCHv2 4/5] fwu: DeveloperBox: add support for FWU Message-ID: <20221004024412.GA36861@laputa> Mail-Followup-To: AKASHI Takahiro , Jassi Brar , Ilias Apalodimas , u-boot@lists.denx.de, xypron.glpk@gmx.de, sjg@chromium.org, trini@konsulko.com, etienne.carriere@linaro.org, monstr@monstr.eu, Jassi Brar References: <20221002235046.344149-1-jassisinghbrar@gmail.com> <20221002235214.344423-1-jassisinghbrar@gmail.com> <20221003110426.GB61078@laputa> <20221004010622.GA35036@laputa> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Mon, Oct 03, 2022 at 09:00:35PM -0500, Jassi Brar wrote: > On Mon, Oct 3, 2022 at 8:06 PM AKASHI Takahiro > wrote: > > > > On Mon, Oct 03, 2022 at 04:51:32PM +0300, Ilias Apalodimas wrote: > > > Hi Jassi, > > > > > > On Mon, 3 Oct 2022 at 16:40, Jassi Brar wrote: > > > > > > > > On Mon, Oct 3, 2022 at 6:04 AM AKASHI Takahiro > > > > wrote: > > > > > > > > > > diff --git a/board/socionext/developerbox/developerbox.c b/board/socionext/developerbox/developerbox.c > > > > > > index f5a5fe0121..a0db26eaf3 100644 > > > > > > --- a/board/socionext/developerbox/developerbox.c > > > > > > +++ b/board/socionext/developerbox/developerbox.c > > > > > > @@ -20,6 +20,13 @@ > > > > > > > > > > > > #if CONFIG_IS_ENABLED(EFI_HAVE_CAPSULE_SUPPORT) > > > > > > struct efi_fw_image fw_images[] = { > > > > > > +#if defined(CONFIG_FWU_MULTI_BANK_UPDATE) > > > > > > + { > > > > > > + .image_type_id = DEVELOPERBOX_FIP_IMAGE_GUID, > > > > > > + .fw_name = u"DEVELOPERBOX-FIP", > > > > > > + .image_index = 1, > > > > > > + }, > > > > > > +#else > > > > > > > > > > From curiosity, why do you want to use different capsule formats > > > > > for multi-bank update and normal case? > > > > > > > > > normal/legacy layout has one image for each component - uboot, tfa and > > > > optee, whereas the new layout contains everything in one fip image. > > > > Yes, that is exactly what I understand here. > > > > > > So I thought it would be better to make the image_index consistent by > > > > making the fip's as 1. > > > > > > FWIW this does make a lot of sense. Since the SCP firmware is not > > > included in the capsule and that SCP firmware is needed to transition > > > from old -> new layout, I think we are better off having those in > > > different GUIDs. On top of that those GUIDs can be used in LVFS if we > > > ever decide to upload firmwares there. > > > > > > Not having discrete GUIDs means there's a chance to brick the board on > > > old -> new update, unless the SCP is explicitly updated. > > > > SCP? I don't care. > > My question is why you use a single capsule (FIP) in A/B update while you use > > three separate capsule files in normal case. > > > We think it is cleaner to not tie up boot binaries at fixed offsets in > storage, so all CA53 boot assets are now in one parseable FIP image. > Secondly, and personally, I think there is no real usecase of more > than one image per bank - that will be too fragile and complicated to > manage. If so, my point is why not use a single capsule in normal case (a single bank in another word) as well? -Takahiro Akashi > cheers.