Re: [u-boot][PATCH v2 2/4] scripts: Makefile.spl: Enable memory drivers to be built for SPL

Tom Rini
2022-10-18T17:40:37Z

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

On Thu, Oct 06, 2022 at 04:23:58PM +0300, Roger Quadros wrote:
> We will need ti-gpmc driver for SPL. Allow memory drivers
> do be built for SPL.
>
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
> scripts/Makefile.spl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
> index 3bafeb4fe9..110076b22f 100644
> --- a/scripts/Makefile.spl
> +++ b/scripts/Makefile.spl
> @@ -114,6 +114,7 @@ libs-$(CONFIG_PARTITIONS) += disk/
> endif
>
> libs-y += drivers/
> +libs-y += drivers/memory/
> libs-$(CONFIG_SPL_USB_GADGET) += drivers/usb/dwc3/
> libs-$(CONFIG_SPL_USB_GADGET) += drivers/usb/cdns3/
> libs-y += dts/

This ends up being the wrong approach as it then pulls in
drivers/memory/stm32-fmc2-ebi.o on all of those platforms, in SPL, which
is not what's intended. We need an SPL_MEMORY symbol and then gate the
directory on that.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]