From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2C3AC433FE for ; Fri, 7 Oct 2022 15:48:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E79EB84E7E; Fri, 7 Oct 2022 17:48:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="O9nvA3ys"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0089384B2B; Fri, 7 Oct 2022 17:47:57 +0200 (CEST) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 507D7848CF for ; Fri, 7 Oct 2022 17:47:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id d12so1828923qtp.3 for ; Fri, 07 Oct 2022 08:47:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9xcyaFz/C/fRB4a8eGtqE07BaDCdRFJwVHcbDLrseOU=; b=O9nvA3ys28hLXgaR+P9zK6JpVsCDpf9uPJA2JsgCGKwuy+h8PCIs5MpBVKiE1KKGIW 9PdL844vCqM5t9BxEARm0Q/2akNRQ6fAt2QdHZhVXEe/kBYJ9TT7YdEhK2/d2k7RiN+d 4W2SdAMIuUKf6F4AtuQQx1LzJFIM/6upxMnwQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9xcyaFz/C/fRB4a8eGtqE07BaDCdRFJwVHcbDLrseOU=; b=myeaIEkpkPJUvldkFjCWm1SqeGSfONqzSJEhyHga2p6x0GLj2KPJlqHohfuSiFIKC7 7772H//qZYaHI4jtEgb10TLTapW9uUlQyx/kTFfKisK0ooEcY6j8wzoqh0fpuBanYhO7 Vyac78szESFVP3qV2VqtnrZBmVJrJ3ZJpL1fYBM4tQeHXHcSuZ0yPC4wzrTOWP1X4e/h 0naojibsI0KSgR7LdMXobG0IEVYrCywYP/ZGpf3pl4xAzd/CMGMFtVLUKIrO4Vhu9Sn+ yskVQnZzqd4Qj78YkjKd4w3V9I3z1ioyWUpGNhCiZa9ymfKhTFrF5JrGvsTbvK06LR++ /dGQ== X-Gm-Message-State: ACrzQf36O2VsuVBVuwKPD1J1YjCrbxFHyj3TC+0YXy28G89QbMQ6Jemt ookxvmBrs+792sNxJ5FgpbSCJg== X-Google-Smtp-Source: AMsMyM4tJFV5X1Xm7kHgSFSmOg7iRGfrLDGLQbBJ3LocaufJ/XDDrD2zdTBD3E3hpMN02tvNxYKvXg== X-Received: by 2002:a05:622a:11cf:b0:35b:a369:cc3 with SMTP id n15-20020a05622a11cf00b0035ba3690cc3mr4736618qtk.11.1665157672159; Fri, 07 Oct 2022 08:47:52 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-e4fb-bc51-aba6-f69c.res6.spectrum.com. [2603:6081:7b00:6400:e4fb:bc51:aba6:f69c]) by smtp.gmail.com with ESMTPSA id bs38-20020a05620a472600b006b615cd8c13sm2298893qkb.106.2022.10.07.08.47.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Oct 2022 08:47:51 -0700 (PDT) Date: Fri, 7 Oct 2022 11:47:50 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Stefan Roese , Mark Kettenis , Andre Przywara , Marek =?iso-8859-1?Q?Beh=FAn?= , u-boot@lists.denx.de Subject: Re: [PATCH] armv8: cache_v8: Fix pgtables setup when MMU is already enabled Message-ID: <20221007154750.GC3044094@bill-the-cat> References: <20220914113746.16701-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9faJzSu0rU4kggus" Content-Disposition: inline In-Reply-To: <20220914113746.16701-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --9faJzSu0rU4kggus Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 14, 2022 at 01:37:46PM +0200, Pali Roh=E1r wrote: > When MMU is already enabled then dcache_enable() does not call mmu_setup() > and so setup_all_pgtables() is also never called. >=20 > In this situation when some driver calls mmu_set_region_dcache_behaviour() > function then U-Boot crashes with error message: >=20 > Emergency page table not setup. >=20 > Fix this issue by explicitly calling setup_all_pgtables() in dcache_enabl= e() > function near condition for mmu_setup(). >=20 > This change fixes chainloading U-Boot from U-Boot on Turris Mox board whi= ch > uses mvneta ethernet driver which calls mmu_set_region_dcache_behaviour(). >=20 > Signed-off-by: Pali Roh=E1r > Reviewed-by: Marek Beh=FAn > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! --=20 Tom --9faJzSu0rU4kggus Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNASiUACgkQFHw5/5Y0 tyxu6Qv8DA1jzO6z83gGuuNJn7Pc7gZpVMsOcYKjpqkWs4LgeervA6U/DuaSzKwl lAN8JT6CYxpKhRpwles7nzYvuvB1biQBjeKtF9om7v50EpH06luRsBJpzfLCygsE IrBYA8IZMlTnJpOUJSikPpCRi+HOaUZWUzwG+1/nF3OYgfZcWU6kjYBP4lLYg//Y BGOD/y80m93IZCljHafyvucyEMH9tEdQV67ieN7aQWhJeA/dyU3BWFyjRzQICS2h n1okAc9hx/U9lesSiMnwltuj38LNer6jeM6Y0LUDm4HDe5ql0RHAHw56aDSya7F4 S8Jcf+arJSi6M6qVysegxzb6ByY8xaDn892ZWt5XBGnjNHFB8Ezz/Rm61LMrpP2T ssRB6f/sDt5+rGrIJKIJz99Ytsxq0XjR29wmIijEu4WIc4fppF3r9b3NXOER1ruT 0W2pLhDeUOBeCT23Dm/yzLpZMz2mvVW3Y2HyRtD0iyRivbTNB7xrKbkIqFzH6oG6 zD50ekmV =qZTi -----END PGP SIGNATURE----- --9faJzSu0rU4kggus--