From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DDC8C433F5 for ; Mon, 10 Oct 2022 15:24:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 16AD184EEA; Mon, 10 Oct 2022 17:24:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="GNAw2yYU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 646E384EEB; Mon, 10 Oct 2022 17:24:19 +0200 (CEST) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7BD4E84967 for ; Mon, 10 Oct 2022 17:24:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82f.google.com with SMTP id c23so2649847qtw.8 for ; Mon, 10 Oct 2022 08:24:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OzHgU5oZTwu0NQHZ3+g+iO4GlBNuSjSsC3GApuXOyPg=; b=GNAw2yYUk7cfmWG+i3d8tFS2+t81Jg+WRnw3u0t+57HOzrSP0V6U5GvdiX2agtAMJj XtAEZKN2Qq00tNJ6ffNyUSwZqCcz3eLth7hl58TnpKJUnMyMoR3uBLOhTeoxCjkbtO9L dT5+uaZRgg83QvdKOsLRIHbEzL6wZILYVpCAM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OzHgU5oZTwu0NQHZ3+g+iO4GlBNuSjSsC3GApuXOyPg=; b=8M6zCUgj6Rg0GJTi/oG4ZmIy2iJE0DSgzCPm8GcEq4QrrEiM9KzXyeCD0WSTvWJcHC zBrlGXh0jQ1xyMAdk+W5vaA/dnICpuK9dByhCpserIsPXaUNxzd1z0IuwCji0efQIk5c BDpPMpklF+/x9Am2/Khlj/drWMZFxgvj4qV7t4tLIhDAeeNy86WDmRwDE+s2NvP09rd7 u9N4479cjBFzHr+NkYdBcYDsPtqTqobZTxuOl7mQIOyXB2CrkpIftn3FAnr3PdLth0vc /J3l7zwlPj326Q+SVH97Y6QjLA1pWEs9cadMUS8DjwHaZizRYq8YU/nWdt/kO5YmRfpw g2/Q== X-Gm-Message-State: ACrzQf2bykufUOcnWsABkNBG0PALkCTAAEG3wpFyZHlunNH0fsW1Q0df xWeCP4jfn6VV1N1YNluGxCrBJg== X-Google-Smtp-Source: AMsMyM4kRITxBtCzKWjxJ0tLi3gpgaStJhjtGqsidKuv9Jwydsc3/fSL8YWC8WSRLyh4g6JJf2v0aQ== X-Received: by 2002:a05:622a:164a:b0:35c:b87f:4839 with SMTP id y10-20020a05622a164a00b0035cb87f4839mr15243878qtj.219.1665415455313; Mon, 10 Oct 2022 08:24:15 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-9534-07b5-32fb-791d.res6.spectrum.com. [2603:6081:7b00:6400:9534:7b5:32fb:791d]) by smtp.gmail.com with ESMTPSA id bi7-20020a05620a318700b006ec56b71027sm4623849qkb.1.2022.10.10.08.24.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 08:24:14 -0700 (PDT) Date: Mon, 10 Oct 2022 11:24:13 -0400 From: Tom Rini To: Simon Glass Cc: Rasmus Villemoes , U-Boot Mailing List , Masahiro Yamada Subject: Re: [PATCH v2 01/38] Makefile: Fake external blobs by default with binman Message-ID: <20221010152413.GH2020586@bill-the-cat> References: <20220110031413.1970836-1-sjg@chromium.org> <20220110031413.1970836-2-sjg@chromium.org> <618ffc64-3880-393b-e13c-0908d8b577ad@prevas.dk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pyE8wggRBhVBcj8z" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --pyE8wggRBhVBcj8z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 10, 2022 at 09:19:39AM -0600, Simon Glass wrote: > Hi Rasmus, >=20 > On Mon, 10 Oct 2022 at 04:16, Rasmus Villemoes > wrote: > > > > On 10/01/2022 04.13, Simon Glass wrote: > > > This behaviour is necessary with boards where the binman description > > > requires processing external blobs, since these may be missing. > > > > > > Enable it by default, so that CI is happy. Warnings indicate that a v= alid > > > image is not produced, as with the --allow-missing option. > > > > I know I have talked and warned about this before, and now I was > > actually bitten by it IRL. > > > > Can we _please_ stop doing this by default. I understand why upstream > > U-Boot's CI system needs this, but it should be possible for that CI > > system to set an environment variable or pass a make parameter to opt-in > > to generating these fake blobs. > > > > Generating potentially non-functional binaries by default, and currently > > without even a way to opt out of that (that I have found), is frankly > > not sane. Yeah, a warning is printed, but that easily scrolls away or in > > the case of automated builds is hidden away in some log file people > > would only ever look at if the job failed. > > > > I want my/our CI to _fail hard_ when I have failed to update the Yocto > > metadata to stage the necessary blobs before do_compile. And if upstream > > U-Boot want to continue to have this by default, can we at the very > > least get an ergonomic way to opt out (preferably a CONFIG_ option I can > > set or clear in my out-of-tree defconfig files). >=20 > How come it doesn't fail? Building should produce an error 101 in this > case. Does it not? Please send the details if there is something > wrong. No, it does not. You can see this for example with: $ make galileo_config =2E.. $ make -sj16 Image 'main-section' is missing external blobs and is non-functional: intel= -cmc Image 'main-section' has faked external blobs and is non-functional: rmu.bin Some images are invalid $ echo $? 0 --=20 Tom --pyE8wggRBhVBcj8z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNEORkACgkQFHw5/5Y0 tyzMbgv/d08j9ZL6mH2PJurmk79Hvf3T4taRgdSAqCYWmfSV3rxXtmBXJa8OCnlN Z8Pb3GgIunngvpqiDMlmrYxPBOLEYi2PihHuYIOkp/8yGhYFLh05+a2e94qaz5gV zqJDkZsLbZ7+P16sOgKg82Iq0fV1lHqpcLH1j+z3HKu/FL2JpXNJn/79CXMV71H3 OX0sbO48kubKgRIkSVTIxWhAnu4TyuhRqxIX0l7OU2+DQvu2MQgvSnP0yt6mHFbJ MXL7XKhCvEDrEUOKt7K3g9akPrIxTMsX7GAsVgd/PCfQmYVjDllNDRe0W5+fo71z CqWrePi3n8/o6fqBIxGPfkbPCEzQazZ4tNq8QRYKOBiRX6xdjwls+iZB41Lk0d8d CBUH0zd6q+3iUuZkUzgCRZAMeGm/Zl+FI+5rCBIM8T1aF+8lK4mjNT/gdTa09l1N u5Qv76pPKlwcFrcyqB8iGsGr7YhTJfBm/+YYw80uir5U0TFblnS1IhF4CVI+CVSP qfhIwlbU =+zJB -----END PGP SIGNATURE----- --pyE8wggRBhVBcj8z--