From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0F7AC433FE for ; Mon, 10 Oct 2022 15:36:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5C57584EE6; Mon, 10 Oct 2022 17:36:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="a00MpXce"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6610784EEB; Mon, 10 Oct 2022 17:36:36 +0200 (CEST) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7E57D84967 for ; Mon, 10 Oct 2022 17:36:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x736.google.com with SMTP id j21so4655595qkk.9 for ; Mon, 10 Oct 2022 08:36:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=W9oQVWEtdA9ChItEng9z9vO1QelO/DlABjyUfrz8/Ws=; b=a00MpXceUUqT0LMMePUuk5SDxRqE+NQTy2HD+cfg1wpYdvNPqLi5KCfVPKfwXBpyhZ PEjJIdeYzMe+qyooDbamCPD2fGzh0FQVoQBzoUJHi/uQgftFtoVEzSuYyNsrAxYR7rKW pjyBN8WuqCn9EP5iMbeNvZGJe9Erb5bSK/ZHs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W9oQVWEtdA9ChItEng9z9vO1QelO/DlABjyUfrz8/Ws=; b=qDGKrjF4thlsV2JYNruVejDFqr67fh75uvWimrNm1aI8kiuhQFMyCckNvYWRJozWAL 4sYbJZ2QCSCaoA4mnmOqez/BKzpRB3QQsHqB7VFjOQTYenteH6zK3LAPb6KvYcLYy1aA QhoNL3QpYNvyiztWDPHtBFDpduwchfK3oYI1ZT5tsORvanPlPpBwUGusztvc4Ph2fRgv 7yr8mrzejQm+nP2vkANMkx84Oui3nz/OvKyvAt9hxQdC+JIvuBfY9mnxgpYGE6E7Ijxk OU+rJUGcUGO+poFPbHhbBi8IGPeCEyUi6fqFSEsl4c3ggYf/x9Lh26I23KFyqDxT/ipP qguw== X-Gm-Message-State: ACrzQf2vkrU9UDUQ/Ux9aZpTxswwO7Fye6zZuxd5HIRyum3rUaSAQtsV hsEoS2280WhJAkCfk4kDY+lk/g== X-Google-Smtp-Source: AMsMyM4WcHpIHkBKyikVkTOxr+4IqrpHgn6RmzdlMeicyHLQf5h7Vi8jwBqO5kPShqLDngLqPBiNjA== X-Received: by 2002:a05:620a:260e:b0:6df:a30d:dc87 with SMTP id z14-20020a05620a260e00b006dfa30ddc87mr13061377qko.643.1665416192211; Mon, 10 Oct 2022 08:36:32 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-9534-07b5-32fb-791d.res6.spectrum.com. [2603:6081:7b00:6400:9534:7b5:32fb:791d]) by smtp.gmail.com with ESMTPSA id k19-20020a05620a0b9300b006ecb9dfdd15sm3280093qkh.92.2022.10.10.08.36.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 08:36:31 -0700 (PDT) Date: Mon, 10 Oct 2022 11:36:29 -0400 From: Tom Rini To: Simon Glass Cc: Rasmus Villemoes , U-Boot Mailing List , Masahiro Yamada Subject: Re: [PATCH v2 01/38] Makefile: Fake external blobs by default with binman Message-ID: <20221010153629.GI2020586@bill-the-cat> References: <20220110031413.1970836-1-sjg@chromium.org> <20220110031413.1970836-2-sjg@chromium.org> <618ffc64-3880-393b-e13c-0908d8b577ad@prevas.dk> <20221010152413.GH2020586@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p7qwJlK53pWzbayA" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --p7qwJlK53pWzbayA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 10, 2022 at 09:33:59AM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Mon, 10 Oct 2022 at 09:24, Tom Rini wrote: > > > > On Mon, Oct 10, 2022 at 09:19:39AM -0600, Simon Glass wrote: > > > Hi Rasmus, > > > > > > On Mon, 10 Oct 2022 at 04:16, Rasmus Villemoes > > > wrote: > > > > > > > > On 10/01/2022 04.13, Simon Glass wrote: > > > > > This behaviour is necessary with boards where the binman descript= ion > > > > > requires processing external blobs, since these may be missing. > > > > > > > > > > Enable it by default, so that CI is happy. Warnings indicate that= a valid > > > > > image is not produced, as with the --allow-missing option. > > > > > > > > I know I have talked and warned about this before, and now I was > > > > actually bitten by it IRL. > > > > > > > > Can we _please_ stop doing this by default. I understand why upstre= am > > > > U-Boot's CI system needs this, but it should be possible for that CI > > > > system to set an environment variable or pass a make parameter to o= pt-in > > > > to generating these fake blobs. > > > > > > > > Generating potentially non-functional binaries by default, and curr= ently > > > > without even a way to opt out of that (that I have found), is frank= ly > > > > not sane. Yeah, a warning is printed, but that easily scrolls away = or in > > > > the case of automated builds is hidden away in some log file people > > > > would only ever look at if the job failed. > > > > > > > > I want my/our CI to _fail hard_ when I have failed to update the Yo= cto > > > > metadata to stage the necessary blobs before do_compile. And if ups= tream > > > > U-Boot want to continue to have this by default, can we at the very > > > > least get an ergonomic way to opt out (preferably a CONFIG_ option = I can > > > > set or clear in my out-of-tree defconfig files). > > > > > > How come it doesn't fail? Building should produce an error 101 in this > > > case. Does it not? Please send the details if there is something > > > wrong. > > > > No, it does not. You can see this for example with: > > $ make galileo_config > > ... > > $ make -sj16 > > Image 'main-section' is missing external blobs and is non-functional: i= ntel-cmc > > Image 'main-section' has faked external blobs and is non-functional: rm= u.bin > > > > Some images are invalid > > $ echo $? > > 0 >=20 > Ah OK, that is a bug, though. I suppose I normally use buildman so > don't see it, and we have no test for it. >=20 > I'll take a look when I get the -N thing done. Well, it's a design feature that buildman shows too. See the series I just posted, we've been unconditionally passing binman the flags to always allow and fake missing binaries. --=20 Tom --p7qwJlK53pWzbayA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNEO/oACgkQFHw5/5Y0 tyyogwv6Al9uof5HpDD15Nj649X+4/Oa0QoPiH+2uBTzMBeCqnknsLHZwpAN8ZAD jvko90iIhBwkYlBlqMh6eW0RQCIKd26sTKrrIYBjYaidecER1VPuW+gc3VocjJHm 1wYK3shlOPR7jcUW7eUrmImIMsr6gpD3LIOc7K53D1DRzPdAF0zEd1rqvpOUnFEg ommflDzDTrCOXnb5veDWOmgwuCgH+6/p7qEamdO17linwP8T6QyfJ9+jz9r4E/f6 PbgZjWcx7rBAcH6BXR49fhFUBLA69MOJ+zSq7+xz9YX21Y6JXt4v6ED+AGQ1UMED RreOHcQHCPbdj4mvNCj9dAyW9Ph1P+KPBlJdZX2/2yEpQVfNb5ZYANzcFUea7hoQ CuwNzVc4aVR8bKi66aYSuljyHTkyPNZ4pJBQATHHdEzYZ6A47iL2l9VcB1u76pox htF5GC2E77tuWPUzJIxXPVAbu6/vJ2Nt+aV7JznmXnpUfjONDD3LgifdV1d9WfPi TQlXCF15 =/Q86 -----END PGP SIGNATURE----- --p7qwJlK53pWzbayA--