From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>, "Stefan Roese" <sr@denx.de>
Cc: u-boot@lists.denx.de
Subject: Re: Broken watchdog in u-boot master branch
Date: Mon, 10 Oct 2022 12:28:18 -0400 [thread overview]
Message-ID: <20221010162818.GM2020586@bill-the-cat> (raw)
In-Reply-To: <20221009191225.65jwebefhqng3qbi@pali>
[-- Attachment #1: Type: text/plain, Size: 926 bytes --]
On Sun, Oct 09, 2022 at 09:12:25PM +0200, Pali Rohár wrote:
> Hello! Watchdog code seems to be broken in u-boot master branch.
> On Nokia N900 I'm getting following message in qemu:
>
> cyclic function rx51_watchdog took too long: 10000us vs 1000us max, disabling
>
> Seems that watchdog core code is not prepared for "slower" watchdogs
> which communicate over slower i2c bus, like it is the case for N900.
>
> Disabling slower watchdog is a bad idea as it would result in reboot
> loop instead of slower - but working code.
So, looking at this in more detail, we have
CONFIG_CYCLIC_MAX_CPU_TIME_US as a configuration option (which is where
the too long comes from). And picking a random CI run:
https://source.denx.de/u-boot/u-boot/-/jobs/511177
I do see we hit this in CI once, but not every time, QEMU runs here. Is
that the max time is configurable enough to satisfy your concerns here?
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-10-10 16:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 19:12 Broken watchdog in u-boot master branch Pali Rohár
2022-10-10 13:55 ` Tom Rini
2022-10-10 16:19 ` Pali Rohár
2022-10-11 7:18 ` Rasmus Villemoes
2022-10-11 7:25 ` Pali Rohár
2022-10-17 6:52 ` Stefan Roese
2022-10-10 16:28 ` Tom Rini [this message]
2022-10-10 17:22 ` Pali Rohár
2022-10-10 17:40 ` Tom Rini
2022-10-10 17:44 ` Pali Rohár
2022-10-10 17:56 ` Tom Rini
2022-10-10 18:01 ` Pali Rohár
2022-10-10 18:14 ` Tom Rini
2022-10-10 19:24 ` Tom Rini
2022-10-10 19:33 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221010162818.GM2020586@bill-the-cat \
--to=trini@konsulko.com \
--cc=pali@kernel.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox