Re: Broken watchdog in u-boot master branch

Tom Rini
2022-10-10T18:14:38Z

[-- Attachment #1: Type: text/plain, Size: 3771 bytes --]

On Mon, Oct 10, 2022 at 08:01:23PM +0200, Pali Rohár wrote:
> On Monday 10 October 2022 13:56:10 Tom Rini wrote:
> > On Mon, Oct 10, 2022 at 07:44:05PM +0200, Pali Rohár wrote:
> > > On Monday 10 October 2022 13:40:38 Tom Rini wrote:
> > > > On Mon, Oct 10, 2022 at 07:22:56PM +0200, Pali Rohár wrote:
> > > > > On Monday 10 October 2022 12:28:18 Tom Rini wrote:
> > > > > > On Sun, Oct 09, 2022 at 09:12:25PM +0200, Pali Rohár wrote:
> > > > > > > Hello! Watchdog code seems to be broken in u-boot master branch.
> > > > > > > On Nokia N900 I'm getting following message in qemu:
> > > > > > >
> > > > > > > cyclic function rx51_watchdog took too long: 10000us vs 1000us max, disabling
> > > > > > >
> > > > > > > Seems that watchdog core code is not prepared for "slower" watchdogs
> > > > > > > which communicate over slower i2c bus, like it is the case for N900.
> > > > > > >
> > > > > > > Disabling slower watchdog is a bad idea as it would result in reboot
> > > > > > > loop instead of slower - but working code.
> > > > > >
> > > > > > So, looking at this in more detail, we have
> > > > > > CONFIG_CYCLIC_MAX_CPU_TIME_US as a configuration option (which is where
> > > > > > the too long comes from). And picking a random CI run:
> > > > > > https://source.denx.de/u-boot/u-boot/-/jobs/511177
> > > > > > I do see we hit this in CI once, but not every time, QEMU runs here. Is
> > > > > > that the max time is configurable enough to satisfy your concerns here?
> > > > >
> > > > > It is needed to investigate, how to _properly_ fix this issue, not just
> > > > > workarounded it. Probably other boards may be affected.
> > > >
> > > > So it's the cyclic watchdog code, which we merged as early as possible
> > > > that's the reason here. And it was merged as early as we could to see if
> > > > there's problems. Are there problems? We're seeing "system too slow,
> > > > disabling" on QEMU, sometimes, and the value of too slow is
> > > > configurable. I know you reported other problems with n900 HW, so we
> > > > can't see if it's failing there
> > >
> > > I was tested it with older asm code (as described in that other email,
> > > via git checkout commit -- file) on n900 HW and watchdog problem is
> > > there too. Phone reboots in about 20 seconds. But as I do not have
> > > serial console, I do not know if that "disabling" message is printed
> > > there too (but I guess it is).
> >
> > I think I'm a bit baffled at this point, honestly. The watchdog timeout
> > is 60 seconds. If you're confident in it being about 20 seconds,
> > consistently, changing WATCHDOG_TIMEOUT_MSECS to say 10000 (so, 10
> > seconds) should let you see if U-Boot has configured the watchdog and
> > it's being tripped, or if it's still at the prior stage value.
>
> $ git grep CONFIG_WATCHDOG_TIMEOUT_MSECS configs/nokia_rx51_defconfig
> configs/nokia_rx51_defconfig:CONFIG_WATCHDOG_TIMEOUT_MSECS=31000
>
> Also watchdog is started by NOLO (which loads and execute U-Boot) so
> there can be some smaller timeout.
>
> So I have feeling that on the real HW is same issue. cyclic code
> disabled watchdog kicking and then watchdog restarted phone.
>
> I do not remember exact time (if it is 20s or 25s; I have not measured
> it precisely), but it sounds plausible.

OK, so what happens if you increase CONFIG_CYCLIC_MAX_CPU_TIME_US to
something very high (so we should still enable the watchdog and
configure the timeout) along with CONFIG_WATCHDOG_TIMEOUT_MSECS being
high too (so if we can't service it in time really it's so long as to be
noticeable) ? Or CONFIG_WATCHDOG_TIMEOUT_MSECS to something much lower
(so that if the device is resetting quicker we're crashing elsewhere) ?

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]