From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09758C433FE for ; Tue, 11 Oct 2022 07:35:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 898CC84A20; Tue, 11 Oct 2022 09:35:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="rCOY3HX8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 611B3848E3; Tue, 11 Oct 2022 09:35:51 +0200 (CEST) Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C120984C8E for ; Tue, 11 Oct 2022 09:35:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x634.google.com with SMTP id d24so12464432pls.4 for ; Tue, 11 Oct 2022 00:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=vAF3PCEkkiWs4ggEjTaY/98xz+unpyzMSg/TzEtdeew=; b=rCOY3HX8Qf8+v9hGpdN7lTG4EHTHobVXeanZ2HvMwSuP8fqDEZEeK8dj/4fF6pHN/b LElRjH3hRDRjD5UuFMuaK64fF6sqW1g32MpjGmH0Eh8gAmBpH8d0aPKBq87Gh716LDc3 CHbDrjsNVmZxLuvWdGJvKFbFcAv9HCjOFMvVNZIKPa5b2sKEgbagSubFpd4IyaPp1DLf 0eJc43WSNhUaTMqeItkfbMY+TsidDuFT7jpOhhdBqpiGgyOiS7U2EDVQBtbcGHimGzNS qmWC+b8Wr8S9KUQ2IzbDueHE0sd+FvkEe55XNihJutX3BNKxpXWM7HnTWjOo0yW3lty1 ofLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vAF3PCEkkiWs4ggEjTaY/98xz+unpyzMSg/TzEtdeew=; b=2KeLrhssdIZrMFUHrr+Z4cqMuhGJjP4H3XPgMoGeycSJl58hKlfR892h2i4KBRgypc vAR0o82aYOVL8VchnI1nhHO516uzEkP2lTSiY5gUoES/JsOb9OyQOO4EiJ38w/kAWma1 bpPJ3uVvo0befbzCCG6PmY++Jw6irCUQf+lT7O6wPMzR1IEgdOjaEP9F+AUXJDuWtsQW e+ArRi8/d1s0zk9RefDTBiR0hLkjcfwODD8S0A2ZjkJtcTNR+ZMSWV7YEb0nkmOxanHQ osMUrLNK8OSzUewcmDSUel9bBaCzbywj8ErRwaa7ZvDImPc3qnq4ugQXpc+s47dKrpMJ pqsg== X-Gm-Message-State: ACrzQf2UeOWlREZm8JJavY71sY9vVNcLckGoCTLoeXWe+Nk7eQsj092h kzRe9zzebswB+CttqhhKW+UrXg== X-Google-Smtp-Source: AMsMyM4DaIbQxrPXIOyMlUf/R3dsC8ueXQDSwMgSiNws6qdq5sEf6r5XPOYPB0252VvxDSilnmC/JQ== X-Received: by 2002:a17:902:d50e:b0:176:e777:59c4 with SMTP id b14-20020a170902d50e00b00176e77759c4mr22766883plg.82.1665473745846; Tue, 11 Oct 2022 00:35:45 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:e18:1c25:9aae:c323]) by smtp.gmail.com with ESMTPSA id z6-20020a170902d54600b00178af82a08dsm7849031plf.91.2022.10.11.00.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 00:35:45 -0700 (PDT) Date: Tue, 11 Oct 2022 16:35:41 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: Ilias Apalodimas , u-boot@lists.denx.de Subject: Re: [PATCH 1/1] efi_loader: CloseProtocol in efi_fmp_find Message-ID: <20221011073541.GB39168@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , Ilias Apalodimas , u-boot@lists.denx.de References: <20221007140623.167909-1-heinrich.schuchardt@canonical.com> <20221011004939.GA39168@laputa> <7d7b2d2d-ef72-7e42-c503-78cabc967f49@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d7b2d2d-ef72-7e42-c503-78cabc967f49@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, Oct 11, 2022 at 07:58:11AM +0200, Heinrich Schuchardt wrote: > > > On 10/11/22 02:49, AKASHI Takahiro wrote: > > The commit message is not accurate. > > > > On Fri, Oct 07, 2022 at 04:06:23PM +0200, Heinrich Schuchardt wrote: > > > The CloseProtocol() boot service requires a handle as first argument. > > > Passing the protocol interface is incorrect. > > > > Correct, but > > > > > CloseProtocol() only has an effect if called with a non-zero value for > > > agent_handle. HandleProtocol() uses an opaque agent_handle when invoking > > > OpenProtocol() (currently NULL). > > > > No. OpenProtocol() is called with efi_root as an agent handle. > > So, calling CloseProtocol() is a right thing at the end. > > Typically an agent handle is used to relate to a driver exposing the driver > binding protocol. Why can't we, other than a driver, call HandleProtocol() as a convenient way of accessing an interface? > The root node does not expose the driver binding protocol. So do you mean the current implementation of HandleProtocol() is wrong? > Why would you want to create an open protocol information entry here? To access get_image_info() quickly. > Do you think anything with the code after the patch is wrong? No reason to replace handle_protocol(). Another example is here: efi_load_image_from_path() efi_handle_protocol(device, guid, (void **)&load_file_protocol)); ... efi_close_protocol(device, guid, efi_root, NULL); I believe that this function is anything but a driver. I think using HandleProtocol() (or preferably OpenProtocol()) and CloseProtocol() in pair seems totally sane. -Takahiro Akashi > Best regards > > Heinrich > > > > > > Therefore HandleProtocol() should be > > > avoided. > > > > > > * Replace the LocateHandle() call by efi_search_protocol(). > > > > LocateHandle() -> efi_handle_protocol() > > > > So you could have fixed this way: > > EFI_CALL(efi_close_protocol(handle, ..., &efi_root, NULL); > > > > I preferred to use EFI_CALL() over this file as you can see. > > > > -Takahiro Akashi > > > > > * Remove the CloseProtocol() call. > > > > > > Fixes: 8d99026f0697 ("efi_loader: capsule: support firmware update") > > > Signed-off-by: Heinrich Schuchardt > > > --- > > > lib/efi_loader/efi_capsule.c | 14 ++++++-------- > > > 1 file changed, 6 insertions(+), 8 deletions(-) > > > > > > diff --git a/lib/efi_loader/efi_capsule.c b/lib/efi_loader/efi_capsule.c > > > index b6bd2d6af8..397e393a18 100644 > > > --- a/lib/efi_loader/efi_capsule.c > > > +++ b/lib/efi_loader/efi_capsule.c > > > @@ -159,12 +159,14 @@ efi_fmp_find(efi_guid_t *image_type, u8 image_index, u64 instance, > > > efi_status_t ret; > > > for (i = 0, handle = handles; i < no_handles; i++, handle++) { > > > - ret = EFI_CALL(efi_handle_protocol( > > > - *handle, > > > - &efi_guid_firmware_management_protocol, > > > - (void **)&fmp)); > > > + struct efi_handler *fmp_handler; > > > + > > > + ret = efi_search_protocol( > > > + *handle, &efi_guid_firmware_management_protocol, > > > + &fmp_handler); > > > if (ret != EFI_SUCCESS) > > > continue; > > > + fmp = fmp_handler->protocol_interface; > > > /* get device's image info */ > > > info_size = 0; > > > @@ -215,10 +217,6 @@ efi_fmp_find(efi_guid_t *image_type, u8 image_index, u64 instance, > > > skip: > > > efi_free_pool(package_version_name); > > > free(image_info); > > > - EFI_CALL(efi_close_protocol( > > > - (efi_handle_t)fmp, > > > - &efi_guid_firmware_management_protocol, > > > - NULL, NULL)); > > > if (found) > > > return fmp; > > > } > > > -- > > > 2.37.2 > > >