From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECA87C433FE for ; Tue, 11 Oct 2022 16:22:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 360F184EFE; Tue, 11 Oct 2022 18:22:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="YGqqR/CA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6AC1B8454A; Tue, 11 Oct 2022 18:22:42 +0200 (CEST) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6387D8454A for ; Tue, 11 Oct 2022 18:22:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2a.google.com with SMTP id de14so9262771qvb.5 for ; Tue, 11 Oct 2022 09:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=C9RbvjlbUdeuZDasiIR/ufzBYFBehLHhnT6EIT22Y/M=; b=YGqqR/CA6Q2/xLZ50fnDwiomFnx0FI8VJbsGtasI3yK9K4QQmlUrwbqdco2dU0/bCP DCeUWCCQSGAxMiLtrdbLrvdd3dXLymhWJppNWB5bIJGQm1TSF9C7Uwg8d8Y1yjGig10J QSVXWi7jvUw4HRYr24izl2DTyMyvOEaRdUBGQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C9RbvjlbUdeuZDasiIR/ufzBYFBehLHhnT6EIT22Y/M=; b=EY7TI6k8TSfWsdg15YF+fc9EwwZgBnwjs2z0cLPxyFGQNPT0E9oRNxsacCGBPfr00v O+2EX4ErvwVY57XVNDRSb0jeRkBazM1T6Xasw5tpdMySAPJOHpwRpuLQaD4USeRoGkMP aoCbqwvuUxwjwlp/t2B6YTyB/CluqpVnbMs4vXzgpbDZozGuT+AiTNGjpaWxBr/nb3LS EX55mx7O4hQO3q8OwLnIn4FKkpntY3Dw/OCFERcNKmJoG9v76+ZdhIedp+fxdyhg9Jit taG+UULxk5HdKW00ZLeN/gQqR11c7eeD2IJy6mlX7UFYSAHJWSZcNiIrpCOgfKlT/x8M EQZA== X-Gm-Message-State: ACrzQf2CpTo0aHkPqIjoVLtpaXlM9l9tdTzW29jVz2nvbX5rRtoFmCxp iEdHqvN/yW4yCm7xe6NmwRzYynjiJB3NCw== X-Google-Smtp-Source: AMsMyM7DkxB3NHb/ZzXjsq+g06RlDs8gkdHU2wXek10VOyoczN5hd/vnsgRGbY2sfmHgEb0T8o8BEA== X-Received: by 2002:a0c:e34c:0:b0:4b1:874a:18ad with SMTP id a12-20020a0ce34c000000b004b1874a18admr19334263qvm.53.1665505358094; Tue, 11 Oct 2022 09:22:38 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-9506-5302-f3bb-a137.res6.spectrum.com. [2603:6081:7b00:6400:9506:5302:f3bb:a137]) by smtp.gmail.com with ESMTPSA id j15-20020ac8550f000000b0039a17374294sm4948391qtq.78.2022.10.11.09.22.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 09:22:37 -0700 (PDT) Date: Tue, 11 Oct 2022 12:22:35 -0400 From: Tom Rini To: Simon Glass Cc: u-boot@lists.denx.de, Rasmus Villemoes Subject: Re: [PATCH 2/2] buildman: Add --allow-missing-binaries flag to build with BINMAN_ALLOW_MISSING=1 Message-ID: <20221011162235.GF2020586@bill-the-cat> References: <20221010151831.3376759-1-trini@konsulko.com> <20221010151831.3376759-2-trini@konsulko.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p+/4B2pcxE3X6xU6" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --p+/4B2pcxE3X6xU6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 10, 2022 at 05:48:55PM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Mon, 10 Oct 2022 at 09:18, Tom Rini wrote: > > > > Add a new flag to buildman so that we will in turn pass > > BINMAN_ALLOW_MISSING=3D1 to 'make'. Make use of this flag in CI. > > > > Cc: Rasmus Villemoes > > Cc: Simon Glass > > Signed-off-by: Tom Rini > > --- > > .azure-pipelines.yml | 2 +- > > .gitlab-ci.yml | 6 +++--- > > tools/buildman/builder.py | 5 ++++- > > tools/buildman/builderthread.py | 2 ++ > > tools/buildman/cmdline.py | 3 +++ > > tools/buildman/control.py | 3 ++- > > 6 files changed, 15 insertions(+), 6 deletions(-) > > > > diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml > > index f200b40dbb24..c932c2b3c619 100644 > > --- a/.azure-pipelines.yml > > +++ b/.azure-pipelines.yml > > @@ -553,7 +553,7 @@ stages: > > cat << "EOF" >> build.sh > > if [[ "${BUILDMAN}" !=3D "" ]]; then > > ret=3D0; > > - tools/buildman/buildman -o /tmp -P -E -W ${BUILDMAN} ${O= VERRIDE} || ret=3D$?; > > + tools/buildman/buildman -o /tmp -P -E -W --allow-missing= -binaries ${BUILDMAN} ${OVERRIDE} || ret=3D$?; >=20 > This is fine for CI. I think one of the issues here is we need to agree on the common use cases. I don't think most people use buildman to build, they use make. Of the people that do use buildman, how many aren't already using a wrapper script? I know I always do. Can we also not just deal with setting this flag in ~/.buildman ? Would it Just Work as: [builder] allow-missing-binaries =3D True Or is more code needed? > But having to provide a flag to do build testing seems like the tail > is wagging the dog. Boards should be discouraged to use blobs and we > don't want to make it hard for everyone else (who doesn't have the > blobs) to test whether their patch breaks a build. I'm not sure this ends up being a common case. If someone is build testing for something they can't run test, the error is going to be after whatever they compile-tested was compiled/linked, and if they're testing everything it's via CI. --=20 Tom --p+/4B2pcxE3X6xU6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNFmEsACgkQFHw5/5Y0 tywkJgwAq1FpOdd5ypmUmXL13Qm+OFXD/8MiTJuGdOOSub11eWVPyaWHaTn7hSGz TXoOIw7KczC3tUlAEEWFLW94S4iKpF/wABRfvSHYTrdtkzcEpBfm7ijf3Af2wXN0 tDWudw4KD5shM3FJqWPIMVyVIa6aVKXuCThjMfr6LlTS95oz/ZmhF6Kbw2nbYZGk kZv2nCsRIgPiFzk0jJ2S7UDLeMSYavmw3kIpNsOez7HxN9ZSpUl4BCjxQmAHdsmC mESYT76JG2ZUxfK/mCodxqkMTyVeoOVlSACApdmxlml/gjQ0ZALC0U0FcsyHsblD pMRZy3nXTVFJ93TX71OQRAIEXusdWHkxJ8sdiVIpZ6gUVewod3ZUuSRoAjbU6z1i 04Hlat5dqcPDe/eR+Mcy01KOyfpUUiRM321vypDTJebaxrJUxFt7FWgEYXNJN/Gv RwCpB4iWfq0ZKVQXo018hPs6q27MEO7ui8TxDTp2ts4sUnCdyIoDcGM91LhyKiDs QiTiqmf7 =3YH4 -----END PGP SIGNATURE----- --p+/4B2pcxE3X6xU6--