From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AC01C433FE for ; Wed, 12 Oct 2022 00:11:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 22EC884C4D; Wed, 12 Oct 2022 02:11:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="phWa2VuI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 75E1A84DC0; Wed, 12 Oct 2022 02:11:10 +0200 (CEST) Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5935384BE0 for ; Wed, 12 Oct 2022 02:11:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pf1-x432.google.com with SMTP id i3so5428281pfc.11 for ; Tue, 11 Oct 2022 17:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:from:to:cc:subject:date:message-id:reply-to; bh=Qn591E8UQKt5v7ZGjSNSRXVGj2HnD7DyJ6BoE2ZA0Hc=; b=phWa2VuIv6hvP5uLn5aXKg6nmIsaDn2bxztYawFaI+CS7K/L6c6jYK8MjMzxZM9ici dly50teVaWFVZgvqJIg9pE35Kr+Ol3NKo9zEy3UL1Jm0xfSWsYJIbLRgaciWtBAbyLrp 3XAc/YJnpGNAKReyrBu5CZVQOf3lF1fhKOK+ItVOcU2lKB7NgM/CYSHsKk4jZLBNkc0Y cX5B4ubfjFmodo74t8oAzRxYq7ZconRpMq5gOcPyewf1zlHOIhdzBxtOsmD688/Gf6sL MBj9Uvdmk6LyOMLHJQiFporaQvSOoNa/QItp0LkP6CCgXVvtdMdVtr34m61thJ8GpR2E 1WwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qn591E8UQKt5v7ZGjSNSRXVGj2HnD7DyJ6BoE2ZA0Hc=; b=eywsC8FxmZMPsYPEyuN9dHkZCu4VzESaBm9vm9wyqGumotQoI8HFzt6q5oECkgdCiP AQGj3iTCWV+T/ooM5OJTbEqE4UUiZ3ODOyAa52ViQIht55bVBv/D2YDPzg0dvjy77aMk TsZSIeL9oso4XlAiBP1o2msR3xReym90Zej2JNnVuXj05BphQkdQEWXcjobCS7IcJhNs 2h9NFV7tLoB4ZbIRRlvdFasHIe53ssQV2CvgNBifIu+WdDC5aY1IwvJVC6lIEH57/2cl jJ87qbg3Z+g4RAxGGnSqDn7CGl30mIf33s8klr/QzpuiN2m6pJz+IxDpoyeLxfFxciQC YbZw== X-Gm-Message-State: ACrzQf3oTmUO3//u7YiIIlhRAGbvYFHE5JJLC1eB1FKP160tWqPTOJsX Rrd9Rz9tjpGpYoTXQH96aPAPig== X-Google-Smtp-Source: AMsMyM4VD2LdaBJZYWd5xqUoGiHQLkrnHxeDu7Achl8U2sxj5+3rba9Vj2MlRhIJHcA2TXlHLe7Szw== X-Received: by 2002:a05:6a00:2906:b0:52a:bc7f:f801 with SMTP id cg6-20020a056a00290600b0052abc7ff801mr28341078pfb.49.1665533465567; Tue, 11 Oct 2022 17:11:05 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:886e:2a2f:de1a:53f4]) by smtp.gmail.com with ESMTPSA id b12-20020a62a10c000000b0056246403534sm9490579pff.88.2022.10.11.17.11.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 17:11:04 -0700 (PDT) Date: Wed, 12 Oct 2022 09:11:01 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: Ilias Apalodimas , u-boot@lists.denx.de Subject: Re: [PATCH 1/1] efi_loader: CloseProtocol in efi_fmp_find Message-ID: <20221012001101.GB49651@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , Ilias Apalodimas , u-boot@lists.denx.de References: <20221007140623.167909-1-heinrich.schuchardt@canonical.com> <20221011004939.GA39168@laputa> <7d7b2d2d-ef72-7e42-c503-78cabc967f49@canonical.com> <20221011073541.GB39168@laputa> <41bd6e81-f5df-7afc-f2f5-9014b1506692@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <41bd6e81-f5df-7afc-f2f5-9014b1506692@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, Oct 11, 2022 at 01:12:18PM +0200, Heinrich Schuchardt wrote: > > > On 10/11/22 13:08, Heinrich Schuchardt wrote: > > > > > > On 10/11/22 09:35, AKASHI Takahiro wrote: > > > On Tue, Oct 11, 2022 at 07:58:11AM +0200, Heinrich Schuchardt wrote: > > > > > > > > > > > > On 10/11/22 02:49, AKASHI Takahiro wrote: > > > > > The commit message is not accurate. > > > > > > > > > > On Fri, Oct 07, 2022 at 04:06:23PM +0200, Heinrich Schuchardt wrote: > > > > > > The CloseProtocol() boot service requires a handle as first argument. > > > > > > Passing the protocol interface is incorrect. > > > > > > > > > > Correct, but > > > > > > > > > > > CloseProtocol() only has an effect if called with a non-zero value for > > > > > > agent_handle. HandleProtocol() uses an opaque > > > > > > agent_handle when invoking > > > > > > OpenProtocol() (currently NULL). > > > > > > > > > > No. OpenProtocol() is called with efi_root as an agent handle. > > > > > So, calling CloseProtocol() is a right thing at the end. > > > > > > > > Typically an agent handle is used to relate to a driver exposing > > > > the driver > > > > binding protocol. > > > > > > Why can't we, other than a driver, call HandleProtocol() > > > as a convenient way of accessing an interface? > > > > The description of HandleProtocol() clearly says that it is deprecated. > > > > The assumption that the UEFI specification makes in it is example code > > that you never be able to close a protocol opened with HandleProtocol. > > > > After the first usage of handle protocol the open protocol information > > with the opaque agent handle will block the protocol interface from ever > > being removed by the driver exposing it. > > > > > > > > > The root node does not expose the driver binding protocol. > > > > > > So do you mean the current implementation of HandleProtocol() is wrong? > > > > Yes. If you ever install a boot time driver, it might remove a protocol > > interface which is actually still in use. > > Since 755d42d4209e ("efi_loader: correct HandleProtocol()") we set agent > handle = efi_root in the implementation of HandleProtocol(). So this part is > ok. That is why I said using HandleProtocl() is valid and that your commit message is not accurate. -Takahiro Akashi > Best regards > > Heirnich > > > > > > > > > > Why would you want to create an open protocol information entry here? > > > > > > To access get_image_info() quickly. > > > > This is not related to an open protocol information (see the UEFI spec > > description of OpenProtocolInformation()). > > > > Best regards > > > > Heinrich > > > > > > > > > Do you think anything with the code after the patch is wrong? > > > > > > No reason to replace handle_protocol(). > > > > > > Another example is here: > > > efi_load_image_from_path() > > >      efi_handle_protocol(device, guid, (void **)&load_file_protocol)); > > >      ... > > >      efi_close_protocol(device, guid, efi_root, NULL); > > > > > > I believe that this function is anything but a driver. > > > I think using HandleProtocol() (or preferably OpenProtocol()) and > > > CloseProtocol() > > > in pair seems totally sane. > > > > > > -Takahiro Akashi > > > > > > > > > > > > > Best regards > > > > > > > > Heinrich > > > > > > > > > > > > > > > Therefore HandleProtocol() should be > > > > > > avoided. > > > > > > > > > > > > * Replace the LocateHandle() call by efi_search_protocol(). > > > > > > > > > > LocateHandle() -> efi_handle_protocol() > > > > > > > > > > So you could have fixed this way: > > > > >       EFI_CALL(efi_close_protocol(handle, ..., &efi_root, NULL); > > > > > > > > > > I preferred to use EFI_CALL() over this file as you can see. > > > > > > > > > > -Takahiro Akashi > > > > > > > > > > > * Remove the CloseProtocol() call. > > > > > > > > > > > > Fixes: 8d99026f0697 ("efi_loader: capsule: support firmware update") > > > > > > Signed-off-by: Heinrich Schuchardt > > > > > > --- > > > > > >    lib/efi_loader/efi_capsule.c | 14 ++++++-------- > > > > > >    1 file changed, 6 insertions(+), 8 deletions(-) > > > > > > > > > > > > diff --git a/lib/efi_loader/efi_capsule.c > > > > > > b/lib/efi_loader/efi_capsule.c > > > > > > index b6bd2d6af8..397e393a18 100644 > > > > > > --- a/lib/efi_loader/efi_capsule.c > > > > > > +++ b/lib/efi_loader/efi_capsule.c > > > > > > @@ -159,12 +159,14 @@ efi_fmp_find(efi_guid_t > > > > > > *image_type, u8 image_index, u64 instance, > > > > > >        efi_status_t ret; > > > > > >        for (i = 0, handle = handles; i < no_handles; i++, handle++) { > > > > > > -        ret = EFI_CALL(efi_handle_protocol( > > > > > > -                *handle, > > > > > > -                &efi_guid_firmware_management_protocol, > > > > > > -                (void **)&fmp)); > > > > > > +        struct efi_handler *fmp_handler; > > > > > > + > > > > > > +        ret = efi_search_protocol( > > > > > > +                *handle, &efi_guid_firmware_management_protocol, > > > > > > +                &fmp_handler); > > > > > >            if (ret != EFI_SUCCESS) > > > > > >                continue; > > > > > > +        fmp = fmp_handler->protocol_interface; > > > > > >            /* get device's image info */ > > > > > >            info_size = 0; > > > > > > @@ -215,10 +217,6 @@ efi_fmp_find(efi_guid_t > > > > > > *image_type, u8 image_index, u64 instance, > > > > > >    skip: > > > > > >            efi_free_pool(package_version_name); > > > > > >            free(image_info); > > > > > > -        EFI_CALL(efi_close_protocol( > > > > > > -                (efi_handle_t)fmp, > > > > > > -                &efi_guid_firmware_management_protocol, > > > > > > -                NULL, NULL)); > > > > > >            if (found) > > > > > >                return fmp; > > > > > >        } > > > > > > -- > > > > > > 2.37.2 > > > > > >