From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Bin Meng <bmeng.cn@gmail.com>,
Christian Melki <christian.melki@t2data.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
U-Boot Mailing List <u-boot@lists.denx.de>,
Alexander Graf <agraf@csgraf.de>
Subject: Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model
Date: Fri, 14 Oct 2022 11:39:48 -0400 [thread overview]
Message-ID: <20221014153948.GW2020586@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ1HuhE+yEHDZbrE43J8PoQQ-dVeJtykXr2SaU+NN-kv+g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2606 bytes --]
On Fri, Oct 14, 2022 at 09:36:46AM -0600, Simon Glass wrote:
> Hi Jan,
>
> On Fri, 14 Oct 2022 at 09:35, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> >
> > On 14.10.22 17:33, Simon Glass wrote:
> > > Hi Tom,
> > >
> > > On Fri, 14 Oct 2022 at 07:13, Tom Rini <trini@konsulko.com> wrote:
> > >>
> > >> On Fri, Oct 14, 2022 at 01:51:54PM +0200, Jan Kiszka wrote:
> > >>> On 21.10.21 01:34, Heinrich Schuchardt wrote:
> > >>>> On 9/25/21 2:30 AM, Simon Glass wrote:
> > >>>>> This code should never have been added as it builds a new feature on top
> > >>>>> of legacy code. This has already been improved with the dependency on
> > >>>>> BLK.
> > >>>>>
> > >>>>> Add a dependency on DM_ETH also, to avoid needing to deal with this old
> > >>>>> code.
> > >>>>>
> > >>>>> Boards which want EFI_LOADER should migrate to driver model first.
> > >>>>>
> > >>>>> Note this patch is included to resolve the following build error:
> > >>>>>
> > >>>>> lib/efi_loader/efi_runtime.c:680:16: error: ‘CONFIG_SYS_TEXT_BASE’
> > >>>>> undeclared (first use in this function); did you mean
> > >>>>> ‘CONFIG_SYS_SRAM_BASE’?
> > >>>>> 680 | ulong base = CONFIG_SYS_TEXT_BASE;
> > >>>>> | ^~~~~~~~~~~~~~~~~~~~
> > >>>>> | CONFIG_SYS_SRAM_BASE
> > >>>>>
> > >>>>> Signed-off-by: Simon Glass <sjg@chromium.org>
> > >>>>
> > >>>> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > >>>>
> > >>>
> > >>> How to deal with boards that need CONFIG_NET but do not actually
> > >>> implement any driver (yet)? This now broke UEFI for the IOT2050 which
> > >>> needs NET for network-related device tree setup (see also [1]) and
> > >>> enforces a local hack for us.
> > >>
> > >> Yes, looking at the patch, this should probably use NETDEVICES and not
> > >> NET as the test? Would that fix your problem, Jan?
> > >
> > > But that selects DM_ETH. You can still enable DM_ETH when there are no
> > > devices, so I'm not sure what the problem is. Can you post an error?
> > >
> > > Things should be migrated to DM_ETH by now (end of 2020).
> > >
> >
> > I am enable DM_ETH now at board-level, just to make EFI_LOADER happy,
> > but that feels wrong.
>
> I agree, but I wonder if this might need some code refactoring.
> Perhaps EFI_LOADER_NET needs to be created, net functionality can be
> disabled?
I think we should be able to leverage existing flags already for this
and not need a new one. The issue is that CONFIG_NET does not mean "we
have network devices" but CONFIG_NETDEVICES does.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-10-14 15:39 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 0:30 [PATCH v2 00/39] efi: Improvements to U-Boot running on top of UEFI Simon Glass
2021-09-25 0:30 ` [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model Simon Glass
2021-10-20 23:34 ` Heinrich Schuchardt
2022-10-14 11:51 ` Jan Kiszka
2022-10-14 13:13 ` Tom Rini
2022-10-14 15:33 ` Simon Glass
2022-10-14 15:34 ` Jan Kiszka
2022-10-14 15:36 ` Simon Glass
2022-10-14 15:39 ` Tom Rini [this message]
2022-10-14 15:47 ` Jan Kiszka
2022-10-14 15:58 ` Tom Rini
2022-10-14 15:10 ` Heinrich Schuchardt
2022-10-14 15:20 ` Tom Rini
2022-10-14 15:27 ` Jan Kiszka
2022-10-14 15:34 ` Tom Rini
2022-10-14 15:35 ` Jan Kiszka
2022-10-14 15:38 ` Tom Rini
2022-10-14 15:25 ` Jan Kiszka
2021-09-25 0:30 ` [PATCH v2 02/39] efi: Add a separate maintainer entry for the app Simon Glass
2021-10-18 16:36 ` Heinrich Schuchardt
2021-09-25 0:30 ` [PATCH v2 03/39] x86: Keep symbol information in u-boot ELF file Simon Glass
2021-09-25 0:30 ` [PATCH v2 04/39] x86: Create a new header for EFI Simon Glass
2021-10-18 17:00 ` Heinrich Schuchardt
2021-09-25 0:30 ` [PATCH v2 05/39] x86: Show some EFI info with the bdinfo command Simon Glass
2021-10-18 17:10 ` Heinrich Schuchardt
2021-10-26 3:29 ` Simon Glass
2021-09-25 0:30 ` [PATCH v2 06/39] x86: Tidy up global_data pointer for 64-bit Simon Glass
2021-10-18 17:15 ` Heinrich Schuchardt
2021-10-26 3:29 ` Simon Glass
2021-09-25 0:30 ` [PATCH v2 07/39] efi: Add a script for building and testing U-Boot on UEFI Simon Glass
2021-10-18 17:30 ` Heinrich Schuchardt
2021-10-18 18:12 ` Simon Glass
2021-10-25 19:35 ` Heinrich Schuchardt
2021-10-26 3:29 ` Simon Glass
2021-09-25 0:30 ` [PATCH v2 08/39] efi: Enable DM_ETH for the app Simon Glass
2021-09-25 0:30 ` [PATCH v2 09/39] efi: Drop the OF_EMBED warning for EFI Simon Glass
2021-10-23 11:37 ` Heinrich Schuchardt
2021-10-26 3:29 ` Simon Glass
2021-09-25 0:30 ` [PATCH v2 10/39] x86: Create a 32/64-bit selection for the app Simon Glass
2021-10-23 11:41 ` Heinrich Schuchardt
2021-09-25 0:30 ` [PATCH v2 11/39] efi: Create a 64-bit app Simon Glass
2021-09-25 0:30 ` [PATCH v2 12/39] x86: Don't duplicate global_ptr in 64-bit EFI app Simon Glass
2021-09-25 0:30 ` [PATCH v2 13/39] efi: Add a way to obtain boot services in the app Simon Glass
2021-09-25 0:30 ` [PATCH v2 14/39] efi: Add video support to " Simon Glass
2021-09-25 0:30 ` [PATCH v2 15/39] efi: Add EFI uclass for media Simon Glass
2021-10-23 12:26 ` Heinrich Schuchardt
2021-10-26 3:29 ` Simon Glass
2021-09-25 0:30 ` [PATCH v2 16/39] efi: Add a media/block driver for EFI block devices Simon Glass
2021-09-25 0:30 ` [PATCH v2 17/39] efi: Locate all block devices in the app Simon Glass
2021-09-25 0:30 ` [PATCH v2 18/39] patman: Use a ValueError exception if tools.Run() fails Simon Glass
2021-09-25 0:30 ` [PATCH v2 19/39] binman: Report an error if test files fail to compile Simon Glass
2021-09-25 0:30 ` [PATCH v2 20/39] binman: Support reading the offset of an ELF-file symbol Simon Glass
2021-09-25 0:30 ` [PATCH v2 21/39] binman: Allow timeout to occur in the image or its section Simon Glass
2021-09-25 0:30 ` [PATCH v2 22/39] binman: Tidy up comments on _DoTestFile() Simon Glass
2021-09-25 0:30 ` [PATCH v2 23/39] binman: Support updating the dtb in an ELF file Simon Glass
2021-09-25 0:30 ` [PATCH v2 24/39] efi: serial: Support arrow keys Simon Glass
2021-10-18 16:55 ` Heinrich Schuchardt
2021-10-26 3:29 ` Simon Glass
2021-09-25 0:30 ` [PATCH v2 25/39] bloblist: Support allocating the bloblist Simon Glass
2021-09-25 0:30 ` [PATCH v2 26/39] x86: Allow booting a kernel from the EFI app Simon Glass
2021-09-25 0:30 ` [PATCH v2 27/39] x86: Don't process the kernel command line unless enabled Simon Glass
2021-09-25 0:30 ` [PATCH v2 28/39] x86: efi: Add room for the binman definition in the dtb Simon Glass
2021-09-25 0:30 ` [PATCH v2 29/39] efi: Add comments to struct efi_priv Simon Glass
2021-10-23 11:28 ` Heinrich Schuchardt
2021-09-25 0:30 ` [PATCH v2 30/39] efi: Fix ll_boot_init() operation with the app Simon Glass
2021-09-25 0:30 ` [PATCH v2 32/39] efi: Share struct efi_priv between the app and stub code Simon Glass
2021-09-25 0:30 ` [PATCH v2 33/39] efi: Move exit_boot_services into a function Simon Glass
2021-09-25 0:30 ` [PATCH v2 34/39] efi: Check for failure when initing the app Simon Glass
2021-09-25 0:30 ` [PATCH v2 35/39] efi: Mention that efi_info_get() is only used in the stub Simon Glass
2021-09-25 0:30 ` [PATCH v2 36/39] efi: Show when allocated pages are used Simon Glass
2021-09-25 0:30 ` [PATCH v2 37/39] efi: Allow easy selection of serial-only operation Simon Glass
2021-09-25 0:30 ` [PATCH v2 38/39] efi: Update efi_get_next_mem_desc() to avoid needing a map Simon Glass
2021-09-25 0:30 ` [PATCH v2 39/39] efi: Support the efi command in the app Simon Glass
2021-10-18 15:25 ` [PATCH v2 00/39] efi: Improvements to U-Boot running on top of UEFI Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014153948.GW2020586@bill-the-cat \
--to=trini@konsulko.com \
--cc=agraf@csgraf.de \
--cc=bmeng.cn@gmail.com \
--cc=christian.melki@t2data.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox