From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7A63ECAAA1 for ; Mon, 24 Oct 2022 13:54:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C133D83E48; Mon, 24 Oct 2022 15:54:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1666619675; bh=HZJiYPG1ar8hq7FkhYMZarf8L82kqy3IQ8kZvfsLZLM=; h=From:To:Subject:In-reply-to:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=D+15i1HZbchYptljGSccPHQxAEUUWC7myIFidbslTXCPZ6L+0TnETpQDWOLAsgnjd oEf5KjTwJ2B3nfAUqHrTcdYDUzZVrey8A911MQopU4C6kpgGRqxuLJtRLqG4R9DBgP 8kFxOylzGn9wn3FcSW29WfnqGPFQ7HlL3Xm6oA65KhqMPdtdoBpfeN1IJGw3xyqjCh ZOmMqzni/EJPspu6uzx5yi6U8uwwmeUDU3E3mNNG9vNsVAORSFGdNPQHp2wWhmh7rU glLNqRchnDm8RhvFEAYtC5cqSXx0Uayp9/8XHIbUdVnZT6SZCbxb/u+n2eeEl6P5ph asUJmkrHYVEXw== Received: by phobos.denx.de (Postfix, from userid 109) id 1434181E0F; Mon, 24 Oct 2022 15:54:22 +0200 (CEST) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 32D25806D3 for ; Mon, 24 Oct 2022 15:54:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sbabic@denx.de Received: from frontend03.mail.m-online.net (unknown [192.168.6.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4MwxQ26mgYz1r4pQ; Mon, 24 Oct 2022 15:54:18 +0200 (CEST) Received: from localhost (dynscan3.mnet-online.de [192.168.6.84]) by mail.m-online.net (Postfix) with ESMTP id 4MwxQ26X4bz1qqlR; Mon, 24 Oct 2022 15:54:18 +0200 (CEST) X-Amavis-Alert: BAD HEADER SECTION, Missing required header field: "Date" Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new, port 10024) with ESMTP id aVPlo52K5YSj; Mon, 24 Oct 2022 15:54:18 +0200 (CEST) Received: from papero (host-88-217-136-221.customer.m-online.net [88.217.136.221]) by mail.mnet-online.de (Postfix) with ESMTP; Mon, 24 Oct 2022 15:54:18 +0200 (CEST) From: sbabic@denx.de X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 1686877 X-Patchwork-Delegate: sbabic@denx.de To: Rasmus Villemoes ,u-boot@lists.denx.de Subject: [PATCH] imx8m: fix reading of DDR4 MR registers [again] In-reply-to: <20221006125650.1666672-1-rasmus.villemoes@prevas.dk> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Message-Id: <20221024135422.1434181E0F@phobos.denx.de> Date: Mon, 24 Oct 2022 15:54:19 +0200 (CEST) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean > Commit 290ffe5788 (imx8m: fix reading of DDR4 MR registers) lifted a > private definition of lpddr4_mr_read() from imx8mm-cl-iot-gate board > code to drivers/ddr/imx/imx8m/ddrphy_utils.c, because that version > actually seems to work in practice. > However, commit 99c7cc58e1 (ddr: imx: Add i.MX9 DDR controller driver) > reintroduced the broken version in drivers/ddr/imx/imx8m/ddr_init.c, > copied most of the rest of ddrphy_utils.c to > drivers/ddr/imx/phy/ddrphy_utils.c, and stopped building > drivers/ddr/imx/imx8m/ddrphy_utils.c [and that file was then finally > completely removed with 7e9bd84883 (imx8m: ddrphy_utils: Remove unused > file)]. > I assume this must have broken the imx8mm-cl-iot-gate board, at least > those that have not had their eeprom programmed with the proper > information. It certainly did break our out-of-tree board which always > reads back the ID register and uses that for a sanity check. > So apply the fix from 290ffe5788 once again. > Fixes: 99c7cc58e1 (ddr: imx: Add i.MX9 DDR controller driver) > Signed-off-by: Rasmus Villemoes > Reviewed-by: Fabio Estevam Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================