From: Conor Dooley <conor.dooley@microchip.com>
To: Rick Chen <rick@andestech.com>, Leo <ycliang@andestech.com>,
"Lukasz Majewski" <lukma@denx.de>,
Sean Anderson <seanga2@gmail.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
Padmarao Begari <padmarao.begari@microchip.com>,
<u-boot@lists.denx.de>
Subject: [PATCH v1 6/6] riscv: dts: fix the mpfs's reference clock frequency
Date: Tue, 25 Oct 2022 08:58:49 +0100 [thread overview]
Message-ID: <20221025075848.110754-7-conor.dooley@microchip.com> (raw)
In-Reply-To: <20221025075848.110754-1-conor.dooley@microchip.com>
The initial devicetree for PolarFire SoC incorrectly created a fixed
frequency clock in the devicetree to represent the msspll, but the
msspll is not a fixed frequency clock. The actual reference clock on a
board is either 125 or 100 MHz, 125 MHz in the case of the icicle kit.
Swap the incorrect representation of the msspll out for the actual
reference clock.
Fixes: dd4ee416a6 ("riscv: dts: Add device tree for Microchip Icicle Kit")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
arch/riscv/dts/microchip-mpfs-icicle-kit.dts | 4 ++++
arch/riscv/dts/microchip-mpfs.dtsi | 14 ++++++--------
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/arch/riscv/dts/microchip-mpfs-icicle-kit.dts b/arch/riscv/dts/microchip-mpfs-icicle-kit.dts
index e1fbedc507..7d87b181db 100644
--- a/arch/riscv/dts/microchip-mpfs-icicle-kit.dts
+++ b/arch/riscv/dts/microchip-mpfs-icicle-kit.dts
@@ -53,6 +53,10 @@
};
};
+&refclk {
+ clock-frequency = <125000000>;
+};
+
&uart1 {
status = "okay";
};
diff --git a/arch/riscv/dts/microchip-mpfs.dtsi b/arch/riscv/dts/microchip-mpfs.dtsi
index 4f449a3a93..891dd0918b 100644
--- a/arch/riscv/dts/microchip-mpfs.dtsi
+++ b/arch/riscv/dts/microchip-mpfs.dtsi
@@ -170,6 +170,11 @@
};
};
+ refclk: refclk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ };
+
soc {
#address-cells = <2>;
#size-cells = <2>;
@@ -225,16 +230,9 @@
&cpu4_intc HART_INT_M_EXT &cpu4_intc HART_INT_S_EXT>;
};
- refclk: refclk {
- compatible = "fixed-clock";
- #clock-cells = <0>;
- clock-frequency = <600000000>;
- clock-output-names = "msspllclk";
- };
-
clkcfg: clkcfg@20002000 {
compatible = "microchip,mpfs-clkcfg";
- reg = <0x0 0x20002000 0x0 0x1000>;
+ reg = <0x0 0x20002000 0x0 0x1000>, <0x0 0x3E001000 0x0 0x1000>;
reg-names = "mss_sysreg";
clocks = <&refclk>;
#clock-cells = <1>;
--
2.38.0
next prev parent reply other threads:[~2022-10-25 7:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 7:58 [PATCH v1 0/6] clk: microchip: mpfs: incremental fixes Conor Dooley
2022-10-25 7:58 ` [PATCH v1 1/6] dt-bindings: clk: add missing clk ids for microchip mpfs Conor Dooley
2022-11-02 11:19 ` Leo Liang
2022-11-02 13:20 ` Padmarao.Begari
2022-10-25 7:58 ` [PATCH v1 2/6] clk: microchip: mpfs: convert parent rate acquistion to get_get_rate() Conor Dooley
2022-11-02 11:20 ` Leo Liang
2022-11-02 13:20 ` Padmarao.Begari
2022-11-02 16:41 ` Conor Dooley
2022-10-25 7:58 ` [PATCH v1 3/6] clk: microchip: mpfs: fix reference clock handling Conor Dooley
2022-11-02 11:21 ` Leo Liang
2022-11-02 13:20 ` Padmarao.Begari
2022-10-25 7:58 ` [PATCH v1 4/6] clk: microchip: mpfs: fix periph clk parentage Conor Dooley
2022-11-02 11:21 ` Leo Liang
2022-11-02 13:20 ` Padmarao.Begari
2022-10-25 7:58 ` [PATCH v1 5/6] clk: microchip: mpfs: fix criticality of peripheral clocks Conor Dooley
2022-11-02 11:22 ` Leo Liang
2022-11-02 13:20 ` Padmarao.Begari
2022-10-25 7:58 ` Conor Dooley [this message]
2022-11-02 11:22 ` [PATCH v1 6/6] riscv: dts: fix the mpfs's reference clock frequency Leo Liang
2022-11-02 13:21 ` Padmarao.Begari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221025075848.110754-7-conor.dooley@microchip.com \
--to=conor.dooley@microchip.com \
--cc=lukma@denx.de \
--cc=padmarao.begari@microchip.com \
--cc=rick@andestech.com \
--cc=seanga2@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox