From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9846C04A95 for ; Tue, 25 Oct 2022 08:50:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CD3C7848FB; Tue, 25 Oct 2022 10:50:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GLRRPUi6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1FF3784C47; Tue, 25 Oct 2022 10:50:41 +0200 (CEST) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B044C83F61 for ; Tue, 25 Oct 2022 10:50:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=oliver.graute@gmail.com Received: by mail-ej1-x62c.google.com with SMTP id bj12so10632969ejb.13 for ; Tue, 25 Oct 2022 01:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=dftziBq5JB6d6qmqMDNzNFLQQXu8QcQKqgt6ZhKbAB4=; b=GLRRPUi6DvZtpprIh/2L9Znj6pJQAcK++b+UOjiEzWAmW5jZU/trFfmL6VaoVgO/8X 6xv42U+AgS4cnnZTSm9rTZyRiz9D9LLNuSv7hTd8Vq/nxqC1v7ecgDNc7csHIBPoU/lB 5F8uKQqGED2VYRzO+ssVSz+y41c7EQFOg+m8LdN4OaYXfXubaMCcGeJa8kIm0qH8FLEE p7vi0PNnI55sbE0Hw7x+Oqo9nuZ60DPs0N+6LxdmwsNUYBkIsr2UsShLeMHKmwEHOE4F phuI3rVR1eg2viQu5tV6Y+sztqfXU+f7uPjBHgUESr2LvnZXrh4iQQ/piu7KwkLukyqB Pc9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dftziBq5JB6d6qmqMDNzNFLQQXu8QcQKqgt6ZhKbAB4=; b=2O10isjf6eNFuh1GAmCYNE+NtfYuS8p2C5jkCM/e/qm0BZQTY8mj3vsLg/F4x8NWfD i1SWm78OPt9aMuVMVw9UvsoTTBABRK/PAeX1hPV4/q/IKv2MD/YvN6uBdQmLpdhVj17a rTwSS2npb+9uzxutw2pop6i0V5jAvk1S2ZJZpyKxDUMc2kZz+P4FefXLlolIfxXLBizh a8uWF8yK7ufQTlc7lPmjtDrNlvA2v+JYN42PeaOswVDrcdZJsmdVDf0IqkuWu3gwHSZs 2zfrZhyH9d01wiXaj0v5/LG3tILrL/mPiczF/vUrQGSBR+hKB+YZS6qTbPRGid/WV06L Q4uw== X-Gm-Message-State: ACrzQf0Zfx/+JYTWMQIhPNGaOiVdpeu+AJ7rSSDLk0C15EgYuUIgW55P NGrphm0OYYMyObSWWi08JOM= X-Google-Smtp-Source: AMsMyM6IsytR+MCJ67XDbFTUV5N+SHhDTp1OC3QIrZWhDlSkJ40uyCAnOth8rDGRge/EwJHgbQ/hPw== X-Received: by 2002:a17:906:1ec5:b0:78d:b3d1:183b with SMTP id m5-20020a1709061ec500b0078db3d1183bmr31190852ejj.709.1666687836162; Tue, 25 Oct 2022 01:50:36 -0700 (PDT) Received: from localhost ([90.187.74.145]) by smtp.gmail.com with ESMTPSA id h10-20020a170906110a00b007815ca7ae57sm1005694eja.212.2022.10.25.01.50.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Oct 2022 01:50:35 -0700 (PDT) Date: Tue, 25 Oct 2022 10:50:19 +0200 From: Oliver Graute To: Stefano Babic Cc: Fabio Estevam , trini@konsulko.com, "NXP i.MX U-Boot Team" , Peng Fan , u-boot@lists.denx.de Subject: Re: [PATCH v3] imx: imx8qm: cgtqmx8: switch to binman Message-ID: <20221025085018.GB19855@optiplex> Mail-Followup-To: Stefano Babic , Fabio Estevam , trini@konsulko.com, "NXP i.MX U-Boot Team" , Peng Fan , u-boot@lists.denx.de References: <20220503104819.24694-1-oliver.graute@kococonnector.com> <1074825c-ac02-8cc8-604d-bd465cdd40d8@denx.de> <20221024115914.GA19855@optiplex> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 24/10/22, Stefano Babic wrote: > On 24.10.22 13:59, Oliver Graute wrote: > > On 24/10/22, Stefano Babic wrote: > > > On 24.10.22 13:37, Fabio Estevam wrote: > > > > Hi Stefano and Oliver, > > > > > > > > On Tue, May 3, 2022 at 7:49 AM Oliver Graute > > > > wrote: > > > > > > > > > > Switch to use binman to pack images > > > > > > > > > > Signed-off-by: Oliver Graute > > > > > Reviewed-by: Fabio Estevam > > > > > Reviewed-by: Simon Glass > > > > > --- > > > > > Changes for v3 > > > > > -added Reviewed-by > > > > > -rebased on master > > > > > > > > > > arch/arm/dts/imx8qm-cgtqmx8.dts | 1 + > > > > > arch/arm/mach-imx/imx8/Kconfig | 1 + > > > > > board/congatec/cgtqmx8/imximage.cfg | 4 ++-- > > > > > configs/cgtqmx8_defconfig | 2 +- > > > > > doc/board/congatec/cgtqmx8.rst | 3 +-- > > > > > 5 files changed, 6 insertions(+), 5 deletions(-) > > > > > > > > Just realized that v3 does not include imx8qm-u-boot.dtsi and this breaks CI. > > > > > > > > > > Right - as well as V4, this is what I tried to merge and breaks. I have drop > > > it. > > > > > > > The previous v2 did include it: > > > > https://patchwork.ozlabs.org/project/uboot/patch/20220221090139.10066-1-oliver.graute@kococonnector.com/ > > > > > > Thanks for noting this - Oliver, can you check and repost a V5, then ? > > > > The arch/arm/dts/imx8qm-u-boot.dtsi is applied on the binman Patch for > > "PATCH v3 imx: imx8qm-rom7720: switch to binman" > > > > So if you first apply the patches for the imx8qm-rom7720 Board it should work. > > > Ok, thanks for tipp - I apply both and will test again I saw the CI Pipeline failing. Perhaps the reason is a missing CONFIG_FIT_EXTERNAL_OFFSET? +++ b/configs/cgtqmx8_defconfig @@ -20,6 +20,7 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000 CONFIG_REMAKE_ELF=y CONFIG_FIT=y +CONFIG_FIT_EXTERNAL_OFFSET=0x3000 CONFIG_SPL_LOAD_FIT=y # CONFIG_USE_SPL_FIT_GENERATOR is not set Can you confirm? Best regards, Oliver