From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F8B6C38A2D for ; Tue, 25 Oct 2022 13:54:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 61CAD84DBF; Tue, 25 Oct 2022 15:54:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="K4TW3Dot"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0ABFA84D44; Tue, 25 Oct 2022 15:54:13 +0200 (CEST) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0B9BD84E51 for ; Tue, 25 Oct 2022 15:53:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=oliver.graute@gmail.com Received: by mail-ed1-x536.google.com with SMTP id y12so16045985edc.9 for ; Tue, 25 Oct 2022 06:53:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=h+1knyAF5s1kjLr6yE2wLDguOtBi57HzmmYQj3DA9LA=; b=K4TW3Dot91q7PtoHB7GvakcFA5w9tqCIn7Na/ufghG7OSnyjiev0E/pV0+PVDtYyra GuoZV/7sYUXx6zS82BlGI2Pk7+DCVOsrZ7kqor9Ce+iqLdl8cp0urlCgEY6GaXIrECam y0A7ChUXAYVDsPGK2INj0ip7yRjThgNyV/ZAGzKiariO3Ld5P8qK+Udhg4JZqZ2xRJIb ZAud/+smiFrkfXX80B/+5TYsuiboss5EpXujwUEArxzIx6RXfNZvr09VWDvW15Zbk2Ka wNUXfkGmDlbtAUgGma4SbHR5xURbXzeJjyw9gY5moVmllPCKuMxbiNkp8JdmEiP4wd8U j7WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h+1knyAF5s1kjLr6yE2wLDguOtBi57HzmmYQj3DA9LA=; b=KtJBZItyZsFbUD+YdipFXYZZE1Rv3IJe4AMPbYF/iFsQXX15DuWQvt8dmF+Sw9TDPu VaWtZX7x+I3ajWJFuPf+5PT79wytVPFnSr8AMWgq9593L/K2W25uOQnlnjlLT7t3LMRO utxdVkxqfAQW1TBbazVOVEbn0hqgqDb24MFPrkMARL1uiUUn6Q0eIfHgMiq00mtslkp9 P0dXuHrj9k4Xy/s1L9ITM3jNU3xtbW4/ACKj3ZZtXlGREPKwbEVIelh+WwVdh73YKcNQ JLrXbHmUGJ+MJylcyynFRteqx4uUP27mOzMRvTgp2HZJ4D/YCMJIkCrJLmLPd+GgCeK8 jbbg== X-Gm-Message-State: ACrzQf23rjPo3n2kkWiOAuybi51fIrwgU2hVMRTS/ryWb0KO1fyzo5IZ hxayHxKmH8Kl+OT47CRzniHW4BfJsFMQhw== X-Google-Smtp-Source: AMsMyM5cpBybCdS8n8QZ+QL+nCpFYBwGHqIWNlDfqrNw9DYxZZZSh09+BK2AQpgHnAk5+YR5LRFCuw== X-Received: by 2002:aa7:c054:0:b0:453:98c6:f6c4 with SMTP id k20-20020aa7c054000000b0045398c6f6c4mr35638900edo.2.1666706032252; Tue, 25 Oct 2022 06:53:52 -0700 (PDT) Received: from localhost (business-90-187-74-145.pool2.vodafone-ip.de. [90.187.74.145]) by smtp.gmail.com with ESMTPSA id t23-20020a170906179700b00782cd82db09sm1434799eje.106.2022.10.25.06.53.51 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Oct 2022 06:53:51 -0700 (PDT) Date: Tue, 25 Oct 2022 15:53:42 +0200 From: Oliver Graute To: Stefano Babic Cc: Fabio Estevam , trini@konsulko.com, "NXP i.MX U-Boot Team" , Peng Fan , u-boot@lists.denx.de Subject: Re: [PATCH v3] imx: imx8qm: cgtqmx8: switch to binman Message-ID: <20221025135342.GC19855@optiplex> Mail-Followup-To: Stefano Babic , Fabio Estevam , trini@konsulko.com, "NXP i.MX U-Boot Team" , Peng Fan , u-boot@lists.denx.de References: <20220503104819.24694-1-oliver.graute@kococonnector.com> <1074825c-ac02-8cc8-604d-bd465cdd40d8@denx.de> <20221024115914.GA19855@optiplex> <20221025085018.GB19855@optiplex> <4bfa6e49-4e2d-0b04-355f-19ed058bef7e@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4bfa6e49-4e2d-0b04-355f-19ed058bef7e@denx.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 25/10/22, Stefano Babic wrote: > On 25.10.22 10:50, Oliver Graute wrote: > > On 24/10/22, Stefano Babic wrote: > > > On 24.10.22 13:59, Oliver Graute wrote: > > > > On 24/10/22, Stefano Babic wrote: > > > > > On 24.10.22 13:37, Fabio Estevam wrote: > > > > > > Hi Stefano and Oliver, > > > > > > > > > > > > On Tue, May 3, 2022 at 7:49 AM Oliver Graute > > > > > > wrote: > > > > > > > > > > > > > > Switch to use binman to pack images > > > > > > > > > > > > > > Signed-off-by: Oliver Graute > > > > > > > Reviewed-by: Fabio Estevam > > > > > > > Reviewed-by: Simon Glass > > > > > > > --- > > > > > > > Changes for v3 > > > > > > > -added Reviewed-by > > > > > > > -rebased on master > > > > > > > > > > > > > > arch/arm/dts/imx8qm-cgtqmx8.dts | 1 + > > > > > > > arch/arm/mach-imx/imx8/Kconfig | 1 + > > > > > > > board/congatec/cgtqmx8/imximage.cfg | 4 ++-- > > > > > > > configs/cgtqmx8_defconfig | 2 +- > > > > > > > doc/board/congatec/cgtqmx8.rst | 3 +-- > > > > > > > 5 files changed, 6 insertions(+), 5 deletions(-) > > > > > > > > > > > > Just realized that v3 does not include imx8qm-u-boot.dtsi and this breaks CI. > > > > > > > > > > > > > > > > Right - as well as V4, this is what I tried to merge and breaks. I have drop > > > > > it. > > > > > > > > > > > The previous v2 did include it: > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20220221090139.10066-1-oliver.graute@kococonnector.com/ > > > > > > > > > > Thanks for noting this - Oliver, can you check and repost a V5, then ? > > > > > > > > The arch/arm/dts/imx8qm-u-boot.dtsi is applied on the binman Patch for > > > > "PATCH v3 imx: imx8qm-rom7720: switch to binman" > > > > > > > > So if you first apply the patches for the imx8qm-rom7720 Board it should work. > > > > > > > > > Ok, thanks for tipp - I apply both and will test again > > > > I saw the CI Pipeline failing. Perhaps the reason is a > > missing CONFIG_FIT_EXTERNAL_OFFSET? > > > > I see this, but just applying the two patches, multiple boards are broken: > imx8qm_rom7720_a1_4G cgtqmx8 imx8qm_mek imx8qxp_mek deneb giedi > > > > +++ b/configs/cgtqmx8_defconfig > > @@ -20,6 +20,7 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > > CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000 > > CONFIG_REMAKE_ELF=y > > CONFIG_FIT=y > > +CONFIG_FIT_EXTERNAL_OFFSET=0x3000 > > CONFIG_SPL_LOAD_FIT=y > > # CONFIG_USE_SPL_FIT_GENERATOR is not set > > > > Can you confirm? > > > > I let CI run just to see if cgtqmx8 is fixed. For imx8qm_rom7720 the CONFIG_FIT_EXTERNAL_OFFSET is also missing --- a/configs/imx8qm_rom7720_a1_4G_defconfig +++ b/configs/imx8qm_rom7720_a1_4G_defconfig @@ -20,6 +20,7 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000 CONFIG_REMAKE_ELF=y CONFIG_FIT=y +CONFIG_FIT_EXTERNAL_OFFSET=0x3000 CONFIG_SPL_LOAD_FIT=y # CONFIG_USE_SPL_FIT_GENERATOR is not set CONFIG_BOOTDELAY=3 Best regards, Oliver