From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9155FA3740 for ; Thu, 27 Oct 2022 12:59:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3169884D78; Thu, 27 Oct 2022 14:59:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="twb9rAzH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 37B2680077; Thu, 27 Oct 2022 14:59:52 +0200 (CEST) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 533B380077 for ; Thu, 27 Oct 2022 14:59:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x833.google.com with SMTP id g11so1013675qts.1 for ; Thu, 27 Oct 2022 05:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iD1lRHDV31E1r8aqWwuXl/ou6v+M3lpcENLQyzawC88=; b=twb9rAzHEBx6fLphesCTJPJBKpZJVQ9ZA0cxxMZAtA8XdafKIsASxoK+ZJahgjbeMt jsNAMVJDfVvdG5A42EzP0arijYhyEOVMFl8NHKoz7rIFb3qPNxgWOqLeXp2WmgwEXWGq RhiOikvsDss+5ZWAiXRBIz5kEbzmrlp+1XKlw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iD1lRHDV31E1r8aqWwuXl/ou6v+M3lpcENLQyzawC88=; b=usiE5Id1NJrRgDLOtnQdyZcO9weaTPkUec+PKnHoj+VFwNJMW+64fMXnD4v1Sfs9Ms 5tqCbHg2oPdXZQxspS/HtK1O1pFVjIvbWTAuL/Ef5QYKraRAugBhtXk6SpahqY+7xmcb xsIibXkfPzjKTcsHz9Ls+3pYyK2F47expE0gLyoeNt41vG39HDQ985DY6ka6QDAJFE+Y qmMH0vKdbUoAi35qEqnLGvLb7BX0RHjfjOXIQDMO+HQcBbrgdz3kP88BMLFD7Fx1mGST rsNcpOrINnIgjPMVznhC5feWsQdjtrhYYQR1kYtt41jkB+aavcyhBwHcLXRIjxPa3Bop hWCg== X-Gm-Message-State: ACrzQf1E83e2sutAoMzsQkmFHw8pmntg4v/E4qDhCiiexnpaMSjH2boN QFX/PA3FcehCG1bqEC5a1tRGYg== X-Google-Smtp-Source: AMsMyM5IGLF1e2jqP7nH80VAEnvX7u/A2qi+kZmZ2wxEHpj8qT0z9NXa7c9E0VyR1qlgV2t56yBhxA== X-Received: by 2002:a05:622a:110e:b0:39c:bd9b:cd18 with SMTP id e14-20020a05622a110e00b0039cbd9bcd18mr41018869qty.186.1666875588110; Thu, 27 Oct 2022 05:59:48 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-f430-99ec-b6f9-cbc9.res6.spectrum.com. [2603:6081:7b00:6400:f430:99ec:b6f9:cbc9]) by smtp.gmail.com with ESMTPSA id q32-20020a05620a2a6000b006f7ee901674sm956065qkp.2.2022.10.27.05.59.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 05:59:47 -0700 (PDT) Date: Thu, 27 Oct 2022 08:59:45 -0400 From: Tom Rini To: Sinthu Raja Cc: u-boot@lists.denx.de, Simon Glass , Marcel Ziswiler , Marek Vasut , Vignesh Raghavendra , Sinthu Raja Subject: Re: [PATCH 04/11] board: ti: j721s2: Add support to update board_name for am68-sk Message-ID: <20221027125945.GI2020586@bill-the-cat> References: <20221027104846.11820-1-sinthu.raja@ti.com> <20221027104846.11820-5-sinthu.raja@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6aicaHRgGAHHOqae" Content-Disposition: inline In-Reply-To: <20221027104846.11820-5-sinthu.raja@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --6aicaHRgGAHHOqae Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 27, 2022 at 04:18:39PM +0530, Sinthu Raja wrote: > From: Sinthu Raja >=20 > Update setup_board_eeprom_env() to choose the right board name > for am68-sk. >=20 > Signed-off-by: Sinthu Raja > --- > board/ti/j721s2/evm.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/board/ti/j721s2/evm.c b/board/ti/j721s2/evm.c > index e09adc8ad3..e3c75b35b6 100644 > --- a/board/ti/j721s2/evm.c > +++ b/board/ti/j721s2/evm.c > @@ -28,6 +28,8 @@ > =20 > #define board_is_j721s2_som() board_ti_k3_is("J721S2X-PM1-SOM") > =20 > +#define board_is_am68_sk_som() board_ti_k3_is("AM68-SK-SOM") > + > DECLARE_GLOBAL_DATA_PTR; > =20 > int board_init(void) > @@ -136,6 +138,8 @@ static void setup_board_eeprom_env(void) > =20 > if (board_is_j721s2_som()) > name =3D "j721s2"; > + else if (board_is_am68_sk_som()) > + name =3D "am68-sk"; > else > printf("Unidentified board claims %s in eeprom header\n", > board_ti_get_name()); What I'd like to see is moving the board_is_XXX defines moved down to by do_board_detect() and then a comment inside the start of that block to explain that all of this functionality is specific to the EVM family designs. This will hopefully make it clearer that when making a custom board that doesn't have this EEPROM all of this can be omitted and we don't loose the "mini" U-Boot concept for this SoC. --=20 Tom --6aicaHRgGAHHOqae Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNagL4ACgkQFHw5/5Y0 tyyrhgv/fG4SS4ooXspvnj9eeV0hmRVCfNVsFHza6PAjzNgd4i1ulJ+3ItiOPRis HseHCdKN+8XeRZPHlMBVwb+eys4rVHmYM8fU4f/U7dy1E1upVqzlGOyui7fVCJeA ommQUZjaGrGmKpbeqmshw7z8VtndMO/AuQIi6XKmqM1D1jNRDqqJcDXWWuyB5voE IbSS6pSZrX83/YFRmAOfQ4/g/E5qtbAI3lnYzDeeOeF5owACKh8hBQYdYFghsEJW B7uCsaN85xfT1OJBxBSEFtbDTuZNC91k4CDXiicDZT4ek64tvO1sCsM2uyHNzYuU 3o+2mGkzjqRfY3CQQzZbPfmeU/3JKl7OWSTkEeGnpf8ydn6U0W5myYTFXmDFoqko LRjBlsPwlvfVmj0n/5c9E0okUcvmICKArvA0jhoelAWJYlEsx5qFbdzMGRWLRnxo xc27y0jXMnO4eWqmNtlceqJuQK+xTTXCqsF0SOzIpulScszVVfXyLJe3d9C8+Wro CrLzZRps =j74w -----END PGP SIGNATURE----- --6aicaHRgGAHHOqae--