From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57DA1FA3740 for ; Thu, 27 Oct 2022 13:04:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 821E884D78; Thu, 27 Oct 2022 15:04:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="AtVHNzMe"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E6C3B85076; Thu, 27 Oct 2022 15:04:53 +0200 (CEST) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5412884D78 for ; Thu, 27 Oct 2022 15:04:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82d.google.com with SMTP id cr19so1043282qtb.0 for ; Thu, 27 Oct 2022 06:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MnNtxrAM/YzRxmYMdqV5SamgLpnq4DJuupve6xISdV8=; b=AtVHNzMeEfeTolN3nnn8jBV/stFl0Ym+1RaqFi7xzNKOe71em1Za/pBEMgXWkobVL7 SdH8kQFeOxjxijP8wDJNUdwuD+sonzJIMePD6FPY0jfcOLnyaUN8GPGBnAIDoVjXLc5k 3T2fO8Ua1qyyvBeDAhLwh2RXZKBI5H+xRsJyk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MnNtxrAM/YzRxmYMdqV5SamgLpnq4DJuupve6xISdV8=; b=m9cuJNBApTQvjrQ/p6JZgGyZwfHpYwDeE18fuLsP1NisGJVKcoG00dOnWlPYhcI38y I9dJyPAQu1LUDa4ol2XPNUSok7frqRjA1xQ8IKwcvzMtbV7oAzIrXXs6ciW9/rNQj8Iu zC0EL+jqWVwjAmHLnbExj8RXBUaK1P/Xe0YTBSSae/6sDcd4/AVOpHFqSr7ZPVPypV2O FdHdhvNVRP3C/B8y/ZMz+TLcKmKwjFawHjLBOeJeQC/KvbnjS++77xW1jspnQ9bHmp4w mG3c4cZtGP3hIySLkl5BXagVwAakHz8pXYvLHkfNzcObNK7OaHRvUu3fSCfQ2F+tbVBg C2VA== X-Gm-Message-State: ACrzQf1AiPyrDbHOAXvgNr7sDlvzGi4WsR7UoTSqvwlakTBr9sVmlMDK PxHlqC8Ngih7vwlXjL88sLiyIA== X-Google-Smtp-Source: AMsMyM6ZHNMpnubi06FFtAkQi28r3ICzObC4bk194i+MylXxD/sko7VoMOfMmqmZjtXA7C1QTP94Cg== X-Received: by 2002:a05:622a:1391:b0:39c:eee6:123e with SMTP id o17-20020a05622a139100b0039ceee6123emr41656073qtk.271.1666875890072; Thu, 27 Oct 2022 06:04:50 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-f430-99ec-b6f9-cbc9.res6.spectrum.com. [2603:6081:7b00:6400:f430:99ec:b6f9:cbc9]) by smtp.gmail.com with ESMTPSA id u25-20020a37ab19000000b006ecb9dfdd15sm932116qke.92.2022.10.27.06.04.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 06:04:49 -0700 (PDT) Date: Thu, 27 Oct 2022 09:04:47 -0400 From: Tom Rini To: Sinthu Raja Cc: u-boot@lists.denx.de, Simon Glass , Marcel Ziswiler , Marek Vasut , Vignesh Raghavendra , Sinthu Raja Subject: Re: [PATCH 07/11] arm: j721s2: Add support for selecting DT based on EEPROM Message-ID: <20221027130447.GK2020586@bill-the-cat> References: <20221027104846.11820-1-sinthu.raja@ti.com> <20221027104846.11820-8-sinthu.raja@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kvu8veHlLaXiyurS" Content-Disposition: inline In-Reply-To: <20221027104846.11820-8-sinthu.raja@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --kvu8veHlLaXiyurS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 27, 2022 at 04:18:42PM +0530, Sinthu Raja wrote: > From: Sinthu Raja >=20 > Enable support for selecting DTB from FIT within SPL based on the > board name read from EEPROM. This will help to use single defconfig > for both EVM and SK. >=20 > Signed-off-by: Sinthu Raja > --- > arch/arm/mach-k3/j721s2_init.c | 59 ++++++++++++++++++++++++++++++++++ > 1 file changed, 59 insertions(+) >=20 > diff --git a/arch/arm/mach-k3/j721s2_init.c b/arch/arm/mach-k3/j721s2_ini= t.c > index 12da8136f9..fc5eee03b6 100644 > --- a/arch/arm/mach-k3/j721s2_init.c > +++ b/arch/arm/mach-k3/j721s2_init.c > @@ -19,8 +19,10 @@ > #include > #include > #include > +#include > #include > #include > +#include > =20 > static void ctrl_mmr_unlock(void) > { > @@ -93,6 +95,59 @@ static void store_boot_info_from_rom(void) > sizeof(struct rom_extended_boot_data)); > } > =20 > +#ifdef CONFIG_SPL_OF_LIST > +void do_dt_magic(void) > +{ > + int ret, rescan, mmc_dev =3D -1; > + static struct mmc *mmc; > + > + if (IS_ENABLED(CONFIG_TI_I2C_BOARD_DETECT)) > + do_board_detect(); We need to try and avoid putting the CONFIG_TI_I2C_BOARD_DETECT calls and checks in the generic mach-k3 code as it's not required nor likely used on non-reference platforms. And again, if we do not need to move to a board-specific DTB in SPL, we do not want to, we want to push that off to full U-Boot. --=20 Tom --kvu8veHlLaXiyurS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNage8ACgkQFHw5/5Y0 tyycUgv8Da7Txl1QZXQl8eU1D7X+kZUD6D/pWu4hhKiPZpN6B9IMlVsi1VltZwbs DGGixcd6HIVNK2uZCn5/MRwEEJwKhvDge5L0qt6NulwnsS1GOBL+n3H436p1La4B PD919Fa8JocPE8VNMMEOlGmuRLyTcuDgdelPMkZhKJWou2Kj8nGXB/sswUDr045n unU1nmXrPuJWLzUA00TVn8P/4SQe77pWoOV6+e+huJ7MQnnRi8C2bWGOMdeXWDNl wu1lII4keZDSMTgj60s6u6o0/9zG5sFMg8ijc+KCjcrcQmtBN3yY+u0NEmSsxO+N pHLYO+NiMnJRQTpJ8WTWWgguawXLAubS1JRkvH1b8v8VPsrj4Je3aWlFYCSa+GR1 UXWKWqUPu00HS8G4mVAJcvWFuVKcnCAePx3QZQQ55ns4+hbj+uorTBfCEs/sg7XL 4gXIF/VkPfHQVlzH5y8bKuySP9kWQfGnry9eoHMyRIeh27mICCDp/lpoS/hLuXPA BwKb77lB =e3F7 -----END PGP SIGNATURE----- --kvu8veHlLaXiyurS--