* [PATCH v1] imx: imx8qm: imx8qm_mek switch to binman
@ 2022-10-26 8:09 Oliver Graute
2022-10-26 9:18 ` Peng Fan
0 siblings, 1 reply; 3+ messages in thread
From: Oliver Graute @ 2022-10-26 8:09 UTC (permalink / raw)
To: sbabic
Cc: festevam, peng.fan, oliver.graute, uboot-imx, u-boot, Gaurav Jain,
Ye Li, Horia Geantă, Denys Drozdov, Marcel Ziswiler
Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
---
arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi | 2 ++
arch/arm/mach-imx/imx8/Kconfig | 1 +
board/freescale/imx8qm_mek/README | 2 +-
board/freescale/imx8qm_mek/imximage.cfg | 2 +-
configs/imx8qm_mek_defconfig | 2 ++
5 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi b/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi
index a95209e141..eefdccf992 100644
--- a/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi
+++ b/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi
@@ -3,6 +3,8 @@
* Copyright 2018, 2021 NXP
*/
+#include "imx8qm-u-boot.dtsi"
+
&{/imx8qm-pm} {
u-boot,dm-spl;
diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig
index 23a7fcf361..4ccbabf506 100644
--- a/arch/arm/mach-imx/imx8/Kconfig
+++ b/arch/arm/mach-imx/imx8/Kconfig
@@ -68,6 +68,7 @@ config TARGET_GIEDI
config TARGET_IMX8QM_MEK
bool "Support i.MX8QM MEK board"
+ select BINMAN
select BOARD_LATE_INIT
select IMX8QM
select FSL_CAAM
diff --git a/board/freescale/imx8qm_mek/README b/board/freescale/imx8qm_mek/README
index 570ed7e210..b1a4c6cc82 100644
--- a/board/freescale/imx8qm_mek/README
+++ b/board/freescale/imx8qm_mek/README
@@ -40,7 +40,7 @@ And copy the following firmwares to U-Boot folder:
Build U-Boot
============
$ make imx8qm_mek_defconfig
-$ make flash.bin
+$ make
Flash the binary into the SD card
=================================
diff --git a/board/freescale/imx8qm_mek/imximage.cfg b/board/freescale/imx8qm_mek/imximage.cfg
index 71612678c9..46ca3bf817 100644
--- a/board/freescale/imx8qm_mek/imximage.cfg
+++ b/board/freescale/imx8qm_mek/imximage.cfg
@@ -5,7 +5,7 @@
/* Boot from SD, sector size 0x400 */
-BOOT_FROM SD 0x400
+BOOT_FROM sd
/* SoC type IMX8QM */
SOC_TYPE IMX8QM
/* Append seco container image */
diff --git a/configs/imx8qm_mek_defconfig b/configs/imx8qm_mek_defconfig
index b973b809be..25b51cf1ec 100644
--- a/configs/imx8qm_mek_defconfig
+++ b/configs/imx8qm_mek_defconfig
@@ -23,6 +23,8 @@ CONFIG_SYS_LOAD_ADDR=0x80280000
CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000
CONFIG_REMAKE_ELF=y
+CONFIG_FIT=y
+CONFIG_FIT_EXTERNAL_OFFSET=0x3000
CONFIG_OF_BOARD_SETUP=y
CONFIG_OF_SYSTEM_SETUP=y
CONFIG_BOOTDELAY=3
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] imx: imx8qm: imx8qm_mek switch to binman
2022-10-26 8:09 [PATCH v1] imx: imx8qm: imx8qm_mek switch to binman Oliver Graute
@ 2022-10-26 9:18 ` Peng Fan
2022-10-27 14:27 ` Oliver Graute
0 siblings, 1 reply; 3+ messages in thread
From: Peng Fan @ 2022-10-26 9:18 UTC (permalink / raw)
To: Oliver Graute, sbabic
Cc: festevam, peng.fan, uboot-imx, u-boot, Gaurav Jain, Ye Li,
Horia Geantă, Denys Drozdov, Marcel Ziswiler
On 10/26/2022 4:09 PM, Oliver Graute wrote:
> Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> ---
> arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi | 2 ++
> arch/arm/mach-imx/imx8/Kconfig | 1 +
> board/freescale/imx8qm_mek/README | 2 +-
> board/freescale/imx8qm_mek/imximage.cfg | 2 +-
> configs/imx8qm_mek_defconfig | 2 ++
> 5 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi b/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi
> index a95209e141..eefdccf992 100644
> --- a/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi
> +++ b/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi
> @@ -3,6 +3,8 @@
> * Copyright 2018, 2021 NXP
> */
>
> +#include "imx8qm-u-boot.dtsi"
> +
I think the build system would automatically include this.
Please correct if I am wrong.
> &{/imx8qm-pm} {
>
> u-boot,dm-spl;
> diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig
> index 23a7fcf361..4ccbabf506 100644
> --- a/arch/arm/mach-imx/imx8/Kconfig
> +++ b/arch/arm/mach-imx/imx8/Kconfig
> @@ -68,6 +68,7 @@ config TARGET_GIEDI
>
> config TARGET_IMX8QM_MEK
> bool "Support i.MX8QM MEK board"
> + select BINMAN
> select BOARD_LATE_INIT
> select IMX8QM
> select FSL_CAAM
> diff --git a/board/freescale/imx8qm_mek/README b/board/freescale/imx8qm_mek/README
> index 570ed7e210..b1a4c6cc82 100644
> --- a/board/freescale/imx8qm_mek/README
> +++ b/board/freescale/imx8qm_mek/README
> @@ -40,7 +40,7 @@ And copy the following firmwares to U-Boot folder:
> Build U-Boot
> ============
> $ make imx8qm_mek_defconfig
> -$ make flash.bin
> +$ make
>
> Flash the binary into the SD card
> =================================
> diff --git a/board/freescale/imx8qm_mek/imximage.cfg b/board/freescale/imx8qm_mek/imximage.cfg
> index 71612678c9..46ca3bf817 100644
> --- a/board/freescale/imx8qm_mek/imximage.cfg
> +++ b/board/freescale/imx8qm_mek/imximage.cfg
> @@ -5,7 +5,7 @@
>
>
> /* Boot from SD, sector size 0x400 */
> -BOOT_FROM SD 0x400
> +BOOT_FROM sd
Why update this?
> /* SoC type IMX8QM */
> SOC_TYPE IMX8QM
> /* Append seco container image */
> diff --git a/configs/imx8qm_mek_defconfig b/configs/imx8qm_mek_defconfig
> index b973b809be..25b51cf1ec 100644
> --- a/configs/imx8qm_mek_defconfig
> +++ b/configs/imx8qm_mek_defconfig
> @@ -23,6 +23,8 @@ CONFIG_SYS_LOAD_ADDR=0x80280000
> CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000
> CONFIG_REMAKE_ELF=y
> +CONFIG_FIT=y
> +CONFIG_FIT_EXTERNAL_OFFSET=0x3000
> CONFIG_OF_BOARD_SETUP=y
> CONFIG_OF_SYSTEM_SETUP=y
> CONFIG_BOOTDELAY=3
Regards,
Peng.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] imx: imx8qm: imx8qm_mek switch to binman
2022-10-26 9:18 ` Peng Fan
@ 2022-10-27 14:27 ` Oliver Graute
0 siblings, 0 replies; 3+ messages in thread
From: Oliver Graute @ 2022-10-27 14:27 UTC (permalink / raw)
To: Peng Fan
Cc: sbabic, festevam, peng.fan, uboot-imx, u-boot, Gaurav Jain, Ye Li,
Horia Geantă, Denys Drozdov, Marcel Ziswiler
On 26/10/22, Peng Fan wrote:
>
>
> On 10/26/2022 4:09 PM, Oliver Graute wrote:
> > Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> > ---
> > arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi | 2 ++
> > arch/arm/mach-imx/imx8/Kconfig | 1 +
> > board/freescale/imx8qm_mek/README | 2 +-
> > board/freescale/imx8qm_mek/imximage.cfg | 2 +-
> > configs/imx8qm_mek_defconfig | 2 ++
> > 5 files changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi b/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi
> > index a95209e141..eefdccf992 100644
> > --- a/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi
> > +++ b/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi
> > @@ -3,6 +3,8 @@
> > * Copyright 2018, 2021 NXP
> > */
> > +#include "imx8qm-u-boot.dtsi"
> > +
>
> I think the build system would automatically include this.
> Please correct if I am wrong.
That's not the case if I remove the include I run into following error:
make[1]: Für das Ziel „SPL“ ist nichts zu tun.
BINMAN all
binman: Device tree 'u-boot.dtb' does not have a 'binman' node
Makefile:1109: recipe for target 'all' failed
make: *** [all] Error 1
>
> > &{/imx8qm-pm} {
> > u-boot,dm-spl;
> > diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig
> > index 23a7fcf361..4ccbabf506 100644
> > --- a/arch/arm/mach-imx/imx8/Kconfig
> > +++ b/arch/arm/mach-imx/imx8/Kconfig
> > @@ -68,6 +68,7 @@ config TARGET_GIEDI
> > config TARGET_IMX8QM_MEK
> > bool "Support i.MX8QM MEK board"
> > + select BINMAN
> > select BOARD_LATE_INIT
> > select IMX8QM
> > select FSL_CAAM
> > diff --git a/board/freescale/imx8qm_mek/README b/board/freescale/imx8qm_mek/README
> > index 570ed7e210..b1a4c6cc82 100644
> > --- a/board/freescale/imx8qm_mek/README
> > +++ b/board/freescale/imx8qm_mek/README
> > @@ -40,7 +40,7 @@ And copy the following firmwares to U-Boot folder:
> > Build U-Boot
> > ============
> > $ make imx8qm_mek_defconfig
> > -$ make flash.bin
> > +$ make
> > Flash the binary into the SD card
> > =================================
> > diff --git a/board/freescale/imx8qm_mek/imximage.cfg b/board/freescale/imx8qm_mek/imximage.cfg
> > index 71612678c9..46ca3bf817 100644
> > --- a/board/freescale/imx8qm_mek/imximage.cfg
> > +++ b/board/freescale/imx8qm_mek/imximage.cfg
> > @@ -5,7 +5,7 @@
> > /* Boot from SD, sector size 0x400 */
> > -BOOT_FROM SD 0x400
> > +BOOT_FROM sd
>
> Why update this?
you are right its unneccessary, will fix it in v2
>
> > /* SoC type IMX8QM */
> > SOC_TYPE IMX8QM
> > /* Append seco container image */
> > diff --git a/configs/imx8qm_mek_defconfig b/configs/imx8qm_mek_defconfig
> > index b973b809be..25b51cf1ec 100644
> > --- a/configs/imx8qm_mek_defconfig
> > +++ b/configs/imx8qm_mek_defconfig
> > @@ -23,6 +23,8 @@ CONFIG_SYS_LOAD_ADDR=0x80280000
> > CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> > CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000
> > CONFIG_REMAKE_ELF=y
> > +CONFIG_FIT=y
> > +CONFIG_FIT_EXTERNAL_OFFSET=0x3000
> > CONFIG_OF_BOARD_SETUP=y
> > CONFIG_OF_SYSTEM_SETUP=y
> > CONFIG_BOOTDELAY=3
>
> Regards,
> Peng.
Best Regards,
Oliver
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-27 14:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-26 8:09 [PATCH v1] imx: imx8qm: imx8qm_mek switch to binman Oliver Graute
2022-10-26 9:18 ` Peng Fan
2022-10-27 14:27 ` Oliver Graute
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox