From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F20A6FA3740 for ; Thu, 27 Oct 2022 14:31:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 543F58506C; Thu, 27 Oct 2022 16:31:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="q5NMvHaS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 69B3D8506C; Thu, 27 Oct 2022 16:31:15 +0200 (CEST) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A54B68506C for ; Thu, 27 Oct 2022 16:31:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=oliver.graute@gmail.com Received: by mail-ed1-x52d.google.com with SMTP id a67so3039217edf.12 for ; Thu, 27 Oct 2022 07:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:date:from:from:to:cc:subject:date :message-id:reply-to; bh=R5i917UMyNB5//e1nYPuUcXyGM6XmjydKN+LJAh7Yh0=; b=q5NMvHaSlADsk2HS/ZFFz7JzgBvu20b8rymvx2TO5OtXDzRjOBH/jtNOmVP2m4iEiT BQRmzSxlV2eRgkQRf9vsieBHAn1v7sQDClH7bPXmj1QSq7iKZnJ1jA8g6jEIueIp2pwd rfHtPc9YtCscOfB8R8Y2doyj/EBa8Hp8CcTZ9N6+W6xHj3IiOKiAjYnUFZTv31I+PWpv uhU5X8QiHUZy+kZW740H77JEbtUGyL2AL9wnGZvI6hemZxoL/4E1kJgYufuz2bnzyPdf XT+Ayxk9B9x8u0jmcLhrJ2q8Gbb3nIhioBurvRYtqk/ynwp/ygfdeI/B/8XqHKdODLIr /Izw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R5i917UMyNB5//e1nYPuUcXyGM6XmjydKN+LJAh7Yh0=; b=eeQNVQ1XP9cW2/OACdP4ev23Wh757J/KXSHh4F6hL3ehEuyh4gYoFI+9GfQwVZKj9Z 3IVib9Iox1bgZhUT+EP7vJSX3YtXdq3Mn16b5IN073PIl8FFKRnFBitHaup1L5DqA/RM uSZjjCHvDxFYtmWpMGyaVKQ8WkgLHefYiSP+0i7/iUYrVTBKa22RZfp2XuAI3mwd2QiZ 9MD8HzT0rSTs1O/d+hq4xdchJUnH+0ZOitpWBSCMZuSD6YUfdF4Jnr/dBikPQlfg+hZg qDyoi9+5RWwagrmIcGmM1/v937gxyU0QrPsrdWhHb7oLny7/aKPKbbQBcqjt2xT+6M58 aGxA== X-Gm-Message-State: ACrzQf0853ZCrt0uEA/JqFa7XgAGPoVeDIkWcOhIroFplUxUGk7dkO1S o3pQQ54zMfnXKsg2dlQIfd8= X-Google-Smtp-Source: AMsMyM7o5sC9AftCXALBvDQLZBLNUDrCs9JXvtyf6/suxXUKO/rmBZYuTjjEqu3qDazWD9JzDo19Xw== X-Received: by 2002:a05:6402:4445:b0:461:b506:de51 with SMTP id o5-20020a056402444500b00461b506de51mr21694418edb.388.1666881071919; Thu, 27 Oct 2022 07:31:11 -0700 (PDT) Received: from localhost (business-90-187-74-145.pool2.vodafone-ip.de. [90.187.74.145]) by smtp.gmail.com with ESMTPSA id v16-20020a056402349000b00459cd13fd34sm1115294edc.85.2022.10.27.07.31.10 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Oct 2022 07:31:10 -0700 (PDT) From: Oliver Graute X-Google-Original-From: Oliver Graute Date: Thu, 27 Oct 2022 16:27:59 +0200 To: Peng Fan Cc: sbabic@denx.de, festevam@gmail.com, peng.fan@nxp.com, uboot-imx@nxp.com, u-boot@lists.denx.de, Gaurav Jain , Ye Li , Horia =?utf-8?Q?Geant=C4=83?= , Denys Drozdov , Marcel Ziswiler Subject: Re: [PATCH v1] imx: imx8qm: imx8qm_mek switch to binman Message-ID: <20221027142759.GA20312@optiplex> Mail-Followup-To: Peng Fan , sbabic@denx.de, festevam@gmail.com, peng.fan@nxp.com, uboot-imx@nxp.com, u-boot@lists.denx.de, Gaurav Jain , Ye Li , Horia =?utf-8?Q?Geant=C4=83?= , Denys Drozdov , Marcel Ziswiler References: <20221026080955.12007-1-oliver.graute@kococonnector.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 26/10/22, Peng Fan wrote: > > > On 10/26/2022 4:09 PM, Oliver Graute wrote: > > Signed-off-by: Oliver Graute > > --- > > arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi | 2 ++ > > arch/arm/mach-imx/imx8/Kconfig | 1 + > > board/freescale/imx8qm_mek/README | 2 +- > > board/freescale/imx8qm_mek/imximage.cfg | 2 +- > > configs/imx8qm_mek_defconfig | 2 ++ > > 5 files changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi b/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi > > index a95209e141..eefdccf992 100644 > > --- a/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi > > +++ b/arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi > > @@ -3,6 +3,8 @@ > > * Copyright 2018, 2021 NXP > > */ > > +#include "imx8qm-u-boot.dtsi" > > + > > I think the build system would automatically include this. > Please correct if I am wrong. That's not the case if I remove the include I run into following error: make[1]: Für das Ziel „SPL“ ist nichts zu tun. BINMAN all binman: Device tree 'u-boot.dtb' does not have a 'binman' node Makefile:1109: recipe for target 'all' failed make: *** [all] Error 1 > > > &{/imx8qm-pm} { > > u-boot,dm-spl; > > diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig > > index 23a7fcf361..4ccbabf506 100644 > > --- a/arch/arm/mach-imx/imx8/Kconfig > > +++ b/arch/arm/mach-imx/imx8/Kconfig > > @@ -68,6 +68,7 @@ config TARGET_GIEDI > > config TARGET_IMX8QM_MEK > > bool "Support i.MX8QM MEK board" > > + select BINMAN > > select BOARD_LATE_INIT > > select IMX8QM > > select FSL_CAAM > > diff --git a/board/freescale/imx8qm_mek/README b/board/freescale/imx8qm_mek/README > > index 570ed7e210..b1a4c6cc82 100644 > > --- a/board/freescale/imx8qm_mek/README > > +++ b/board/freescale/imx8qm_mek/README > > @@ -40,7 +40,7 @@ And copy the following firmwares to U-Boot folder: > > Build U-Boot > > ============ > > $ make imx8qm_mek_defconfig > > -$ make flash.bin > > +$ make > > Flash the binary into the SD card > > ================================= > > diff --git a/board/freescale/imx8qm_mek/imximage.cfg b/board/freescale/imx8qm_mek/imximage.cfg > > index 71612678c9..46ca3bf817 100644 > > --- a/board/freescale/imx8qm_mek/imximage.cfg > > +++ b/board/freescale/imx8qm_mek/imximage.cfg > > @@ -5,7 +5,7 @@ > > /* Boot from SD, sector size 0x400 */ > > -BOOT_FROM SD 0x400 > > +BOOT_FROM sd > > Why update this? you are right its unneccessary, will fix it in v2 > > > /* SoC type IMX8QM */ > > SOC_TYPE IMX8QM > > /* Append seco container image */ > > diff --git a/configs/imx8qm_mek_defconfig b/configs/imx8qm_mek_defconfig > > index b973b809be..25b51cf1ec 100644 > > --- a/configs/imx8qm_mek_defconfig > > +++ b/configs/imx8qm_mek_defconfig > > @@ -23,6 +23,8 @@ CONFIG_SYS_LOAD_ADDR=0x80280000 > > CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > > CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000 > > CONFIG_REMAKE_ELF=y > > +CONFIG_FIT=y > > +CONFIG_FIT_EXTERNAL_OFFSET=0x3000 > > CONFIG_OF_BOARD_SETUP=y > > CONFIG_OF_SYSTEM_SETUP=y > > CONFIG_BOOTDELAY=3 > > Regards, > Peng. Best Regards, Oliver