From: Tom Rini <trini@konsulko.com>
To: Detlev Casanova <detlev.casanova@collabora.com>
Cc: u-boot@lists.denx.de, Stefano Babic <sbabic@denx.de>,
Fabio Estevam <festevam@gmail.com>,
"NXP i . MX U-Boot Team" <uboot-imx@nxp.com>
Subject: Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices
Date: Thu, 27 Oct 2022 14:30:51 -0400 [thread overview]
Message-ID: <20221027183051.GN2020586@bill-the-cat> (raw)
In-Reply-To: <20221027152252.46552-1-detlev.casanova@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]
On Thu, Oct 27, 2022 at 11:22:52AM -0400, Detlev Casanova wrote:
> In commit d0399a46e7cda63c07e3eb8558bef84cfb068028, the device tree was
> synchronized from linux and the aliases were dropped.
>
> They need to be kept so that the mmc cards are in the right order.
> Without the aliases, u-boot reports:
> MMC: FSL_SDHC: 2, FSL_SDHC: 3
>
> With the aliases, u-boot reports:
> MMC: FSL_SDHC: 0, FSL_SDHC: 1
>
> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> ---
> arch/arm/dts/imx6qdl-sabrelite.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/dts/imx6qdl-sabrelite.dtsi b/arch/arm/dts/imx6qdl-sabrelite.dtsi
> index 22f8e2783c..6564e3b82c 100644
> --- a/arch/arm/dts/imx6qdl-sabrelite.dtsi
> +++ b/arch/arm/dts/imx6qdl-sabrelite.dtsi
> @@ -10,6 +10,13 @@
> #include <dt-bindings/input/input.h>
>
> / {
> + aliases {
> + mmc0 = &usdhc3;
> + mmc1 = &usdhc4;
> + pwm_lcd = &pwm1;
> + pwm_lvds = &pwm4;
> + };
> +
> chosen {
> stdout-path = &uart2;
> };
This really belongs in the upstream dts file so they aren't lost again
and again.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-10-27 18:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 15:22 [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices Detlev Casanova
2022-10-27 18:30 ` Tom Rini [this message]
2022-11-11 15:28 ` Detlev Casanova
2022-11-11 15:35 ` Tom Rini
2022-12-02 19:06 ` Detlev Casanova
2022-12-02 20:08 ` Tom Rini
2022-12-02 23:20 ` Fabio Estevam
2022-12-02 23:36 ` Tom Rini
2022-12-03 12:23 ` Fabio Estevam
2022-12-05 14:24 ` Detlev Casanova
2022-12-05 15:37 ` Tom Rini
2022-12-05 17:33 ` Fabio Estevam
2022-12-07 19:53 ` Detlev Casanova
2022-12-07 20:01 ` Tom Rini
2022-12-07 20:03 ` Tom Rini
2022-12-07 20:08 ` Detlev Casanova
2022-12-07 20:32 ` Tom Rini
2022-12-08 13:35 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221027183051.GN2020586@bill-the-cat \
--to=trini@konsulko.com \
--cc=detlev.casanova@collabora.com \
--cc=festevam@gmail.com \
--cc=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox