From: Francis Laniel <francis.laniel@amarulasolutions.com>
To: u-boot@lists.denx.de
Cc: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
Tom Rini <trini@konsulko.com>,
Aleksandar Gerasimovski
<aleksandar.gerasimovski@hitachienergy.com>,
Holger Brunck <holger.brunck@hitachienergy.com>,
Francis Laniel <francis.laniel@amarulasolutions.com>,
Simon Glass <sjg@chromium.org>,
Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: [RFC PATCH v5 01/24] test: Add framework to test hush behavior
Date: Tue, 1 Nov 2022 20:20:06 +0100 [thread overview]
Message-ID: <20221101192029.10231-2-francis.laniel@amarulasolutions.com> (raw)
In-Reply-To: <20221101192029.10231-1-francis.laniel@amarulasolutions.com>
Introduce a new subcommand to ut: ut hush.
For the moment, this command does nothing, future commits will add tests which
will be run on command call.
Note that CONFIG_HUSH_PARSER must be defined to compile this new subcommand.
Signed-off-by: Francis Laniel <francis.laniel@amarulasolutions.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
include/test/hush.h | 15 +++++++++++++++
include/test/suites.h | 1 +
test/Makefile | 3 +++
test/cmd_ut.c | 6 ++++++
test/hush/Makefile | 6 ++++++
test/hush/cmd_ut_hush.c | 20 ++++++++++++++++++++
6 files changed, 51 insertions(+)
create mode 100644 include/test/hush.h
create mode 100644 test/hush/Makefile
create mode 100644 test/hush/cmd_ut_hush.c
diff --git a/include/test/hush.h b/include/test/hush.h
new file mode 100644
index 0000000000..cca66544a0
--- /dev/null
+++ b/include/test/hush.h
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * (C) Copyright 2021
+ * Francis Laniel, Amarula Solutions, francis.laniel@amarulasolutions.com
+ */
+
+#ifndef __TEST_HUSH_H__
+#define __TEST_HUSH_H__
+
+#include <test/test.h>
+
+/* Declare a new environment test */
+#define HUSH_TEST(_name, _flags) UNIT_TEST(_name, _flags, hush_test)
+
+#endif /* __TEST_HUSH_H__ */
diff --git a/include/test/suites.h b/include/test/suites.h
index a01000e127..2a1c9098c4 100644
--- a/include/test/suites.h
+++ b/include/test/suites.h
@@ -40,6 +40,7 @@ int do_ut_dm(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
int do_ut_env(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
int do_ut_fdt(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
int do_ut_font(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
+int do_ut_hush(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
int do_ut_lib(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
int do_ut_loadm(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
int do_ut_log(struct cmd_tbl *cmdtp, int flag, int argc, char * const argv[]);
diff --git a/test/Makefile b/test/Makefile
index 178773647a..d6ca3e221d 100644
--- a/test/Makefile
+++ b/test/Makefile
@@ -20,6 +20,9 @@ obj-$(CONFIG_FUZZ) += fuzz/
ifndef CONFIG_SANDBOX_VPL
obj-$(CONFIG_UNIT_TEST) += lib/
endif
+ifneq ($(CONFIG_HUSH_PARSER),)
+obj-$(CONFIG_$(SPL_)CMDLINE) += hush/
+endif
obj-$(CONFIG_$(SPL_)CMDLINE) += print_ut.o
obj-$(CONFIG_$(SPL_)CMDLINE) += str_ut.o
obj-$(CONFIG_UT_TIME) += time_ut.o
diff --git a/test/cmd_ut.c b/test/cmd_ut.c
index beebd5ce38..2bec3fbb19 100644
--- a/test/cmd_ut.c
+++ b/test/cmd_ut.c
@@ -97,6 +97,9 @@ static struct cmd_tbl cmd_ut_sub[] = {
#ifdef CONFIG_CMD_ADDRMAP
U_BOOT_CMD_MKENT(addrmap, CONFIG_SYS_MAXARGS, 1, do_ut_addrmap, "", ""),
#endif
+#if CONFIG_IS_ENABLED(HUSH_PARSER)
+ U_BOOT_CMD_MKENT(hush, CONFIG_SYS_MAXARGS, 1, do_ut_hush, "", ""),
+#endif
#ifdef CONFIG_CMD_LOADM
U_BOOT_CMD_MKENT(loadm, CONFIG_SYS_MAXARGS, 1, do_ut_loadm, "", ""),
#endif
@@ -187,6 +190,9 @@ static char ut_help_text[] =
#endif
#ifdef CONFIG_CMD_ADDRMAP
"ut addrmap - Very basic test of addrmap command\n"
+#if CONFIG_IS_ENABLED(HUSH_PARSER)
+ "ut hush [test-name] - Test hush behavior\n"
+#endif
#endif
#ifdef CONFIG_CMD_LOADM
"ut loadm [test-name]- test of parameters and load memory blob\n"
diff --git a/test/hush/Makefile b/test/hush/Makefile
new file mode 100644
index 0000000000..dfa2a92615
--- /dev/null
+++ b/test/hush/Makefile
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# (C) Copyright 2021
+# Francis Laniel, Amarula Solutions, francis.laniel@amarulasolutions.com
+
+obj-y += cmd_ut_hush.o
diff --git a/test/hush/cmd_ut_hush.c b/test/hush/cmd_ut_hush.c
new file mode 100644
index 0000000000..48a1adbf28
--- /dev/null
+++ b/test/hush/cmd_ut_hush.c
@@ -0,0 +1,20 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * (C) Copyright 2021
+ * Francis Laniel, Amarula Solutions, francis.laniel@amarulasolutions.com
+ */
+
+#include <common.h>
+#include <command.h>
+#include <test/hush.h>
+#include <test/suites.h>
+#include <test/ut.h>
+
+int do_ut_hush(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
+{
+ struct unit_test *tests = UNIT_TEST_SUITE_START(hush_test);
+ const int n_ents = UNIT_TEST_SUITE_COUNT(hush_test);
+
+ return cmd_ut_category("hush", "hush_test_",
+ tests, n_ents, argc, argv);
+}
--
2.25.1
next prev parent reply other threads:[~2022-11-01 19:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 19:20 [RFC PATCH v5 00/24] Modernize U-Boot shell Francis Laniel
2022-11-01 19:20 ` Francis Laniel [this message]
2022-11-01 19:20 ` [RFC PATCH v5 02/24] test: hush: Test hush if/else Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 03/24] test/py: hush_if_test: Remove the test file Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 04/24] test: hush: Test hush variable expansion Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 05/24] test: hush: Test hush commands list Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 06/24] test: hush: Test hush loops Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 07/24] cli: Add Busybox upstream hush.c file Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 08/24] cli: Port Busybox 2021 hush to U-Boot Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 09/24] cli: Add menu for hush parser Francis Laniel
2022-11-07 12:32 ` Patrick DELAUNAY
2022-11-07 15:28 ` Simon Glass
2022-11-08 15:21 ` Tom Rini
2022-11-08 20:15 ` Simon Glass
2022-11-08 22:26 ` Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 10/24] global_data.h: add GD_FLG_HUSH_OLD_PARSER flag Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 11/24] cmd: Add new parser command Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 12/24] cli: Enables using hush 2021 parser as command line parser Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 13/24] cli: hush_2021: Enable variables expansion for hush 2021 Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 14/24] cli: hush_2021: Add functions to be called from run_command() Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 15/24] cli: add hush 2021 as parser for run_command*() Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 16/24] test: hush: Fix instructions list tests for hush 2021 Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 17/24] test: hush: Fix variable expansion " Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 19/24] cli: hush_2021: Enable if keyword Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 20/24] test: hush: Fix if tests for hush 2021 Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 21/24] cli: hush_2021: Enable loops Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 22/24] test: hush: Fix loop tests for hush 2021 Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 23/24] cli: hush_2021: Add upstream commits up to 24th March 2022 Francis Laniel
2022-11-01 19:20 ` [RFC PATCH v5 24/24] DO NOT MERGE: only to make CI happy Francis Laniel
2022-12-23 4:15 ` Marek Vasut
2022-12-31 14:49 ` Francis Laniel
2022-11-02 8:08 ` [RFC PATCH v5 00/24] Modernize U-Boot shell Holger Brunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221101192029.10231-2-francis.laniel@amarulasolutions.com \
--to=francis.laniel@amarulasolutions.com \
--cc=aleksandar.gerasimovski@hitachienergy.com \
--cc=holger.brunck@hitachienergy.com \
--cc=michael@amarulasolutions.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox